Issue metadata
Sign in to add a comment
|
Lock screen notification center shows unnecessary arrow |
||||||||||||||||||||||
Issue descriptionChrome Version: ToT OS: Chrome OS What steps will reproduce the problem? (1) Create notifications using Notification Galore! https://chrome.google.com/webstore/detail/notifications-galore/gclcddgeeaknflkijpcbplmhbkonmlij (2) Lock the Chromebook by Search-L (3) Click the bell icon on the right bottom What is the expected result? The arrow should not be shown as it's no-op here. Also the text "Unlock device to view your notifications" seems to be verbose. It might be better to rephrase this given the recent notification center restyling. +sgabriel@ Please confirm the expected behavior. What happens instead? The arrow is shown.
,
Jan 9 2018
,
Jan 9 2018
Assigning to myself so I don't forget to assign it to megumihattori@ when she gets bug access.
,
Jan 10 2018
,
Jan 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f617fe3f455f861350dfbac7d09227642eadd1f2 commit f617fe3f455f861350dfbac7d09227642eadd1f2 Author: Megumi Hattori <megumihattori@google.com> Date: Mon Jan 22 04:20:32 2018 Remove an unnecessary arrow from the lock screen notification center. The arrow was shown in the the lock screen notification center, but it should not be shown as it is no-op here. This implementation removes the arrow. TEST=ash_unittests BUG= 797861 Change-Id: Idf9db7bdb284cc2979e1fc3166d2be20ca8bdbee Reviewed-on: https://chromium-review.googlesource.com/867790 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Megumi Hattori <megumihattori@google.com> Cr-Commit-Position: refs/heads/master@{#530808} [modify] https://crrev.com/f617fe3f455f861350dfbac7d09227642eadd1f2/ash/message_center/message_center_button_bar.cc [modify] https://crrev.com/f617fe3f455f861350dfbac7d09227642eadd1f2/ash/message_center/message_center_button_bar.h [modify] https://crrev.com/f617fe3f455f861350dfbac7d09227642eadd1f2/ash/message_center/message_center_view_unittest.cc
,
Jan 22 2018
,
Feb 6 2018
Issue 793252 has been merged into this issue.
,
Feb 6 2018
Set P1 and ReleaseBlock-Stable by following Issue 793252
,
Feb 7 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9958c9884ae3671f35523b0cdd2d3a1d4f876a4 commit a9958c9884ae3671f35523b0cdd2d3a1d4f876a4 Author: Megumi Hattori <megumihattori@google.com> Date: Fri Feb 09 04:42:03 2018 Remove an unnecessary arrow from the lock screen notification center. The arrow was shown in the the lock screen notification center, but it should not be shown as it is no-op here. This implementation removes the arrow. TEST=ash_unittests BUG= 797861 Change-Id: Idf9db7bdb284cc2979e1fc3166d2be20ca8bdbee Reviewed-on: https://chromium-review.googlesource.com/867790 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Megumi Hattori <megumihattori@google.com> Cr-Original-Commit-Position: refs/heads/master@{#530808}(cherry picked from commit f617fe3f455f861350dfbac7d09227642eadd1f2) Reviewed-on: https://chromium-review.googlesource.com/910729 Cr-Commit-Position: refs/branch-heads/3325@{#399} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/a9958c9884ae3671f35523b0cdd2d3a1d4f876a4/ash/message_center/message_center_button_bar.cc [modify] https://crrev.com/a9958c9884ae3671f35523b0cdd2d3a1d4f876a4/ash/message_center/message_center_button_bar.h [modify] https://crrev.com/a9958c9884ae3671f35523b0cdd2d3a1d4f876a4/ash/message_center/message_center_view_unittest.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sgabr...@chromium.org
, Dec 28 2017