Nick, could you please take a look?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c9497064e7eb4b7dc9bc93c11e1a7f65181a9bb

commit 3c9497064e7eb4b7dc9bc93c11e1a7f65181a9bb
Author: Alexander Potapenko <glider@google.com>
Date: Thu Dec 28 15:21:46 2017

Disable flaky SitePerProcess/TaskManagerOOPIFBrowserTest.KillSubframe/0

BUG= 797860 
TBR=afakhry@chromium.org,nick@chromium.org

Change-Id: I0afe0990cf384c0b10b4bb6f547e8d54f021ee28
Reviewed-on: https://chromium-review.googlesource.com/845622
Reviewed-by: Alexander Potapenko <glider@chromium.org>
Commit-Queue: Alexander Potapenko <glider@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526296}
[modify] https://crrev.com/3c9497064e7eb4b7dc9bc93c11e1a7f65181a9bb/chrome/browser/task_manager/task_manager_browsertest.cc

Nick is on paternity leave and isn't around.

The test is failing with the renderer crash below.  Since this includes things like viz::mojom::InputTargetClient_FrameSinkIdAt_ForwardToCallback and content::RenderWidgetTargeter::FoundFrameSinkId, I'm wondering if it's related to the hit testing crashes since in the flaky test mentioned in  issue 798476 .  Navid, can you take a look?  Also including Sadrul and Gary.


[ RUN      ] SitePerProcess/TaskManagerOOPIFBrowserTest.KillSubframe/0
[4200:6728:1227/192237.299:WARNING:chrome_browser_main_win.cc(616)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=SitePerProcess/TaskManagerOOPIFBrowserTest.KillSubframe/0 --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir6172_31483\results6172_5718\test_results.xml" --test-launcher-summary-output="e:\b\swarm_slave\w\iohkvbk5\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir6172_31483\d6172_10182" --disable-offline-auto-reload --disable-device-discovery-notifications --site-per-process --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=TestFeatureForBrowserTest1 --disable-features=NetworkPrediction,TestFeatureForBrowserTest2 --flag-switches-begin --flag-switches-end --restore-last-session about:blank
[2472:5908:1227/192237.357:INFO:media_foundation_video_encode_accelerator_win.cc(370)] Windows versions earlier than 8 are not supported.
[4200:6728:1227/192237.737:WARNING:render_frame_host_impl.cc(2680)] OnDidStopLoading was called twice.
[4200:6728:1227/192237.751:WARNING:render_frame_host_impl.cc(2680)] OnDidStopLoading was called twice.
[4200:6728:1227/192237.784:ERROR:activity_tracker.cc(1485)] Recording exit of unknown process #348
[4200:7380:1227/192237.786:WARNING:embedded_test_server.cc(228)] Request not handled. Returning 404: /favicon.ico
Received fatal exception EXCEPTION_ACCESS_VIOLATION
Backtrace:
	content::RenderWidgetTargeter::QueryClient [0x02628B10+284]
	content::RenderWidgetTargeter::FoundFrameSinkId [0x02628F13+179]
	base::internal::FunctorTraits<void (__thiscall content::RenderWidgetTargeter::*)(base::WeakPtr<content::RenderWidgetHostViewBase>,base::WeakPtr<content::RenderWidgetHostViewBase>,blink::WebInputEvent const &,ui::LatencyInfo const &,base::Optional<gfx::Poi [0x0262945C+100]
	base::internal::Invoker<base::internal::BindState<void (__thiscall content::RenderWidgetTargeter::*)(base::WeakPtr<content::RenderWidgetHostViewBase>,base::WeakPtr<content::RenderWidgetHostViewBase>,blink::WebInputEvent const &,ui::LatencyInfo const &,bas [0x026293E5+101]
	base::RepeatingCallback<void __cdecl(enum blink::mojom::WebBluetoothResult)>::Run [0x04892570+46]
	viz::mojom::InputTargetClient_FrameSinkIdAt_ForwardToCallback::Accept [0x0211937A+202]
	mojo::InterfaceEndpointClient::HandleValidatedMessage [0x040F16F0+552]
	mojo::FilterChain::Accept [0x040F51C1+129]
	mojo::InterfaceEndpointClient::HandleIncomingMessage [0x040F24A8+104]
	mojo::internal::MultiplexRouter::ProcessIncomingMessage [0x040EB456+694]
	mojo::internal::MultiplexRouter::Accept [0x040EAF67+295]
	mojo::FilterChain::Accept [0x040F51C1+129]
	mojo::Connector::ReadSingleMessage [0x040F07CD+365]
	mojo::Connector::ReadAllAvailableMessages [0x040F0E83+85]
	mojo::Connector::OnHandleReadyInternal [0x040F0D52+124]
	base::internal::Invoker<base::internal::BindState<void (__thiscall update_client::TaskUpdate::*)(enum update_client::Error),base::internal::UnretainedWrapper<update_client::TaskUpdate> >,void __cdecl(enum update_client::Error)>::RunOnce [0x034A22AF+15]
	favicon::FaviconService::FaviconResultsCallbackRunner [0x037D89B8+24]
	base::internal::Invoker<base::internal::BindState<bool (__cdecl*)(GURL const &,content::WebContents *,navigation_interception::NavigationParams const &),GURL>,bool __cdecl(content::WebContents *,navigation_interception::NavigationParams const &)>::Run [0x04E38AA3+19]
	mojo::SimpleWatcher::OnHandleReady [0x040FC47E+222]
	base::internal::Invoker<base::internal::BindState<void (__thiscall mojo::SimpleWatcher::*)(int,unsigned int,mojo::HandleSignalsState const &),base::WeakPtr<mojo::SimpleWatcher>,int,unsigned int,mojo::HandleSignalsState>,void __cdecl(void)>::Run [0x040FC70A+58]
	base::debug::TaskAnnotator::RunTask [0x0359C785+229]
	base::internal::IncomingTaskQueue::RunTask [0x035B9967+103]
	base::MessageLoop::RunTask [0x03538B67+519]
	base::MessageLoop::DeferOrRunPendingTask [0x03538ECE+158]
	base::MessageLoop::DoWork [0x035390F8+504]
	base::MessagePumpForUI::DoRunLoop [0x035BC32D+125]
	base::MessagePumpWin::Run [0x035BBE8C+108]
	base::MessageLoop::Run [0x03538517+167]
	base::RunLoop::Run [0x0351A63A+202]
	base::RunLoop::RunUntilIdle [0x0351AA31+97]
	TaskManagerBrowserTest::HideTaskManager [0x015FD865+53]
	TaskManagerOOPIFBrowserTest_KillSubframe_Test::RunTestOnMainThread [0x015FD23B+2325]
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x03683689+265]
	ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x03F14FAA+3442]
	ChromeBrowserMainParts::PreMainMessageLoopRun [0x03F1417B+171]
	content::BrowserMainLoop::PreMainMessageLoopRun [0x023A1062+66]
	content::StartupTaskRunner::RunAllTasksNow [0x026BCA0C+30]
	content::BrowserMainLoop::CreateStartupTasks [0x0239FB14+656]
	content::BrowserMainRunnerImpl::Initialize [0x023A3B43+531]
	content::BrowserMain [0x0239E328+136]
	content::RunNamedProcessTypeMain [0x034DE88E+146]
	content::ContentMainRunnerImpl::Run [0x034DEE16+278]
	service_manager::Main [0x04944293+675]
	content::ContentMain [0x034DE7A5+49]
	content::BrowserTestBase::SetUp [0x036834B1+1697]
	InProcessBrowserTest::SetUp [0x035DF59A+346]
	testing::Test::Run [0x01C619C5+103]
	testing::TestInfo::Run [0x01C620DB+201]
	testing::TestCase::Run [0x01C62469+235]
	testing::internal::UnitTestImpl::RunAllTests [0x01C66231+625]
	testing::UnitTest::Run [0x01C65EE9+151]
	base::TestSuite::Run [0x035F7F14+100]
	ChromeTestSuiteRunner::RunTestSuite [0x0670852B+75]
	content::LaunchTests [0x03676E1D+389]
	LaunchChromeTests [0x06708843+143]
	main [0x067084A1+109]
	__scrt_common_main_seh [0x0730EF6A+248] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283)
	BaseThreadInitThunk [0x74A8337A+18]
	RtlInitializeExceptionChain [0x770C92B2+99]
	RtlInitializeExceptionChain [0x770C9285+54]

This isn't related to  issue 798476 , since it is a browser process crash not a renderer.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18f804b8f3826cfb27886b986e29c2ee3c8b2a14

commit 18f804b8f3826cfb27886b986e29c2ee3c8b2a14
Author: Navid Zolghadr <nzolghadr@chromium.org>
Date: Fri Jun 08 15:57:39 2018

Re-enable an OOPIF test to check for flakiness

Bug:  797860 
Change-Id: I8b9fd75051fa22040ff81defe252eb6de62c0b91
Reviewed-on: https://chromium-review.googlesource.com/1091690
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565644}
[modify] https://crrev.com/18f804b8f3826cfb27886b986e29c2ee3c8b2a14/chrome/browser/task_manager/task_manager_browsertest.cc

Since then we have fixed quite a few related issues. I enabled this test again last week and there doesn't seem to any flakiness. Closing this for now.