New issue
Advanced search Search tips

Issue 797855 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Overscroll history nav malfunction

Reported by willg...@gmail.com, Dec 28 2017

Issue description

UserAgent: Mozilla/5.0 (X11; CrOS x86_64 10254.0.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3299.0 Safari/537.36
Platform: 10254.0.0 (Official Build) canary-channel eve

Steps to reproduce the problem:
1. Use 2 finger horizontal swipe on touchpad

What is the expected behavior?
Forward/back nav happens smoothly

What went wrong?
The navigation hangs for a moment

Did this work before? N/A 

Chrome version: 65.0.3299.0  Channel: canary
OS Version: 10254.0.0
Flash Version: 

Only happens on the touchpad, it functions properly via touchscreen. And all other gestures work fine.
 
Cc: sahel@chromium.org
Components: UI>Browser>Navigation>GestureNav

Comment 2 by sahel@chromium.org, Jan 2 2018

Cc: -sahel@chromium.org dtapu...@chromium.org
Owner: sahel@chromium.org
Status: Assigned (was: Unconfirmed)
GFS used to complete the overscroll but with browserside touchpad fling the GSE at the end of the fling completes the overscroll action. The overscroll animation happens at the end of the fling rather than the beginning.
If it is something that needs to be fixed I can either change the overscroll controller to send unconsumed ack for GSUs in inertial state, or change the controller to complete the action on a GSU with inertial state.

Comment 3 by willg...@gmail.com, Jan 2 2018

An update, it lags with pull to refresh on the touchpad too.
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/345011cc0bbfbae7fed92327eda76baaeb5b83fe

commit 345011cc0bbfbae7fed92327eda76baaeb5b83fe
Author: Sahel Sharify <sahel@chromium.org>
Date: Fri Jan 12 19:36:42 2018

Early touchpad fling termination when overscroll mode is not none.

This cl terminates a fling when overscroll mode is not None and the ack
for a GSU generated from the fling progress arrives. The overscroll
action gets completed on GSE generated from the early fling termination.
Without this change the overscroll action would get completed on GSE
generated at the end of fling. The early fling termination saves
overscroll completion from waiting for the fling progress completion.
This change is particularly useful when the fling velocity is large.

Bug:  797855 
Test: FlingControllerTest.EarlyFlingCancelationOnFlingStop
Change-Id: Ic73bfd4225bcc4484700e339649fb2f448e37bbd
Reviewed-on: https://chromium-review.googlesource.com/855045
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529024}
[modify] https://crrev.com/345011cc0bbfbae7fed92327eda76baaeb5b83fe/content/browser/renderer_host/input/fling_controller.cc
[modify] https://crrev.com/345011cc0bbfbae7fed92327eda76baaeb5b83fe/content/browser/renderer_host/input/fling_controller.h
[modify] https://crrev.com/345011cc0bbfbae7fed92327eda76baaeb5b83fe/content/browser/renderer_host/input/fling_controller_unittest.cc
[modify] https://crrev.com/345011cc0bbfbae7fed92327eda76baaeb5b83fe/content/browser/renderer_host/input/gesture_event_queue.cc
[modify] https://crrev.com/345011cc0bbfbae7fed92327eda76baaeb5b83fe/content/browser/renderer_host/input/gesture_event_queue.h
[modify] https://crrev.com/345011cc0bbfbae7fed92327eda76baaeb5b83fe/content/browser/renderer_host/input/input_router.h
[modify] https://crrev.com/345011cc0bbfbae7fed92327eda76baaeb5b83fe/content/browser/renderer_host/input/input_router_impl.cc
[modify] https://crrev.com/345011cc0bbfbae7fed92327eda76baaeb5b83fe/content/browser/renderer_host/input/input_router_impl.h
[modify] https://crrev.com/345011cc0bbfbae7fed92327eda76baaeb5b83fe/content/browser/renderer_host/input/legacy_input_router_impl.cc
[modify] https://crrev.com/345011cc0bbfbae7fed92327eda76baaeb5b83fe/content/browser/renderer_host/input/legacy_input_router_impl.h
[modify] https://crrev.com/345011cc0bbfbae7fed92327eda76baaeb5b83fe/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/345011cc0bbfbae7fed92327eda76baaeb5b83fe/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/345011cc0bbfbae7fed92327eda76baaeb5b83fe/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/345011cc0bbfbae7fed92327eda76baaeb5b83fe/content/browser/renderer_host/render_widget_host_view_aura.cc

Comment 5 by sahel@chromium.org, Jan 15 2018

Status: Fixed (was: Assigned)

Comment 6 by derat@chromium.org, Feb 24 2018

Issue 815441 has been merged into this issue.

Sign in to add a comment