Add unit tests for cryptohome_util.cc |
||
Issue descriptionAs per the title, these methods never had unit tests, but now that they are in their own utility this should be marginally easier to do now. We should add unit tests to get, at the very least, some minimal coverage.
,
Jan 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a0654a80377fa72e652195c43e228245d5aba04 commit 1a0654a80377fa72e652195c43e228245d5aba04 Author: Maajid <maajid@chromium.org> Date: Tue Jan 23 07:49:49 2018 Add unit test for CryptohomeUtil. Bug: 797848 Change-Id: Iea1a735a5462b09f7a126ef75fb28a09df3c97c9 Reviewed-on: https://chromium-review.googlesource.com/875742 Commit-Queue: Maajid <maajid@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#531176} [modify] https://crrev.com/1a0654a80377fa72e652195c43e228245d5aba04/chromeos/BUILD.gn [modify] https://crrev.com/1a0654a80377fa72e652195c43e228245d5aba04/chromeos/cryptohome/cryptohome_util.cc [add] https://crrev.com/1a0654a80377fa72e652195c43e228245d5aba04/chromeos/cryptohome/cryptohome_util_unittest.cc
,
Jul 28
Closing as this was fixed a long time ago |
||
►
Sign in to add a comment |
||
Comment 1 by maajid@chromium.org
, Jan 18 2018Status: Started (was: Untriaged)