Catapult requires that all CLs have an associated crbug.
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/9cdc8e0a47cd1881306cbcac03a31978480f92af commit 9cdc8e0a47cd1881306cbcac03a31978480f92af Author: erikchen <erikchen@chromium.org> Date: Tue Jan 02 21:02:33 2018 Add explicit --is-local-build flag. The previous logic no longer works now that full paths are no longer emitted. Bug: chromium:797843 Change-Id: I564831846c3ac3d559114f6504542297210c2b12 Reviewed-on: https://chromium-review.googlesource.com/845280 Reviewed-by: Erik Chen <erikchen@chromium.org> Reviewed-by: Etienne Bergeron <etienneb@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> [modify] https://crrev.com/9cdc8e0a47cd1881306cbcac03a31978480f92af/tracing/tracing/extras/symbolizer/symbolize_trace.py
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/fd4df5b8770626a264b7c85d05d41025ecfab848 commit fd4df5b8770626a264b7c85d05d41025ecfab848 Author: erikchen <erikchen@chromium.org> Date: Mon Jan 29 16:35:15 2018 Change assert to instead log a warning. If regions overlap, then symbolization will be slightly messed up. But this happens in real heap dumps because of weirdness with the weird way that macOS maps system shared libraries. Instead of throwing an assert, just print a warning. Bug: chromium:797843 Change-Id: Id473e79c1bde2e8b6982b9066291be9306c419f5 Reviewed-on: https://chromium-review.googlesource.com/886881 Reviewed-by: Etienne Bergeron <etienneb@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> [modify] https://crrev.com/fd4df5b8770626a264b7c85d05d41025ecfab848/tracing/tracing/extras/symbolizer/symbolize_trace.py
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/f67ec16f0a899d9d8e2038cb750937ae91fa8a13 commit f67ec16f0a899d9d8e2038cb750937ae91fa8a13 Author: erikchen <erikchen@chromium.org> Date: Wed Jan 31 20:02:37 2018 Fix a symbolize_trace issue with new traces being emitted by OOP HP. OOP HP now uses "1" as the starting ID for strings. The symbolize_trace script expects that "0" exists, even though that condition is not used/required anywhere else. The tests have been changed from being change-detector tests to actually check for a correctly symbolized frame, along with a parent frame. Bug: chromium:797843 Change-Id: Ia460e6ee33bff65f212aacd6f38a9c74f39659f7 Reviewed-on: https://chromium-review.googlesource.com/891925 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Erik Chen <erikchen@chromium.org> [delete] https://crrev.com/fa6654b41ef2c3eba12dbcb7ba9a44501de357ee/tracing/tracing/extras/symbolizer/data/mac_trace_v1_postsymbolization.json.gz.sha1 [delete] https://crrev.com/fa6654b41ef2c3eba12dbcb7ba9a44501de357ee/tracing/tracing/extras/symbolizer/data/mac_trace_v1_presymbolization.json.gz.sha1 [modify] https://crrev.com/f67ec16f0a899d9d8e2038cb750937ae91fa8a13/tracing/tracing/extras/symbolizer/symbolize_trace.py [delete] https://crrev.com/fa6654b41ef2c3eba12dbcb7ba9a44501de357ee/tracing/tracing/extras/symbolizer/data/windows_trace_v2_postsymbolization.json.gz.sha1 [modify] https://crrev.com/f67ec16f0a899d9d8e2038cb750937ae91fa8a13/tracing/tracing/extras/symbolizer/symbolize_trace_end_to_end_test_slow.py [add] https://crrev.com/f67ec16f0a899d9d8e2038cb750937ae91fa8a13/tracing/tracing/extras/symbolizer/data/mac_trace_v2_presymbolization.json.gz.sha1 [delete] https://crrev.com/fa6654b41ef2c3eba12dbcb7ba9a44501de357ee/tracing/tracing/extras/symbolizer/data/windows_trace_v1_postsymbolization.json.gz.sha1 [delete] https://crrev.com/fa6654b41ef2c3eba12dbcb7ba9a44501de357ee/tracing/tracing/extras/symbolizer/data/mac_trace_v1_breakpad_postsymbolisation.json.gz.sha1 [delete] https://crrev.com/fa6654b41ef2c3eba12dbcb7ba9a44501de357ee/tracing/tracing/extras/symbolizer/data/linux_trace_v2_breakpad_postsymbolization.json.gz.sha1
Comment 1 by bugdroid1@chromium.org
, Jan 2 2018