New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 797838 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 780980
Owner: ----
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Fail to compile share_menu_controller_browsertest.cc with MacOSX10.13.sdk

Reported by halton....@gmail.com, Dec 28 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.108 Safari/537.36

Steps to reproduce the problem:
Environment:
* MacOS High Sierra 10.13.2
* Xcode 9.2 (9C40b)
* SDK: 10.13
* Chromium source code: 62a4fb9f3
* GN config: is_debug=false is_component_build=true

What is the expected behavior?
Able to build chrome

What went wrong?
$ ninja -C out/Release_shared/
ninja: Entering directory `out/Release_shared/'
[3/45] OBJCXX obj/chrome/test/browser_tests/share_menu_controller_browsertest.o
FAILED: obj/chrome/test/browser_tests/share_menu_controller_browsertest.o
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/test/browser_tests/share_menu_controller_browsertest.o.d -DHAS_OUT_OF_PROC_TEST_RUNNER -DV8_DEPRECATION_WARNINGS -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_XCODE_VERSION=0920 -DCR_CLANG_REVISION=\"318667-1\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DCOMPONENT_BUILD -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGTEST_API_= -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=1 -DWEBP_EXTERN=extern -DTOOLKIT_VIEWS=1 -DEXPAT_RELATIVE_PATH -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DPROTOBUF_USE_DLLS -DV8_USE_EXTERNAL_STARTUP_DATA -DBORINGSSL_SHARED_LIBRARY -DLEVELDB_PLATFORM_CHROMIUM=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSKIA_DLL -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_SUPPORT_GPU=1 -DSK_BUILD_FOR_MAC -DMESA_EGL_NO_X11_HEADERS -DUSING_V8_SHARED -DI18N_ADDRESS_VALIDATION_DATA_URL=\"https://chromium-i18n.appspot.com/ssl-aggregate-address/\" -DUNIT_TEST -DUSE_LIBJPEG_TURBO=1 -DUSING_V8_SHARED -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=0 -DFEATURE_ENABLE_VOICEMAIL -DGTEST_RELATIVE_PATH -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_MAC -DXML_STATIC -I../.. -Igen -I../../third_party/googletest/src/googletest/include -I../../third_party/libwebp/src -I../../third_party/khronos -I../../gpu -I../../third_party/libyuv/include -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/protobuf/src -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/boringssl/src/include -I../../third_party/leveldatabase -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase/src/include -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/encode -I../../third_party/skia/include/gpu -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/vulkan/include -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl -I../../third_party/mesa/src/include -I../../third_party/libwebm/source -Igen -I../../third_party/WebKit -Igen/third_party/WebKit -I../../v8/include -Igen/v8/include -I../../third_party/WebKit/Source -I../../third_party/WebKit -Igen/blink -Igen/third_party/WebKit -Igen/third_party/metrics_proto -I../../third_party/re2/src -Igen -Igen -I../../third_party/google_toolbox_for_mac -I../../third_party/google_toolbox_for_mac/src -I../../third_party/google_toolbox_for_mac/src/AppKit -I../../third_party/google_toolbox_for_mac/src/DebugUtils -I../../third_party/google_toolbox_for_mac/src/Foundation -I../../third_party/libaddressinput/src/cpp/include -I../../third_party/googletest/custom -I../../third_party/googletest/src/googlemock/include -I../../third_party/cacheinvalidation/overrides -I../../third_party/cacheinvalidation/src -I../../third_party/flatbuffers/src/include -I../../third_party/libjpeg_turbo -I../../third_party/iccjpeg -I../../third_party/libpng -I../../third_party/zlib -I../../third_party/ots/include -I../../v8/include -Igen/v8/include -I../../third_party/breakpad/breakpad/src/client/apple/Framework -I../../third_party/ocmock -I../../third_party/webrtc_overrides -I../../third_party/webrtc -I../../third_party/webrtc_overrides -I../../testing/gtest/include -I../../third_party/webrtc -I../../third_party/expat/files/lib -fno-strict-aliasing -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -fcolor-diagnostics -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -no-canonical-prefixes -arch x86_64 -Wall -Werror -Wextra -Wunguarded-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -Wno-tautological-unsigned-zero-compare -Wno-null-pointer-arithmetic -Wno-tautological-constant-compare -Wtautological-constant-out-of-range-compare -O2 -fno-omit-frame-pointer -gdwarf-2 -isysroot ../../../../../../../Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk -mmacosx-version-min=10.9.0 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin.dylib -Xclang -add-plugin -Xclang blink-gc-plugin -Wno-exit-time-destructors -std=c++14 -stdlib=libc++ -fobjc-call-cxx-cdtors -Wobjc-missing-property-synthesis -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -include obj/chrome/test/browser_tests/precompile.h-mm -c ../../chrome/browser/ui/cocoa/share_menu_controller_browsertest.mm -o obj/chrome/test/browser_tests/share_menu_controller_browsertest.o
../../chrome/browser/ui/cocoa/share_menu_controller_browsertest.mm:230:29: error: null passed to a callee that requires a non-null argument [-Werror,-Wnonnull]
  EXPECT_FALSE([controller_ menuHasKeyEquivalent:menu
                            ^
../../third_party/googletest/src/googletest/include/gtest/gtest.h:1863:25: note: expanded from macro 'EXPECT_FALSE'
  GTEST_TEST_BOOLEAN_(!(condition), #condition, true, false, \
                        ^~~~~~~~~
../../third_party/googletest/src/googletest/include/gtest/internal/gtest-internal.h:1215:34: note: expanded from macro 'GTEST_TEST_BOOLEAN_'
      ::testing::AssertionResult(expression)) \
                                 ^~~~~~~~~~
../../chrome/browser/ui/cocoa/share_menu_controller_browsertest.mm:230:29: error: null passed to a callee that requires a non-null argument [-Werror,-Wnonnull]
  EXPECT_FALSE([controller_ menuHasKeyEquivalent:menu
                            ^
../../third_party/googletest/src/googletest/include/gtest/gtest.h:1863:25: note: expanded from macro 'EXPECT_FALSE'
  GTEST_TEST_BOOLEAN_(!(condition), #condition, true, false, \
                        ^~~~~~~~~
../../third_party/googletest/src/googletest/include/gtest/internal/gtest-internal.h:1215:34: note: expanded from macro 'GTEST_TEST_BOOLEAN_'
      ::testing::AssertionResult(expression)) \
                                 ^~~~~~~~~~
../../chrome/browser/ui/cocoa/share_menu_controller_browsertest.mm:239:16: error: null passed to a callee that requires a non-null argument [-Werror,-Wnonnull]
  [controller_ menuHasKeyEquivalent:menu forEvent:event target:nil action:nil];
               ^                                               ~~~
../../chrome/browser/ui/cocoa/share_menu_controller_browsertest.mm:239:16: error: null passed to a callee that requires a non-null argument [-Werror,-Wnonnull]
  [controller_ menuHasKeyEquivalent:menu forEvent:event target:nil action:nil];
               ^                                                          ~~~
4 errors generated.
[8/45] OBJCXX obj/chrome/test/browser_tests/task_manager_mac_browsertest.o
ninja: build stopped: subcommand failed.

Did this work before? N/A 

Chrome version: 63.0.3239.108  Channel: canary
OS Version: OS X 10.13.2
Flash Version: 

If switch SDK to 10.12, everything is fine.
 
Cc: sc00335...@techmahindra.com
Components: Build
Labels: Needs-Triage-M63 Triaged-ET TE-NeedsTriageHelp
The issue seems to be out of TE-scope as we need to build chrome. Hence, adding the label TE-NeedsTriageHelp for further investigation from dev team        
Sorry, I meant share_menu_controller_browsertest.mm

Comment 3 by meh...@chromium.org, Dec 28 2017

Cc: lgrey@chromium.org
+lgrey, who is working on the share menu. May be he has an idea. Thanks.

Comment 4 by lgrey@chromium.org, Dec 28 2017

Mergedinto: 780980
Status: Duplicate (was: Unconfirmed)

Comment 5 by thakis@chromium.org, Dec 28 2017

I don't think this is a dupe. We should always be able to build with the 10.13 SDK; the other bug is about doing so by default. (I think.)

Comment 6 by lgrey@chromium.org, Dec 28 2017

You know better, but haven't we historically had to make a bunch of tweaks like this re: deprecated methods, nullability etc. when we want to build with a new SDK?

Sign in to add a comment