New issue
Advanced search Search tips

Issue 797836 link

Starred by 1 user
Status: Fixed
Owner:
ericwilligers@chromium.org
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

CSS offset-path: Transitions between incompatible rays fail

Project Member Reported by ericwilligers@chromium.org, Dec 28 2017 
See LayoutTests/animations/interpolation/offset-path-interpolation-005-expected.txt

FAIL CSS Transitions with transition: all: property <offset-path> from [ray(200deg farthest-side contain)] to [ray(300deg sides)] at (0.3) is [none] assert_equals: expected "ray ( 300deg sides ) " but got "none "

When the from and to values have the same <size> and same contain?, the transition succeeds.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/365506ebbab6ecde1e9c5c7baa8894186123479a

commit 365506ebbab6ecde1e9c5c7baa8894186123479a
Author: Eric Willigers <ericwilligers@chromium.org>
Date: Thu Dec 28 08:06:56 2017

CSS offset-path: Transitions between incompatible rays flip

We previously experienced
FAIL CSS Transitions with transition: all: property <offset-path>
from [ray(200deg farthest-side contain)]
to [ray(300deg sides)] at (0.3) is [none]

offset-path can animate as a ray <angle> or as a path string,
and unfortunately empty path string interpolation was being used.

BUG= 797836 

Change-Id: Ia54bf4aa2e208f3994c4cea1789111840571eeac
Reviewed-on: https://chromium-review.googlesource.com/845460
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526283}
[delete] https://crrev.com/b6f498da7d08c8f3273b2685f761feaf70882073/third_party/WebKit/LayoutTests/animations/interpolation/offset-path-interpolation-005-expected.txt
[modify] https://crrev.com/365506ebbab6ecde1e9c5c7baa8894186123479a/third_party/WebKit/Source/core/animation/PathInterpolationFunctions.cpp

Comment 2 by ericwilligers@chromium.org, Dec 28 2017

Status: Fixed (was: Started)
►

Sign in to add a comment