New issue
Advanced search Search tips

Issue 797796 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Crash in _sk_load_bgra_sse2

Project Member Reported by ClusterFuzz, Dec 27 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5895407032074240

Fuzzer: sugoi_filter_fuzzer
Job Type: linux_asan_filter_fuzz_stub
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x7f256684d800
Crash State:
  _sk_load_bgra_sse2
  SkScan::FillIRect
  SkScan::FillIRect
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_filter_fuzz_stub&range=488849:488966

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5895407032074240

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Dec 27 2017

Components: Internals>Skia
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Dec 27 2017

Cc: brianosman@google.com reed@google.com
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

Add category support to JSON and SkDebugf tracing by brianosman@google.com - https://skia.googlesource.com/skia/+/65e4c614f0edbcf8d05bfc2a25a6e60d277fb7df

clean read/write pixels signatures, augment SkSurface API by reed@google.com - https://skia.googlesource.com/skia/+/353196f44f8c4f5fc3dc3783241faef264b80927

If this is incorrect, please apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 3 by sheriffbot@chromium.org, Dec 28 2017

Labels: M-64
Project Member

Comment 4 by sheriffbot@chromium.org, Dec 28 2017

Labels: Pri-1

Comment 5 by rsesek@chromium.org, Dec 28 2017

Owner: mtklein@chromium.org
Status: Assigned (was: Untriaged)
mtklein: It seems likely this is from https://skia.googlesource.com/skia/+/3b59af5bf88920515835c79fe07c302438dc8e55 can you take a look?
Project Member

Comment 6 by sheriffbot@chromium.org, Jan 11 2018

mtklein: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/548d387ab935349edd03149502fff8ebe467b5b0

commit 548d387ab935349edd03149502fff8ebe467b5b0
Author: Mike Klein <mtklein@chromium.org>
Date: Wed Jan 24 21:39:00 2018

Keep SkRasterPipelineSpriteBlitter's src/dst offset math in size_t

With big enough y and stride (e.g. 27 and ~20000000) the expression

    - bpp*x - bpp*y*fSrcPtr.stride

can underflow, and cause mayhem.

Bug:  chromium:797796 
Change-Id: Ifc412230c4c7eadfcd36446113be9ac1753b5b1c
Reviewed-on: https://skia-review.googlesource.com/99343
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>

[modify] https://crrev.com/548d387ab935349edd03149502fff8ebe467b5b0/src/core/SkBlitter_Sprite.cpp

Project Member

Comment 8 by ClusterFuzz, Jan 25 2018

ClusterFuzz has detected this issue as fixed in range 531767:531771.

Detailed report: https://clusterfuzz.com/testcase?key=5895407032074240

Fuzzer: sugoi_filter_fuzzer
Job Type: linux_asan_filter_fuzz_stub
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x7f256684d800
Crash State:
  _sk_load_bgra_sse2
  SkScan::FillIRect
  SkScan::FillIRect
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_filter_fuzz_stub&range=488849:488966
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_filter_fuzz_stub&range=531767:531771

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5895407032074240

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Jan 25 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5895407032074240 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Feb 8 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -M-64 M-66
Labels: Release-0-M66
Project Member

Comment 13 by sheriffbot@chromium.org, May 3 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment