New issue
Advanced search Search tips

Issue 797792 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
pastarmovj@chromium.org
rhalavati@chromium.org
eroman@chromium.org
mmenke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Add network traffic annotations to NetLog

Project Member Reported by eroman@chromium.org, Dec 27 2017 
The trivial change would be to add URLRequest::traffic_annotation() to URL_REQUEST_START_JOB.

The problem with this approach is that URLRequest::traffic_annotation() is merely an integer (hash of the description), so the resulting log is not readable.

Would additionally want pretty-printing of the NetLog to do a reverse-mapping from the NetworkTrafficAnnotationTag to the description text.

Comment 1 by rhalavati@chromium.org, Jan 8 2018

Cc: pastarmovj@chromium.org
The long term plan is to publish the list of all annotations for the use of admins, as in this sheet: go/network_traffic_annotations_sheet

I think the easiest way to start is to keep a mapping of hash codes to unique id texts of annotations in the NetLog viewer. This list can be found now in tools/traffic_annotation/summary/annotations.xml, where 'id' and 'hash_code' have the required values. There around 200 annotations now in the code, and the ids are in average almost 25 characters, so it will be around 5K, uncompressed text.

Comment 2 by rhalavati@chromium.org, Jan 8 2018

Cc: rhalavati@chromium.org
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 8

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by eroman@chromium.org, Jan 8

Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)
►

Sign in to add a comment