New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 797752 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unnecessary Tab focus is seen on 'App Launcher' Icon in Second User

Project Member Reported by mmanchala@chromium.org, Dec 27 2017

Issue description

Chrome Version: 65.0.3299.0/10253.0.0 Peppy,Candy,Gnawty
OS: Chrome

What steps will reproduce the problem?
(1)Sign in to user -> logout -> sign in to another user -> Go to Uber tray -> click on user I'd and select 'Sign in to another user...' option
for Multiple sign-in
(2)In  Multiple sign-in screen -> Press 'Tab' button auntil focus reaches on 'cancel option -> Now click on enter and observe unnecessary tab blue focus is seen on 'App Launcher' Icon and even on clicking outside of the screen focus is not getting vanished (Please refer video)

Expected: No Such tab blue focus should be seen on 'App Launcher' Icon
Actual: Instead tab blue focus is seen on 'App Launcher' Icon

This is Regression issue as same is working fine in 63.0.3239.116/10032.75.0 Stable-channel Candy
 
Actual_TabFocusOnAppLauncherIcon.mp4
13.2 MB View Download
Expected_NoTabFocusOnAppLauncherIcon.mp4
10.7 MB View Download

Comment 1 by wzang@chromium.org, Dec 27 2017

Cc: -wzang@chromium.org
Owner: wzang@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by kochi@chromium.org, Dec 28 2017

Components: -Blink>HTML>Focus
This is not a Blink issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e216da29bebdd1011e81811769f7cc324e7accf7

commit e216da29bebdd1011e81811769f7cc324e7accf7
Author: Wenzhao Zang <wzang@chromium.org>
Date: Thu Jan 25 18:00:23 2018

cros: Clear focus for Cancel button on shelf

Clear focus for Cancel button only, because other types of buttons
may still want to keep the focus after being pressed. (Although,
currently no other buttons really need to keep the focus: they either
trigger restart of Chrome, or the login/lock screen will explicitly
request the focus.)

Bug:  797752 
Change-Id: Ib48969e61472c3e6ccda2a413d5ec3d719754ef4
Reviewed-on: https://chromium-review.googlesource.com/885624
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531939}
[modify] https://crrev.com/e216da29bebdd1011e81811769f7cc324e7accf7/ash/shelf/login_shelf_view.cc
[modify] https://crrev.com/e216da29bebdd1011e81811769f7cc324e7accf7/ash/shelf/shelf_widget.cc

Comment 4 by wzang@chromium.org, Jan 25 2018

Labels: -ReleaseBlock-Stable
Status: Fixed (was: Assigned)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-65; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-65 label, otherwise remove Merge-TBD label. Thanks.

Comment 6 by wzang@chromium.org, Jan 25 2018

Labels: -Merge-TBD

Sign in to add a comment