Content of item in column not painted anymore if position absolute set after a custom font has been loaded
Reported by
m...@webhare.nl,
Dec 27 2017
|
|||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.108 Safari/537.36 Steps to reproduce the problem: 1. run the testcase 2. see item 2's content not being painted anymore when the script sets position: absolute; on it. (or when you do it by hand) What is the expected behavior? Content should stay visible, just at the absolute position instead of in the flow of the column. What went wrong? Content is not painted. It happens due the combination of rounded clipping (border-radius + overflow:hidden), a custom font having been loaded and the item being removed from the column flow by applying position: absolute to it. Did this work before? Yes Chrome 62 Does this work in other browsers? Yes Chrome version: 63.0.3239.108 Channel: stable OS Version: OS X 10.12.6 Flash Version: Shockwave Flash 28.0 r0
,
Dec 28 2017
Able to reproduce this issue on reported version 63.0.3239.108 and latest canary 65.0.3305.0 using Windows 10, Ubuntu 14.04 and Mac 10.13.1 with html file given in comment#0. Good Build: 63.0.3211.0 Bad Build: 63.0.3212.0 You are probably looking for a change made after 500791 (known good), but no later than 500792 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/d09b058a2fca054098e5bd14385516425766519b..c3a3481c4b1b08775b477144d1d2873a2a3d9900 Reviewed-on: https://chromium-review.googlesource.com/646700 Suspecting same from changelog. @chrishtr: Please confirm the issue and help in re-assigning if it is not related to your change. Adding RB-Stable as this is broken in M63. Please remove if not the case. Thanks!
,
Dec 28 2017
Further reduced testcase attached.
,
Dec 29 2017
,
Dec 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59388664eb816df4b0757190da4e2d20d5989770 commit 59388664eb816df4b0757190da4e2d20d5989770 Author: Chris Harrelson <chrishtr@chromium.org> Date: Fri Dec 29 03:10:53 2017 [PE] Clear pagination offset on fragmentation update. Previously there was a bug in which we left a stale pagination offset when an element became un-paginated. Bug: 797751 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I226f285f31c4ea1769870c73584916b8f1083441 Reviewed-on: https://chromium-review.googlesource.com/846343 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#526356} [modify] https://crrev.com/59388664eb816df4b0757190da4e2d20d5989770/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp [modify] https://crrev.com/59388664eb816df4b0757190da4e2d20d5989770/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
,
Dec 29 2017
,
Dec 30 2017
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 2 2018
Approving merge to M64. Branch:3282
,
Jan 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30ec8698f41076b18fa68a99f8c07dcb070b24ac commit 30ec8698f41076b18fa68a99f8c07dcb070b24ac Author: Chris Harrelson <chrishtr@chromium.org> Date: Tue Jan 02 18:50:55 2018 [PE] Clear pagination offset on fragmentation update. Previously there was a bug in which we left a stale pagination offset when an element became un-paginated. TBR=chrishtr@chromium.org (cherry picked from commit 59388664eb816df4b0757190da4e2d20d5989770) Bug: 797751 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I226f285f31c4ea1769870c73584916b8f1083441 Reviewed-on: https://chromium-review.googlesource.com/846343 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#526356} Reviewed-on: https://chromium-review.googlesource.com/847307 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#385} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/30ec8698f41076b18fa68a99f8c07dcb070b24ac/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
,
Jan 2 2018
,
Jan 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7d030dd759bceef17667487fe78f091432aef7c commit a7d030dd759bceef17667487fe78f091432aef7c Author: Abdul Syed <abdulsyed@google.com> Date: Wed Jan 03 03:43:46 2018 Revert "[PE] Clear pagination offset on fragmentation update." This reverts commit 30ec8698f41076b18fa68a99f8c07dcb070b24ac. Reason for revert: <INSERT REASONING HERE> Original change's description: > [PE] Clear pagination offset on fragmentation update. > > Previously there was a bug in which we left a stale pagination offset > when an element became un-paginated. > > TBR=chrishtr@chromium.org > > (cherry picked from commit 59388664eb816df4b0757190da4e2d20d5989770) > > Bug: 797751 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I226f285f31c4ea1769870c73584916b8f1083441 > Reviewed-on: https://chromium-review.googlesource.com/846343 > Commit-Queue: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#526356} > Reviewed-on: https://chromium-review.googlesource.com/847307 > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/branch-heads/3282@{#385} > Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} TBR=wangxianzhu@chromium.org,chrishtr@chromium.org Change-Id: I7a3247f9f304f268e782e594fc2eb0d7774fe7b7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 797751 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/848512 Reviewed-by: Abdul Syed <abdulsyed@google.com> Cr-Commit-Position: refs/branch-heads/3282@{#392} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/a7d030dd759bceef17667487fe78f091432aef7c/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
,
Jan 3 2018
Able to reproduce this issue on 64.0.3282.71 using Windows10,Mac 10.13.1 and Ubuntu 14.04 i.e; Content is not seen on second box, due to revert of the CL in comment#11.
,
Jan 3 2018
chrishtr@, the above CL has been reverted because of official build failure(crbug/798645). Can you please merge this revert to 3282 branch again by resolving build compilation issues? Thank you!
,
Jan 3 2018
,
Jan 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00499f8784518657657ce63c5bac46eb3b84f832 commit 00499f8784518657657ce63c5bac46eb3b84f832 Author: Chris Harrelson <chrishtr@chromium.org> Date: Wed Jan 03 20:25:14 2018 Manual merge into the M64 beta branch: Clear pagination offset on fragmentation update. https://chromium-review.googlesource.com/846343 Tbr: schenney@chromium.org Bug: 797751 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I8dae9beea635830a42e555bff17d07ff07348d24 Reviewed-on: https://chromium-review.googlesource.com/849255 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#402} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/00499f8784518657657ce63c5bac46eb3b84f832/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
,
Jan 3 2018
,
Jan 10 2018
Verified the fix on Mac 10.13.1, Win-10 and Ubuntu 14.04 using latest Chrome beta version #64.0.3282.85 as per comment#15. Attaching screen shot for reference. Observed that content is seen in both the boxes.Hence, the fix is working as expected. Adding the verified labels. Thanks...!! |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by krajshree@chromium.org
, Dec 27 2017