New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 797749 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Default cursor is seen missing in 'ENTER SIM PIN' Dialog box

Project Member Reported by mmanchala@chromium.org, Dec 27 2017

Issue description

Chrome Version: 65.0.3299.0/10253.0.0 Peppy,Candy,Gnawty
OS: Chrome

What steps will reproduce the problem?
1)Sign into User ->Insert Mobile Dongle and ensure it is connected
(2)Now go to chrome://settings page -> At Internet Connection click on Cellular connection -> Navigates to Cellular connected page
(3)Now Enable 'Enable SIM Card locking(require PIN to use Mobile data) option -> 'ENTER SIM PIN' Dialog box is seen -> Observe Default focus and cursor is 
seen missing (Please refer Video and Screenshot)

Expected: Default focus and cursor should be seen in 'ENTER SIM PIN' Dialog box
Actual: Instead Default focus and cursor is seen missing

This is Regression issue as same is working fine in 63.0.3239.116/10032.75.0 Stable-channel Candy

@stevenjb : Please confirm the Issue
 
Actual_NoCursor.webm
548 KB View Download
Actual_NoFocusAndCursor.jpg
182 KB View Download
Expected_FocusAndCursor.webm
295 KB View Download
Expected_FocusAndCursor.jpg
191 KB View Download
Labels: -Pri-1 Pri-2
It looks like the field is focusable, just not focused by default?

Downgrading to a P2.

Any update on this? 

It is marked as a beta blocker for 65, and the beta promotion date is only a week away.
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/add89c261260aa4c2b196f6ee0fdd60d6fd91c7f

commit add89c261260aa4c2b196f6ee0fdd60d6fd91c7f
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Feb 01 20:28:11 2018

Network sim unlock: fix focus and disable buttons when in progress

This fixes a couple of minor sim unlock polish issues.

Bug:  797749 ,  786344 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9140397f4723c27514e09ce38cd2e527c231e9a9
Reviewed-on: https://chromium-review.googlesource.com/897823
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533798}
[modify] https://crrev.com/add89c261260aa4c2b196f6ee0fdd60d6fd91c7f/ui/webui/resources/cr_components/chromeos/network/network_siminfo.html
[modify] https://crrev.com/add89c261260aa4c2b196f6ee0fdd60d6fd91c7f/ui/webui/resources/cr_components/chromeos/network/network_siminfo.js

Labels: Merge-Request-65
Status: Fixed (was: Started)
Project Member

Comment 6 by sheriffbot@chromium.org, Feb 2 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 5 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9130c715daa88497843d09c66de6d7eacdec8ae2

commit 9130c715daa88497843d09c66de6d7eacdec8ae2
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Feb 05 20:05:10 2018

Network sim unlock: fix focus and disable buttons when in progress

This fixes a couple of minor sim unlock polish issues.

TBR=stevenjb@chromium.org

(cherry picked from commit add89c261260aa4c2b196f6ee0fdd60d6fd91c7f)

Bug:  797749 ,  786344 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9140397f4723c27514e09ce38cd2e527c231e9a9
Reviewed-on: https://chromium-review.googlesource.com/897823
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#533798}
Reviewed-on: https://chromium-review.googlesource.com/902428
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#314}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/9130c715daa88497843d09c66de6d7eacdec8ae2/ui/webui/resources/cr_components/chromeos/network/network_siminfo.html
[modify] https://crrev.com/9130c715daa88497843d09c66de6d7eacdec8ae2/ui/webui/resources/cr_components/chromeos/network/network_siminfo.js

Sign in to add a comment