New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 797738 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner: ----
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

CL merged but still appears as open on gerrit

Project Member Reported by jcliang@chromium.org, Dec 27 2017

Issue description

The CL in question: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/843374

CQ reported failure to apply the patch in build 17316, but the CL was picked by by CQ on build 17315. Build 17315 did not succeed but the CL was merged anyway, and somehow caused some discrepancy as the CL on gerrit is still open.
 
Cc: akes...@chromium.org
From https://logs.chromium.org/v/?s=chromeos%2Fbb%2Fchromeos%2Fmaster-paladin%2F17315%2F%2B%2Frecipes%2Fsteps%2FCommitQueueCompletion%2F0%2Fstdout

The last update from the CommitQueueCompletion stage regarding if the CL is valid for commit:

11:25:36: INFO: Processing relevant changes of build whirlwind-paladin status COMPLETED result FAILURE
11:25:36: INFO: Processing changes in might submit set.
11:25:36: INFO: will_submit set contains 0 changes: []
might_submit set contains 1 changes: [CL:843374]
will_not_submit set contains 0 changes: []

Given the only failure was on whirlwind-paladin, which is not on 4.4 kernel, it's legit to merge the CL despite the CQ run was marked as failed.

It looks to me the issue is on the status sync front. There's a another bug that might be related: https://bugs.chromium.org/p/chromium/issues/detail?id=797621 
Summary: CL merged but still appears as open on gerrit (was: CL merged despite of failed CQ run)
CL:843374 was merged in build 17315 but something went wrong on gerrit:

https://logs.chromium.org/v/?s=chromeos%2Fbb%2Fchromeos%2Fmaster-paladin%2F17315%2F%2B%2Frecipes%2Fsteps%2FCommitQueueHandleChanges%2F0%2Fstdout

11:27:04: INFO: Checking change CL:843374; relevant configs ['wolf-paladin', 'betty-paladin', 'caroline-paladin', 'leon-paladin', 'guado_moblab-paladin', 'lumpy-paladin', 'lakitu-gpu-paladin', 'falco-full-compile-paladin', 'parrot-paladin', 'tidus-paladin', 'guado-paladin', 'stumpy-paladin', 'zoombini-paladin', 'reef-paladin', u'master-paladin', 'amd64-generic-paladin', 'betty-arc64-paladin', 'cave-paladin', 'fizz-paladin', 'scarlet-paladin', 'stout-paladin', 'kahlee-paladin', 'kevin-paladin', 'auron_yuna-paladin', 'sentry-paladin', 'quawks-paladin', 'kip-paladin', 'chell-nowithdebug-paladin', 'chell-paladin', 'samus-paladin', 'cyan-paladin', 'panther-paladin', 'wizpig-paladin', 'glados-paladin', 'eve-paladin', 'lakitu-paladin', 'winky-paladin', 'tricky-paladin', 'link-paladin', 'arm-generic-paladin', 'monroe-paladin', 'poppy-paladin', 'falco-paladin', 'bob-paladin', 'peppy-paladin', 'butterfly-paladin', 'edgar-paladin', 'lakitu-st-paladin']; configs passed in history [].
11:27:04: INFO: Change CL:843374 is verified with reasons ['strategy:cq-submit-partial-pool-builds-passed'], choose the final reason strategy:cq-submit-partial-pool-builds-passed.
11:27:04: INFO: The following changes will be submitted using board-aware submission logic: CL:843374
11:27:08: INFO: ['* patch_branch 30609042ea31 [cros/chromeos-4.4: ahead 1] CHROMIUM: ipu3-cio2: Fix out-of-bounds access with dmabuf']
11:27:09: INFO: Resetting to refs/remotes/cros/chromeos-4.4
11:27:09: INFO: ['* patch_branch 131325bf24b9 [cros/chromeos-4.4] CHROMIUM: arm64: dts: rockchip: rainier: delete mipi1 node']
11:27:09: INFO: RunCommand: git fetch -f https://chromium-review.googlesource.com/chromiumos/third_party/kernel in /b/c/cbuild/repository/src/third_party/kernel/v4.4
11:27:13: INFO: Attempting to create transaction for rajmohan.mani:843374:f31f5d1b
11:27:13: INFO: Transaction for rajmohan.mani:843374:f31f5d1b is rajmohan.mani:843374:f31f5d1b.
11:27:13: INFO: Attempting to apply change rajmohan.mani:843374:f31f5d1b:"CHROMIUM: ipu3-cio2: Fix out-of-bounds access with dmabuf"
11:27:14: INFO: Applying via cherry-pick.
11:27:14: INFO: RunCommand: git remote update cros in /b/c/cbuild/repository/src/third_party/kernel/v4.4
11:27:18: INFO: RunCommand: git rebase refs/remotes/cros/chromeos-4.4 in /b/c/cbuild/repository/src/third_party/kernel/v4.4
11:27:18: INFO: RunCommand: git push https://chromium-review.googlesource.com/chromiumos/third_party/kernel HEAD:chromeos-4.4 in /b/c/cbuild/repository/src/third_party/kernel/v4.4
11:28:17: WARNING: Change 843374 was pushed without errors, but gerrit is reporting it with status "NEW" (expected "MERGED").
11:28:17: ERROR: Gerrit likely was unable to merge change 843374.
Mergedinto: 760205
Status: Duplicate (was: Untriaged)

Sign in to add a comment