New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 797734 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression: Flashing animation is seen missing in Set Profile Picture overlay when in Arabic

Project Member Reported by kebalaji@chromium.org, Dec 27 2017

Issue description

Chrome Version:65.0.3299.0/10253.0.0 Candy,Gnawty,Peppy
OS:Chrome OS

What steps will reproduce the problem?
(1)Recover build>> Change the language to Arabic
(2)Sign in to user>> In Set profile picture overlay, Click on Video mode and observe

Actual:Flashing animation is missing 
Expected:Flashing animation should be seen  to give an indication for the start and end of video capture as in case of English.

This is a Non-Regression issue seen from M-63( from the introduction of Video mode)

NOTE: 1. Issue is not seen on Linux and Windows
      2. Issue is reproducible in Chrome://settings/changePicture as well.

@Stevenjb: Please confirm the issue
 
ActualCameraArabic.mp4
5.1 MB View Download
Components: -UI>Localization UI>Browser
Labels: Needs-TestConfirmation
Status: Unconfirmed (was: Assigned)
Hi Team,

We appreciate for reporting this issue, however this is not a localization case.
I'll be looping in the Engineering Team to see if they give us some advise.

Happy Holidays Everyone!

Regards!
Cc: steve...@chromium.org
Owner: reve...@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad484fe05107c072654bb02f11154c95f44d7aed

commit ad484fe05107c072654bb02f11154c95f44d7aed
Author: David Reveman <reveman@chromium.org>
Date: Mon Jan 08 23:26:28 2018

Change Picture: Fix layout of camera overlay when using RTL language.

Use "float: left" for overlay when dir=rtl for correct layout. Overlay
is placed off screen without this.

Bug:  797734 
Test: Overlay visible when changing picture in settings and oobe flow
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If0f660cd5f3712b230fa87c9104a06d9fa801548
Reviewed-on: https://chromium-review.googlesource.com/854916
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527807}
[modify] https://crrev.com/ad484fe05107c072654bb02f11154c95f44d7aed/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_camera.html

Status: Fixed (was: Assigned)

Sign in to add a comment