New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 797709 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Syncing progress bar even when offline.

Project Member Reported by mtomasz@chromium.org, Dec 27 2017

Issue description

caroline 65.0.3300.0

Files app shows "Syncing 2 items..." even in offline (Wifi off, ethernet unplugged). The progress bar is stuck on 0%.

It's quite confusing. I think we shouldn't be showing syncing progress bar when offline. 
 
Components: -Internals>Cast>FileManager Platform>Apps>FileManager>Drive
I don't think this is related to Cast.
Labels: -M-65 M-66

Comment 3 by sashab@chromium.org, Feb 16 2018

Components: -Platform>Apps>FileManager>Drive Platform>Apps>FileManager
Labels: CrOS-FilesApp-DriveSync
<files-triage>

Comment 4 by sashab@chromium.org, Feb 28 2018

Labels: CrOSFilesFeature-DriveSync

Comment 5 by sashab@chromium.org, Feb 28 2018

Labels: -CrOS-FilesApp-DriveSync
Labels: M-69
Labels: -M-66
Labels: -M-69
Labels: Files-Fixit-2018
Owner: sa...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22091668adf3c4960fe9cef6b874bfb187924fb8

commit 22091668adf3c4960fe9cef6b874bfb187924fb8
Author: Sam McNally <sammc@chromium.org>
Date: Tue Nov 20 01:34:14 2018

Hide the Drive sync progress when the connection state becomes offline.

Bug:  797709 
Change-Id: I7d0be2bd48d0ff5fd5288f1abd23657f5a77a7fe
Reviewed-on: https://chromium-review.googlesource.com/c/1341769
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Sergei Datsenko <dats@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609548}
[modify] https://crrev.com/22091668adf3c4960fe9cef6b874bfb187924fb8/ui/file_manager/file_manager/background/js/drive_sync_handler.js
[modify] https://crrev.com/22091668adf3c4960fe9cef6b874bfb187924fb8/ui/file_manager/file_manager/background/js/drive_sync_handler_unittest.js

Status: Fixed (was: Assigned)

Sign in to add a comment