New issue
Advanced search Search tips

Issue 797623 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Histograms matching DBus.* are unmapped

Project Member Reported by satorux@chromium.org, Dec 26 2017

Issue description

DBus.* histograms were added in the C++ code long time ago, but matching definitions have been missing in histograms.xml.

I thought about whether deleting the metrics or adding definitions in histograms.xml. For now, I prefer to go with the latter, since the metrics look still interesting, even though we didn't take a look so far. :P
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5de29538291b9793331dcaebc6473096f3300afd

commit 5de29538291b9793331dcaebc6473096f3300afd
Author: Satoru Takabayashi <satorux@chromium.org>
Date: Fri May 11 05:26:54 2018

dbus: Add missing UMA definitions about D-Bus to histograms.xml

The metrics were added long time ago crrev.com/99811 without
the corresponding changes to histograms.xml. The metrics still
look interesting hence this change is to update histograms.xml.

BUG= 797623 

Change-Id: I2445387d21a5ff51519638e0c4efce74108fe747
Reviewed-on: https://chromium-review.googlesource.com/844008
Commit-Queue: Satoru Takabayashi <satorux@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557800}
[modify] https://crrev.com/5de29538291b9793331dcaebc6473096f3300afd/tools/metrics/histograms/histograms.xml

Status: Started (was: Assigned)
Status: Fixed (was: Started)

Sign in to add a comment