New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 797621 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner: ----
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Missing automatically added "Reviewed-on/Reviewed-by" lines in commit message

Project Member Reported by drinkcat@chromium.org, Dec 26 2017

Issue description

Commits from a few days (Dec 20) ago have a full commit message, adding reviewers and link to gerrit, e.g. https://chromium.googlesource.com/chromiumos/platform/ec/+/9a284576a822c10683ed03daa86266a94a462de9 :

Change-Id: I42366f4738b35c352b9be0c44a17ebeb323adfd1
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/678756
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>

But more recent ones (Dev 22) seem to be missing it (https://chromium.googlesource.com/chromiumos/platform/ec/+/809244140d31a24041344eefe8c82bb47240e9f0):

Change-Id: Ib2af8ad066eb05cd9510669600feb26641433eed
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>

(no Reviewed-on/Reviewed-by lines)

This is affecting other repos as well, e.g. https://chromium.googlesource.com/chromiumos/third_party/autotest/+log/8ad7e60b449f27ca55c34e5e3a8c84437436b624 :

https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6de34497dd18fdd138eb03782a8855a54379c735 has full message, https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b2b28b3f232b01901fc173adab418503b90caa09 doesn't.
 
Mergedinto: 760205
Status: Duplicate (was: Untriaged)

Sign in to add a comment