Don't ask about saving password if one doesn't submit the form
Reported by
jidanni@gmail.com,
Dec 25 2017
|
||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.84 Safari/537.36 Steps to reproduce the problem: 1. On https://twitter.com/settings/password partially (auto)fill in the form as in the JPG. 2. Now just click e.g., Mobile etc, from the left panel, not "Save changes". What is the expected behavior? Don't ask about updating password. What went wrong? Browser asks if I want to update password. Did this work before? N/A Chrome version: 63.0.3239.84 Channel: n/a OS Version: Flash Version: Well you might say it is being overcautious, as there are all kinds of password forms...
,
Dec 28 2017
Able to reproduce the issue on Windows 10, mac 10.12.6 and Ubuntu 14.04 using chrome reported version #63.0.3239.84 and latest canary #65.0.3305.0. Bisect Information: ===================== Good build: 59.0.3050.0 Revision(459323) Bad Build : 59.0.3053.0 Revision(459685) Change Log URL: https://chromium.googlesource.com/chromium/src/+log/bf4de3ff1c10a7ca6b1c4ca00451165f18fa1eef..dab7db2dbb20d3c8460c54fb49e92878b800cc88 From the above change log suspecting below change Review-Url: https://codereview.chromium.org/2772793002 dvadym@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thanks...!!
,
Jan 12 2018
jidanni@ thanks for reporting this issue! Yes, https://codereview.chromium.org/2772793002 is the direct reason of this behaviour, but this CL is correct. Some context: in order to understand what's going on a page Chrome uses different heuristics, for example for detecting that a form was submitted. These heuristics fail here. Our team is working on improving them, so blocking corresponding meta bug 777268 on this bug.
,
Jan 12 2018
,
Jan 14
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 17
(6 days ago)
This is wrong submission detection. This is a very big project. We are going to start it in Q2. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by krajshree@chromium.org
, Dec 26 2017