New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 797570 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
M64
M65


Participants' hotlists:
Fixing-touch


Sign in to add a comment

Auto correction on virtual keyboard is broken.

Project Member Reported by wuyingbing@chromium.org, Dec 25 2017

Issue description

Chrome Version: (copy from chrome://version)
OS: (ChromeOS 	65.0.3299.0 or 10176.24.0)
What steps will reproduce the problem?
(1) Turn on virtual keyboard on chrome://flags
(2) Type words then tap space key.


What is the expected result?
Commit the center candidate plus space.

What happens instead?
Commit the first candidate.

This bug is very annoyed, it totally affects user experience.
for example:
just<space>  → Justin
in<space> → I'm
case<space> → Case
you<space> → your
dont<space> → dont
know<space> → knows


 
Components: UI>Input>VirtualKeyboard

Comment 2 Deleted

Comment 3 Deleted

Cc: satorux@chromium.org
Labels: Merge-Request-64
Labels: -Merge-Request-64
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 28 2017

Labels: Merge-Request-64
Project Member

Comment 9 by sheriffbot@chromium.org, Dec 28 2017

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Please add appropriate OS. 
Labels: -Merge-Review-64 Merge-Rejected-64
See comments for crbug/761714

"I'm not convinced that either of these bugs are merge candidates per not being regressions and it's a non-typical workflow."
Cc: chengong@chromium.org shuchen@chromium.org
Owner: omrilio@chromium.org
Hi Kevin,
Do you think this bug is not serve enough to merge back R64?
For the workflow. Before 6.8.0.6 merge back R64, I can't create merge cl 6.8.0.7.
If I miss any process, please let me know.

For the bug priority, I can ask PM to persuade you.

Hi Omri, could you help to evaluate whether we need merge the cl back R64?
If the changes are not too risky, please do merge back to M64.
Also, it is a regression. Auto-correct used to work.
Is this the same as auto-correct on the virtual keyboard automatically replacing words with emoji on Version 64.0.3282.41 Beta?

So, if you type "check" and then hit space on the virtual keyboard, it auto-corrects to ✅ ? That emoji also happens to be the first candidate on the left.
Yes, the same bug. Very few code change. I hope you can persuade Kevin.
Re #14, it's not about emoji input, but a fundamental issue with typing English (ex. just<space>  → Justin). Please see the original description.

+1 on merging to M64. Without the fix, the virtual keyboard is nearly unusable.
oops. wuyingbing@ is right that that behavior ("check" to ✅) is triggered with the same bug. 
Labels: -Merge-Rejected-64 Merge-Request-64
Re-add "Merge-Request-64" to friendly ping~
Project Member

Comment 19 by sheriffbot@chromium.org, Jan 12 2018

Labels: -Merge-Request-64 Merge-Review-64
This bug requires manual review: We are only 10 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Please add affected OSs.
Labels: OS-Chrome
Owner: kbleicher@chromium.org
ping~
Can we please get the merge in?
Cc: bhthompson@chromium.org
Owner: keta...@chromium.org
It seems  kbleicher is out, Ketaki/Bernie, can you help here? 

Comment 25 by ketakid@google.com, Jan 17 2018

Bernie should be able to help here. Thanks! Ketaki
Labels: -Hotlist-Merge-Review -Merge-Review-64 Merge-Approved-64
If this has been on ToT since December with no problems, and it breaks the virtual keyboard, it seems sane to merge.
Unfortunately, previous CL doesn't fix the bug totally. 
See the new  crbug.com/802127 

The root cause is, the FST decoder assume UI only has 3 candidates.
And put top rank candidate as the second one. (It's so wired.)
And when porting the FST decoder to NACL platform.
The they do a another hack, swap the auto correction to top 1.

So when the suggestion is high confidence, the rank is correct. Otherwise second candidate is top rank candidate.
I am fixing it now. And need make a extra release.

Since Input Tool extension code is in google3, then we build binary and make CL to check in ChromeOS repository.

Can I just create a binary release for the M64 branch. I can cherrypick the CLs into google3 M64 release, and make binary release.

Make more clear. "google3 M64 release" means release branch in Google3 repository.
Given 64 is nearly stable, I think we want to test the binary in 65 first if that is feasible. If we are ok on 65 after a few days we can merge back to 64. 

I am not familiar enough with how the extension gets integrated into Chrome OS to have a solid opinion on the best method. How often does the extension get integrated into Chrome OS?

If the extension is branched in G3, would it be sane to use the 64 branch version on ToT CrOS (65) or are there other incompatibilities?
Can we create CL for M65 release branch first?
Since our head code has new feature floating keyboard for M66.
JFYI: It's OK for the IME to have floating keyboard code in M65 as long as it's behind the flag.
Project Member

Comment 32 by bugdroid1@chromium.org, Jan 19 2018

Project Member

Comment 33 by bugdroid1@chromium.org, Jan 22 2018

Labels: merge-merged-release-R64-10176.B
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/2a65cbc8ac317fcf88df01e5a1810d35ecc1dc55

commit 2a65cbc8ac317fcf88df01e5a1810d35ecc1dc55
Author: Yingbing Wu <wuyingbing@google.com>
Date: Mon Jan 22 09:08:48 2018

Project Member

Comment 34 by sheriffbot@chromium.org, Feb 12 2018

Cc: bhthompson@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 35 by sheriffbot@chromium.org, Feb 16 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 36 by sheriffbot@chromium.org, Apr 2 2018

Labels: -Merge-Approved-64
This issue hasn't been updated in the last 6 weeks, so removing its merge approval label. Please re-request a merge if needed.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Started)

Sign in to add a comment