Auto correction on virtual keyboard is broken. |
||||||||||||||||||
Issue descriptionChrome Version: (copy from chrome://version) OS: (ChromeOS 65.0.3299.0 or 10176.24.0) What steps will reproduce the problem? (1) Turn on virtual keyboard on chrome://flags (2) Type words then tap space key. What is the expected result? Commit the center candidate plus space. What happens instead? Commit the first candidate. This bug is very annoyed, it totally affects user experience. for example: just<space> → Justin in<space> → I'm case<space> → Case you<space> → your dont<space> → dont know<space> → knows
,
Dec 26 2017
,
Dec 28 2017
,
Dec 28 2017
,
Dec 28 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/c887f28399c816fd889519cdf7569a138c2dae02 commit c887f28399c816fd889519cdf7569a138c2dae02 Author: Yingbing Wu <wuyingbing@google.com> Date: Thu Dec 28 08:28:29 2017
,
Dec 28 2017
,
Dec 28 2017
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 28 2017
Please add appropriate OS.
,
Dec 28 2017
See comments for crbug/761714 "I'm not convinced that either of these bugs are merge candidates per not being regressions and it's a non-typical workflow."
,
Dec 29 2017
Hi Kevin, Do you think this bug is not serve enough to merge back R64? For the workflow. Before 6.8.0.6 merge back R64, I can't create merge cl 6.8.0.7. If I miss any process, please let me know. For the bug priority, I can ask PM to persuade you. Hi Omri, could you help to evaluate whether we need merge the cl back R64?
,
Jan 4 2018
If the changes are not too risky, please do merge back to M64. Also, it is a regression. Auto-correct used to work.
,
Jan 5 2018
Is this the same as auto-correct on the virtual keyboard automatically replacing words with emoji on Version 64.0.3282.41 Beta? So, if you type "check" and then hit space on the virtual keyboard, it auto-corrects to ✅ ? That emoji also happens to be the first candidate on the left.
,
Jan 5 2018
Yes, the same bug. Very few code change. I hope you can persuade Kevin.
,
Jan 5 2018
Re #14, it's not about emoji input, but a fundamental issue with typing English (ex. just<space> → Justin). Please see the original description. +1 on merging to M64. Without the fix, the virtual keyboard is nearly unusable.
,
Jan 5 2018
oops. wuyingbing@ is right that that behavior ("check" to ✅) is triggered with the same bug.
,
Jan 12 2018
Re-add "Merge-Request-64" to friendly ping~
,
Jan 12 2018
This bug requires manual review: We are only 10 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 12 2018
Please add affected OSs.
,
Jan 12 2018
,
Jan 16 2018
ping~
,
Jan 17 2018
Can we please get the merge in?
,
Jan 17 2018
It seems kbleicher is out, Ketaki/Bernie, can you help here?
,
Jan 17 2018
Bernie should be able to help here. Thanks! Ketaki
,
Jan 17 2018
If this has been on ToT since December with no problems, and it breaks the virtual keyboard, it seems sane to merge.
,
Jan 17 2018
Unfortunately, previous CL doesn't fix the bug totally. See the new crbug.com/802127 The root cause is, the FST decoder assume UI only has 3 candidates. And put top rank candidate as the second one. (It's so wired.) And when porting the FST decoder to NACL platform. The they do a another hack, swap the auto correction to top 1. So when the suggestion is high confidence, the rank is correct. Otherwise second candidate is top rank candidate. I am fixing it now. And need make a extra release. Since Input Tool extension code is in google3, then we build binary and make CL to check in ChromeOS repository. Can I just create a binary release for the M64 branch. I can cherrypick the CLs into google3 M64 release, and make binary release.
,
Jan 17 2018
Make more clear. "google3 M64 release" means release branch in Google3 repository.
,
Jan 17 2018
Given 64 is nearly stable, I think we want to test the binary in 65 first if that is feasible. If we are ok on 65 after a few days we can merge back to 64. I am not familiar enough with how the extension gets integrated into Chrome OS to have a solid opinion on the best method. How often does the extension get integrated into Chrome OS? If the extension is branched in G3, would it be sane to use the 64 branch version on ToT CrOS (65) or are there other incompatibilities?
,
Jan 17 2018
Can we create CL for M65 release branch first? Since our head code has new feature floating keyboard for M66.
,
Jan 17 2018
JFYI: It's OK for the IME to have floating keyboard code in M65 as long as it's behind the flag.
,
Jan 19 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/4830c2345e110b95782ad7c1e1e7dc73f06446ba commit 4830c2345e110b95782ad7c1e1e7dc73f06446ba Author: Yingbing Wu <wuyingbing@google.com> Date: Fri Jan 19 04:18:11 2018
,
Jan 22 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/2a65cbc8ac317fcf88df01e5a1810d35ecc1dc55 commit 2a65cbc8ac317fcf88df01e5a1810d35ecc1dc55 Author: Yingbing Wu <wuyingbing@google.com> Date: Mon Jan 22 09:08:48 2018
,
Feb 12 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 16 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 2 2018
This issue hasn't been updated in the last 6 weeks, so removing its merge approval label. Please re-request a merge if needed. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 25 2018
|
||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||
Comment 1 by wuyingbing@chromium.org
, Dec 25 2017