New issue
Advanced search Search tips

Issue 797567 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Support new White Label factory process

Project Member Reported by hungte@chromium.org, Dec 25 2017

Issue description

Follow the new proposal to make white label factory process complete, and support both unified build and non-unified build.
 
Status: WontFix (was: Started)
Closing in favor of partner-specific buganizer issue. b/71554298
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/firmware/+/736168bd6fc2c6967b8db558246d792c9bad3464

commit 736168bd6fc2c6967b8db558246d792c9bad3464
Author: Hung-Te Lin <hungte@chromium.org>
Date: Thu Jan 18 22:44:46 2018

updater4: Fix keyset selection for white label devices.

To support white label projects better in future, we are migrating
'customization_id' to 'signature_id', and Unified Build should still
have some fallback value for default signature.

BUG= chromium:797567 
TEST=emerge-coral chromeos-firmware-coral;
     ./pack_firmware_functest.py # pass

Change-Id: I1be64f4df413b39d1049f48fe454c98a6a16158a
Reviewed-on: https://chromium-review.googlesource.com/844003
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Nick Sanders <nsanders@chromium.org>

[modify] https://crrev.com/736168bd6fc2c6967b8db558246d792c9bad3464/pack_dist/updater4.sh
[modify] https://crrev.com/736168bd6fc2c6967b8db558246d792c9bad3464/functest/bin/vpd
[add] https://crrev.com/736168bd6fc2c6967b8db558246d792c9bad3464/functest/vblock_A.wlref-wltag2.gz
[add] https://crrev.com/736168bd6fc2c6967b8db558246d792c9bad3464/functest/vblock_A.wlref-wltag1.gz
[add] https://crrev.com/736168bd6fc2c6967b8db558246d792c9bad3464/functest/rootkey.wlref-wltag1
[add] https://crrev.com/736168bd6fc2c6967b8db558246d792c9bad3464/functest/rootkey.wlref-wltag2
[modify] https://crrev.com/736168bd6fc2c6967b8db558246d792c9bad3464/pack_firmware_functest.py
[modify] https://crrev.com/736168bd6fc2c6967b8db558246d792c9bad3464/test/config_base.dtsi
[add] https://crrev.com/736168bd6fc2c6967b8db558246d792c9bad3464/functest/vblock_B.wlref-wltag1.gz
[add] https://crrev.com/736168bd6fc2c6967b8db558246d792c9bad3464/functest/vblock_B.wlref-wltag2.gz

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/firmware/+/d1136c689a514e7b7a920e0be40ff64222ce1041

commit d1136c689a514e7b7a920e0be40ff64222ce1041
Author: Hung-Te Lin <hungte@chromium.org>
Date: Mon Jan 29 13:24:43 2018

test: Change white label name to contain only tag part.

The recommended scheme is to declare white label in

 $model_name {
   whitelabels {
     $tag_name {
       key-id="$MODEL-$TAG"
     }
   }
 }

So we do want to strip $model_name in where $tag_name is declared, since
it's actually "white label tag" instead of "signature".

CQ-DEPEND=CL:859405
BUG= chromium:797567 
TEST=./pack_firmware_functest.py

Change-Id: Ib180620f034554fe1c40a9d7c1c4a21da6ee347b
Reviewed-on: https://chromium-review.googlesource.com/858879
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Nick Sanders <nsanders@chromium.org>
Reviewed-by: C Shapiro <shapiroc@google.com>

[modify] https://crrev.com/d1136c689a514e7b7a920e0be40ff64222ce1041/test/config_base.dtsi

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/4de5e5212f4da7f439654b2623ea04ea5415f3ba

commit 4de5e5212f4da7f439654b2623ea04ea5415f3ba
Author: Hung-Te Lin <hungte@chromium.org>
Date: Mon Jan 29 13:24:43 2018

chromeos-config: Change white label model and signature format.

Change the config declaration scheme so all white labels will have model
name prefixed in the generated signature ID.

BUG= chromium:797567 
TEST=(firmware) pack_firmware_functest.py
CQ-DEPEND=CL:858879

Change-Id: Ia2f3d6b3e10c9dbf7296b7c215f04824a7fd863a
Reviewed-on: https://chromium-review.googlesource.com/859405
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Nick Sanders <nsanders@chromium.org>

[modify] https://crrev.com/4de5e5212f4da7f439654b2623ea04ea5415f3ba/chromeos-config/cros_config_host/libcros_config_host.py

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 6 2018

Labels: merge-merged-factory-coral-10122.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/firmware/+/ecbc17d49fb022e0f70b1223aeee0481d1daced0

commit ecbc17d49fb022e0f70b1223aeee0481d1daced0
Author: Hung-Te Lin <hungte@chromium.org>
Date: Tue Feb 06 06:21:09 2018

updater4: Fix keyset selection for white label devices.

To support white label projects better in future, we are migrating
'customization_id' to 'signature_id', and Unified Build should still
have some fallback value for default signature.

BUG= chromium:797567 
TEST=emerge-coral chromeos-firmware-coral;
     ./pack_firmware_functest.py # pass

Change-Id: I1be64f4df413b39d1049f48fe454c98a6a16158a
Reviewed-on: https://chromium-review.googlesource.com/844003
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Nick Sanders <nsanders@chromium.org>
(cherry picked from commit 736168bd6fc2c6967b8db558246d792c9bad3464)
Reviewed-on: https://chromium-review.googlesource.com/903407
Commit-Queue: Patrick Berny <pberny@chromium.org>
Tested-by: Patrick Berny <pberny@chromium.org>
Trybot-Ready: Patrick Berny <pberny@chromium.org>

[modify] https://crrev.com/ecbc17d49fb022e0f70b1223aeee0481d1daced0/pack_dist/updater4.sh
[modify] https://crrev.com/ecbc17d49fb022e0f70b1223aeee0481d1daced0/functest/vpd
[add] https://crrev.com/ecbc17d49fb022e0f70b1223aeee0481d1daced0/functest/vblock_A.wlref-wltag2.gz
[add] https://crrev.com/ecbc17d49fb022e0f70b1223aeee0481d1daced0/functest/vblock_A.wlref-wltag1.gz
[add] https://crrev.com/ecbc17d49fb022e0f70b1223aeee0481d1daced0/functest/rootkey.wlref-wltag1
[add] https://crrev.com/ecbc17d49fb022e0f70b1223aeee0481d1daced0/functest/vblock_B.wlref-wltag2.gz
[modify] https://crrev.com/ecbc17d49fb022e0f70b1223aeee0481d1daced0/pack_firmware_functest.py
[modify] https://crrev.com/ecbc17d49fb022e0f70b1223aeee0481d1daced0/test/config_base.dtsi
[add] https://crrev.com/ecbc17d49fb022e0f70b1223aeee0481d1daced0/functest/vblock_B.wlref-wltag1.gz
[add] https://crrev.com/ecbc17d49fb022e0f70b1223aeee0481d1daced0/functest/rootkey.wlref-wltag2

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/3c4d1e3a02286aae0eec075bfc7a5d96d95c85db

commit 3c4d1e3a02286aae0eec075bfc7a5d96d95c85db
Author: Hung-Te Lin <hungte@chromium.org>
Date: Tue Feb 06 06:21:18 2018

chromeos-config: Change white label model and signature format.

Change the config declaration scheme so all white labels will have model
name prefixed in the generated signature ID.

BUG= chromium:797567 
TEST=(firmware) pack_firmware_functest.py
CQ-DEPEND=CL:858879

Change-Id: Ia2f3d6b3e10c9dbf7296b7c215f04824a7fd863a
Reviewed-on: https://chromium-review.googlesource.com/859405
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Nick Sanders <nsanders@chromium.org>
(cherry picked from commit 4de5e5212f4da7f439654b2623ea04ea5415f3ba)
Reviewed-on: https://chromium-review.googlesource.com/903370
Commit-Queue: Patrick Berny <pberny@chromium.org>
Tested-by: Patrick Berny <pberny@chromium.org>
Trybot-Ready: Patrick Berny <pberny@chromium.org>

[modify] https://crrev.com/3c4d1e3a02286aae0eec075bfc7a5d96d95c85db/chromeos-config/cros_config_host/libcros_config_host.py

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/firmware/+/3a322ea11eab618091e1fa78c69961b9b302cd3d

commit 3a322ea11eab618091e1fa78c69961b9b302cd3d
Author: Hung-Te Lin <hungte@chromium.org>
Date: Tue Feb 06 06:21:18 2018

test: Change white label name to contain only tag part.

The recommended scheme is to declare white label in

 $model_name {
   whitelabels {
     $tag_name {
       key-id="$MODEL-$TAG"
     }
   }
 }

So we do want to strip $model_name in where $tag_name is declared, since
it's actually "white label tag" instead of "signature".

CQ-DEPEND=CL:859405
BUG= chromium:797567 
TEST=./pack_firmware_functest.py

Change-Id: Ib180620f034554fe1c40a9d7c1c4a21da6ee347b
Reviewed-on: https://chromium-review.googlesource.com/858879
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Nick Sanders <nsanders@chromium.org>
Reviewed-by: C Shapiro <shapiroc@google.com>
(cherry picked from commit d1136c689a514e7b7a920e0be40ff64222ce1041)
Reviewed-on: https://chromium-review.googlesource.com/903408
Commit-Queue: Patrick Berny <pberny@chromium.org>
Tested-by: Patrick Berny <pberny@chromium.org>
Trybot-Ready: Patrick Berny <pberny@chromium.org>

[modify] https://crrev.com/3a322ea11eab618091e1fa78c69961b9b302cd3d/test/config_base.dtsi

Project Member

Comment 8 by bugdroid1@chromium.org, Feb 8 2018

Labels: merge-merged-release-R65-10323.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/edee02d9902731dbeac61c1c4fb8c677727fba78

commit edee02d9902731dbeac61c1c4fb8c677727fba78
Author: Hung-Te Lin <hungte@chromium.org>
Date: Thu Feb 08 00:14:06 2018

chromeos-config: Change white label model and signature format.

Change the config declaration scheme so all white labels will have model
name prefixed in the generated signature ID.

BUG= chromium:797567 
TEST=(firmware) pack_firmware_functest.py
CQ-DEPEND=CL:858879

Change-Id: Ia2f3d6b3e10c9dbf7296b7c215f04824a7fd863a
Reviewed-on: https://chromium-review.googlesource.com/859405
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Nick Sanders <nsanders@chromium.org>
(cherry picked from commit 4de5e5212f4da7f439654b2623ea04ea5415f3ba)
Reviewed-on: https://chromium-review.googlesource.com/905903
Reviewed-by: YH Lin <yueherngl@chromium.org>
Reviewed-by: Patrick Berny <pberny@chromium.org>
Commit-Queue: Patrick Berny <pberny@chromium.org>
Tested-by: Patrick Berny <pberny@chromium.org>
Trybot-Ready: Patrick Berny <pberny@chromium.org>

[modify] https://crrev.com/edee02d9902731dbeac61c1c4fb8c677727fba78/chromeos-config/cros_config_host/libcros_config_host.py

Project Member

Comment 9 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/firmware/+/87975f3d8407c75fcf9b9defa08ae75290b147b9

commit 87975f3d8407c75fcf9b9defa08ae75290b147b9
Author: Hung-Te Lin <hungte@chromium.org>
Date: Fri Feb 16 05:31:13 2018

test: Change white label name to contain only tag part.

The recommended scheme is to declare white label in

 $model_name {
   whitelabels {
     $tag_name {
       key-id="$MODEL-$TAG"
     }
   }
 }

So we do want to strip $model_name in where $tag_name is declared, since
it's actually "white label tag" instead of "signature".

CQ-DEPEND=CL:859405
BUG= chromium:797567 
TEST=./pack_firmware_functest.py

Change-Id: Ib180620f034554fe1c40a9d7c1c4a21da6ee347b
Reviewed-on: https://chromium-review.googlesource.com/858879
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Nick Sanders <nsanders@chromium.org>
Reviewed-by: C Shapiro <shapiroc@google.com>
(cherry picked from commit d1136c689a514e7b7a920e0be40ff64222ce1041)
Reviewed-on: https://chromium-review.googlesource.com/907315
Reviewed-by: YH Lin <yueherngl@chromium.org>
Reviewed-by: Patrick Berny <pberny@chromium.org>
Commit-Queue: Patrick Berny <pberny@chromium.org>
Tested-by: Patrick Berny <pberny@chromium.org>
Trybot-Ready: Patrick Berny <pberny@chromium.org>

[modify] https://crrev.com/87975f3d8407c75fcf9b9defa08ae75290b147b9/test/config_base.dtsi

Project Member

Comment 10 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/firmware/+/643a0c7f23bf48b35c5a36388083b9ba8ee4f0e5

commit 643a0c7f23bf48b35c5a36388083b9ba8ee4f0e5
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed May 16 12:08:29 2018

pack_firmware_functest: fix lint errors from CL:844003

BUG= chromium:797567 
TEST=precq passes

Change-Id: Ibbf78d3c99e839880c7a527cf38d748585bfd499
Reviewed-on: https://chromium-review.googlesource.com/1058697
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/643a0c7f23bf48b35c5a36388083b9ba8ee4f0e5/pack_firmware_functest.py

Sign in to add a comment