New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 797522 link

Starred by 5 users

Issue metadata

Status: Duplicate
Merged: issue 776348
Owner: ----
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Build broken again with enable_webrtc=false

Reported by gd...@iragan.org, Dec 24 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.108 Safari/537.36

Steps to reproduce the problem:
1. generate build with GN_ARGS="enable_webrtc=false"
2. build fails with error:

FAILED: android_clang_arm/obj/chrome/browser/browser/native_desktop_media_list.o
[...]
In file included from ../../chrome/browser/media/webrtc/native_desktop_media_list.cc:16:
../../third_party/webrtc/modules/desktop_capture/desktop_capturer.h:22:10: fatal error: 'modules/desktop_capture/desktop_frame.h' file not found
#include "modules/desktop_capture/desktop_frame.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

What is the expected behavior?
Build should complete successfully.

What went wrong?
The code does not take in account the WebRTC dependency; the IFDEFs are not covering all the places where webrtc code is being used.

Did this work before? Yes 

Chrome version: 63.0.3239.118  Channel: dev
OS Version: Ubuntu 14.04
Flash Version: 

The provided patch allows building Chromium successfully (tested at tag 63.0.3239.118); I am not sure however that this is the best way to fix the build dependency bug.

See https://bugs.chromium.org/p/chromium/issues/detail?id=730019 for last time this bug was reported
 
chromium-allow-build-without-webrtc.patch
14.9 KB Download
Labels: Needs-Triage-M63

Comment 2 by gd...@iragan.org, Dec 25 2017

Forgot to mention that this broken build scenario happens when compiling for android, e.g. target_os="android". Other target OSes have not been tested with disabled webRTC.
i have simmilar issues at Linux



Comment 4 by hanaba...@gmail.com, Dec 26 2017

Linux x64 Debian 9
I also have problems with this
i've found this at 63, 64 and 65
Components: Blink>WebRTC
Labels: Triaged-ET TE-NeedsTriageHelp
The issue seems to be out of TE-scope as it is related to build. Hence, adding label TE-NeedsTriageHelp for further investigation from dev team.

Thanks...!!
Cc: viswatej...@techmahindra.com sc00335...@techmahindra.com
 Issue 797594  has been merged into this issue.
Mergedinto: 776348
Status: Duplicate (was: Unconfirmed)
Same issue with building version 65.0.3314.2 for Windows x64

Sign in to add a comment