New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 797474 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: frame.packets.Empty() || frame.packets.Max() == frame.largest_acked in quic_ack_

Project Member Reported by ClusterFuzz, Dec 23 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5851237856837632

Fuzzer: libFuzzer_net_quic_stream_factory_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  frame.packets.Empty() || frame.packets.Max() == frame.largest_acked in quic_ack_
  net::LargestAcked
  net::QuicConnection::ValidateAckFrame
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=526095:526119

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5851237856837632

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Dec 23 2017

Components: Internals>Network>QUIC
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Dec 23 2017

Labels: Test-Predator-Auto-Owner
Owner: mpw@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/ed8ebd50a0e3c1e7abe73d06b7c34dddeb6d526c (Landing Recent QUIC changes until Thu Dec 21 15:21:19 2017 +0000).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.

Comment 3 by mpw@chromium.org, Dec 28 2017

Hrm. Tried to repro using the command-line given in https://clusterfuzz.com/v2/testcase-detail/5851237856837632?noredirect=1 , but the CHECK failure didn't recur.  Will look at code to reason how this condition can occur.

Comment 4 by mpw@chromium.org, Dec 28 2017

Regression is most likely related to this merge: https://chromium-review.googlesource.com/c/chromium/src/+/842704

That change converted a QUIC_PEER_BUG (i.e. a LOG(DFATAL)) in LargestAcked() into a DCHECK.  However, the QUIC_PEER_BUG should still have failed.
Project Member

Comment 5 by ClusterFuzz, Jan 11 2018

ClusterFuzz has detected this issue as fixed in range 528550:528560.

Detailed report: https://clusterfuzz.com/testcase?key=5851237856837632

Fuzzer: libFuzzer_net_quic_stream_factory_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  frame.packets.Empty() || frame.packets.Max() == frame.largest_acked in quic_ack_
  net::LargestAcked
  net::QuicConnection::ValidateAckFrame
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=526095:526119
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=528550:528560

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5851237856837632

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Jan 11 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5851237856837632 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment