[Sync] AssociateWindows is very chatty |
|||
Issue descriptionSessionsSyncManager's initialization sets up bogus native ids before they're fixed later when we have native data. It seems a bit wrong that, on every AssociateWindows() (one happens during initialiation, then on every OnLocalTabModified()), if we don't have native data yet, we end up committing all of our sessions state with the bogus ids from merge. I suppose everything except the first will get de-duped because the directory is checking for equality, but it feels bad. Especailly in unit tests. It'd be nice if we never committed this bad data, but instead could have an interaction with SyncedSessionTracker that doesn't rely on ResetSessionTracking().
,
Jan 17 2018
,
Mar 15 2018
,
May 8 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by s...@chromium.org
, Jan 3 2018Status: Available (was: Untriaged)