New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 797452 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner: ----
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

[Sync] AssociateWindows is very chatty

Project Member Reported by s...@chromium.org, Dec 22 2017

Issue description

SessionsSyncManager's initialization sets up bogus native ids before they're fixed later when we have native data. It seems a bit wrong that, on every AssociateWindows() (one happens during initialiation, then on every OnLocalTabModified()), if we don't have native data yet, we end up committing all of our sessions state with the bogus ids from merge.

I suppose everything except the first will get de-duped because the directory is checking for equality, but it feels bad. Especailly in unit tests. It'd be nice if we never committed this bad data, but instead could have an interaction with SyncedSessionTracker that doesn't rely on ResetSessionTracking().
 

Comment 1 by s...@chromium.org, Jan 3 2018

Cc: mastiz@chromium.org
Status: Available (was: Untriaged)
It probably doesn't really make sense to actually go in and make changes to the currently implementation for this. Likely will be easier to just keep this in mind as we think about the USS sessions implementation. +mastiz

Comment 2 Deleted

Comment 3 by pav...@chromium.org, Jan 17 2018

Labels: SyncHandoff2018

Comment 4 by mastiz@chromium.org, Mar 15 2018

Status: Assigned (was: Available)
Mergedinto: 823798
Status: Duplicate (was: Assigned)
Merging into crbug.com/823798

Sign in to add a comment