New issue
Advanced search Search tips

Issue 797448 link

Starred by 1 user
Status: Fixed
Owner:
thomasanderson@chromium.org
Closed: Jan 2018
Cc:
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Chrome calls illegal c++ functions

Reported by juanka85...@gmail.com, Dec 22 2017 
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.108 Safari/537.36

Steps to reproduce the problem:
1. Download source tarball
2. Build it with google clang
3. See errors

What is the expected behavior?
A successful build

What went wrong?
Illegal functions make crash ninja

Crashed report ID: 

How much crashed? Whole browser

Is it a problem with a plugin? No 

Did this work before? N/A 

Chrome version: 65.0.3298.3  Channel: dev
OS Version: 65.0.3298.3
Flash Version: 

I'm attaching a bugfix (i've used it without troubles)
narnia4.patch
304 bytes Download
narnia3.patch
409 bytes Download

Comment 1 by rbasuvula@chromium.org, Dec 26 2017

Cc: rbasuvula@chromium.org
Components: Build
Labels: Needs-Feedback Needs-Triage-M65
@juanka: Thanks for filing the issue! Could you please provide the crash id from chrome://crashes which would help us to triage the issue further.

Thank You!

Comment 2 by juanka85...@gmail.com, Dec 30 2017 

i cant make it (its a build issue)
Project Member

Comment 3 by sheriffbot@chromium.org, Dec 30 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "rbasuvula@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by rbasuvula@chromium.org, Jan 2 2018

Labels: TE-NeedsTriageHelp
Thanks for the update! Issue related to build errors and unable to check form TE end, hence adding the respective label for it to  triage further.

Thank You!

Comment 5 by thomasanderson@chromium.org, Jan 2 2018

Owner: thomasanderson@chromium.org
Status: Started (was: Unconfirmed)
OP thanks for the patches.  I'll see if I can get them merged.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef0323bdaab9e19e246b97cf1586a39f6e8f23c2

commit ef0323bdaab9e19e246b97cf1586a39f6e8f23c2
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Wed Jan 03 02:00:29 2018

Add std:: prefix to nullptr_t

This CL fixes building with libstdc++ instead of libc++.

BUG= 797448 
R=sky

Change-Id: I631cbb68511ac76214e07806ace99539ffe49f17
Reviewed-on: https://chromium-review.googlesource.com/848154
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526583}
[modify] https://crrev.com/ef0323bdaab9e19e246b97cf1586a39f6e8f23c2/ui/views/view.cc
[modify] https://crrev.com/ef0323bdaab9e19e246b97cf1586a39f6e8f23c2/ui/views/view.h

Comment 7 by thomasanderson@chromium.org, Jan 3 2018

Status: Fixed (was: Started)
►

Sign in to add a comment