The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa49e30dfbc659f77c41795f58e17770207fc8bd

commit fa49e30dfbc659f77c41795f58e17770207fc8bd
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Sat Dec 23 00:02:30 2017

Disable PolicyToolUITest.Editing

TBR=dschuyler@chromium.org

Bug: 797446
Change-Id: Ic6037dccf92bbb198916eed9c3f5ad163a7067ab
Reviewed-on: https://chromium-review.googlesource.com/843147
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526097}
[modify] https://crrev.com/fa49e30dfbc659f77c41795f58e17770207fc8bd/chrome/browser/ui/webui/policy_tool_ui_browsertest.cc

Adding urusant@ and mcnee@ b/c blame shows recent edits in that test.

(Correction to #3, not "recent", but "the most recent" -- they are a few months old).

My change was a revert of a failing test while sheriffing. I don't really know this area.

I can add a few others who reviewed the original policy CL. Also urusant@ appears to no longer be at google.

Adding Georges as this seems to be stemming from the work of our intern that he was mentoring.

We'll be resuming this project next month with a new intern.

I'll make sure we fix this test and reenable it then.

Thanks.

[mac triage] taking out of triage - feel free to reassign.

Might be the same as issue 826700.

Flaky tests are P1, please triage ASAP.

Taking a stab with https://chromium-review.googlesource.com/#/c/chromium/src/+/1005918 but I will own this issue beyond that. Thanks!

(if it works you should try to revert r526097 to re-enable the test disabled above)

Nvm, ui_test_utils::NavigateToURL is already blocking so this wasn't it.

Back to you.

Insight from bauerb :

"""
Not directly. (BTW, https://crbug.com/797446 basically has no actionable information, because there is only a link to the flakiness dashboard, where all logs have already expired). Anyway, some thoughts:

The tests don't have very good logging in case of failures. For example, if the policy in ExtractSinglePolicyValue() can't be found, you could print the whole dictionary. Similarly, comparing two base::Values doesn't result in a very good error message when it fails -- really, you could stringify the values and compare those.
NavigateToURL() will wait for the page load to finish, but the Javascript on the page might not be fully ready yet. I don't know much about how the policy tool UI is implemented, but in the JS file there is an event listener that calls an initialization method (https://cs.chromium.org/chromium/src/chrome/browser/resources/policy_tool.js?l=322&rcl=d573c76d2c89bff6763e0648a33383091d0b9174) -- you might want to wait for that to happen.
"""