Implement "denominators" for Security.PageInfo.Action.* histograms |
||
Issue descriptionSecurity.PageInfo.Action.* histograms record interactions with Page Info for different URL schemes and security levels. But we don't have good denominators for all those metrics -- for some of them, we don't have a count of the number of page loads that had that security level, so we can't make statements like "Users opened Page Info on X% of page loads that showed Not Secure for http:// URLs."
,
Jan 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f90de69659a6fd110b5762d6ec16ea31ced87bd commit 5f90de69659a6fd110b5762d6ec16ea31ced87bd Author: Emily Stark <estark@google.com> Date: Wed Jan 17 18:57:28 2018 Record the security level of each page This CL adds a histogram to record the security level of each page when the navigation commits and if it changes subsequently. Along the way it removes the special hook SecurityStateTabHelper::VisibleSecurityStateChanged() in favor of the existing equivalent WebContentsObserver method. This histogram should be analyzed with care because each recorded security level is not necessarily user-visible: for example, a page may commit as SECURE but get quickly downgraded to NONE if it shows mixed content on load. The security levels that can get downgraded quickly after commit are SECURE (for https pages) and NONE (for http pages), so the histogram values should be regarded as upper-bounds on what the user actually sees for those security levels. Bug: 797445 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I21f3d716742efd42b362476a48e13ed50f1b2e3b Reviewed-on: https://chromium-review.googlesource.com/867090 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Eric Lawrence <elawrence@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#529830} [modify] https://crrev.com/5f90de69659a6fd110b5762d6ec16ea31ced87bd/chrome/browser/ssl/security_state_tab_helper.cc [modify] https://crrev.com/5f90de69659a6fd110b5762d6ec16ea31ced87bd/chrome/browser/ssl/security_state_tab_helper.h [modify] https://crrev.com/5f90de69659a6fd110b5762d6ec16ea31ced87bd/chrome/browser/ssl/security_state_tab_helper_browsertest.cc [modify] https://crrev.com/5f90de69659a6fd110b5762d6ec16ea31ced87bd/chrome/browser/ssl/security_state_tab_helper_unittest.cc [modify] https://crrev.com/5f90de69659a6fd110b5762d6ec16ea31ced87bd/chrome/browser/ui/browser.cc [modify] https://crrev.com/5f90de69659a6fd110b5762d6ec16ea31ced87bd/components/security_state/content/content_utils.cc [modify] https://crrev.com/5f90de69659a6fd110b5762d6ec16ea31ced87bd/components/security_state/core/security_state.h [modify] https://crrev.com/5f90de69659a6fd110b5762d6ec16ea31ced87bd/components/security_state/core/security_state_ui.cc [modify] https://crrev.com/5f90de69659a6fd110b5762d6ec16ea31ced87bd/components/toolbar/toolbar_model_impl.cc [modify] https://crrev.com/5f90de69659a6fd110b5762d6ec16ea31ced87bd/ios/chrome/browser/ui/omnibox/omnibox_util.cc [modify] https://crrev.com/5f90de69659a6fd110b5762d6ec16ea31ced87bd/tools/metrics/histograms/enums.xml [modify] https://crrev.com/5f90de69659a6fd110b5762d6ec16ea31ced87bd/tools/metrics/histograms/histograms.xml
,
Jan 18 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by est...@chromium.org
, Jan 2 2018