Issue metadata
Sign in to add a comment
|
roll_dep doesn't separate BUG= line any more |
||||||||||||||||||||||
Issue descriptionSee for example this Catapult auto-roll: https://chromium-review.googlesource.com/842082 It puts the BUG= line at the end of the tool's command line, preventing it from being discovered by Bugdroid, so bugs aren't updated when rolls happen. This is a recent regression.
,
Dec 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/ebe839b6bfc3e9276b8d1e42a0d6e830bb04899e commit ebe839b6bfc3e9276b8d1e42a0d6e830bb04899e Author: Kenneth Russell <kbr@chromium.org> Date: Sat Dec 23 00:02:25 2017 Add a '\n' at the end of the roll tool's command line. Currently the BUG= line is being concatenated at the end, preventing Bugdroid from picking it up and bugs from being updated. BUG= 797444 Change-Id: I7242db76a9552658d94fda10ec564b230f4f0037 Reviewed-on: https://chromium-review.googlesource.com/843014 Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> [modify] https://crrev.com/ebe839b6bfc3e9276b8d1e42a0d6e830bb04899e/roll_dep.py
,
Dec 23 2017
Should be fixed.
,
Dec 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/334a8c361e558187a7c25dd57684281c8521d76e commit 334a8c361e558187a7c25dd57684281c8521d76e Author: depot-tools-roller@chromium.org <depot-tools-roller@chromium.org> Date: Sat Dec 23 03:56:17 2017 Roll src/third_party/depot_tools/ f2cb0f5b3..ebe839b6b (1 commit) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f2cb0f5b3ea5..ebe839b6bfc3 $ git log f2cb0f5b3..ebe839b6b --date=short --no-merges --format='%ad %ae %s' 2017-12-22 kbr Add a '\n' at the end of the roll tool's command line. Created with: roll-dep src/third_party/depot_tools BUG= 797444 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I48fb64f3ef50beef0ee22393a4a658ef12e2ba88 Reviewed-on: https://chromium-review.googlesource.com/843601 Reviewed-by: depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526136} [modify] https://crrev.com/334a8c361e558187a7c25dd57684281c8521d76e/DEPS
,
Dec 24 2017
I think this can safely be called Verified :D |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kbr@chromium.org
, Dec 22 2017