New issue
Advanced search Search tips

Issue 797422 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

DevTools: network stripes flicker while scrolling

Project Member Reported by l...@chromium.org, Dec 22 2017

Issue description

Chrome Version: 58

What steps will reproduce the problem?
(1) Record enough requests in DevTools' Network panel to have a scrollbar
(2) Slowly scroll by dragging the scrollbar thumb

What is the expected result?
Row stripe colors should not change

What happens instead?
Whenever row goes out of view, all the rows invert their stripe color. This leads to a bad flicker, very noticeable when scrolling slowly.

Bisected to this change:
https://chromium.googlesource.com/chromium/src/+/1c4bf390cfc5619a04b3b67fdc9930234e407fea
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/319e7548207643dd095d5b948a6c565862c25c47

commit 319e7548207643dd095d5b948a6c565862c25c47
Author: Erik Luo <luoe@chromium.org>
Date: Fri Dec 29 21:03:12 2017

DevTools: only preserve stripes in Network log when stuck to bottom

Network's row stripes should not flicker in these 2 common cases:
1) User scrolls via wheel/dragging scrollbar
2) Viewport is stuck to the bottom and new rows added above
   (occurs when sorting on column)

In case 1), the first visible row's stripe may change as you scroll,
while in case 2), this can lead to flickering. Today's viewport
covers case 2) but breaks case 1). This CL tightens the condition
so that stripe preservation only applies to one case.

Bug:  797422 
Change-Id: I43f90ca0afec4b3f4f8de9908991e9035bed55c9
Reviewed-on: https://chromium-review.googlesource.com/843474
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526389}
[modify] https://crrev.com/319e7548207643dd095d5b948a6c565862c25c47/third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js

Comment 2 by l...@chromium.org, Dec 31 2017

Status: Fixed (was: Assigned)

Comment 3 by l...@chromium.org, Jan 2 2018

Labels: Merge-Request-64 OS-Linux OS-Mac OS-Windows
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 2 2018

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
What's the impact if we wait until M-65 vs taking this for M64?

Comment 6 by l...@chromium.org, Jan 2 2018

This bug affects UX related to stripes flickering while scrolling, so users who rely on consistent striping may continue to experience confusion.

On the other hand, this bug has been around since M58 and as far as I know, there haven't been other crbugs filed.  It would be nice to have in M64, but it's not critical.
Labels: -Merge-Review-64 Merge-Rejected-64
Ah got it. Since it's been around M58, let's have it run through regular channels and take it in M65. 

Comment 8 by l...@chromium.org, Feb 1 2018

 Issue 807925  has been merged into this issue.

Sign in to add a comment