New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 797416 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

11.4% regression in system_health.common_desktop at 524735:524827

Project Member Reported by briander...@chromium.org, Dec 22 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Dec 22 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=797416

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=67fcb13d7f07aa0270bab53d408af1b7fd045d267639a98d030b6a20338c778a


Bot(s) for this bug's original alert(s):

chromium-rel-win10
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Dec 22 2017

๐Ÿ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/12a426b1040000
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Dec 23 2017

Cc: nedngu...@google.com rnep...@chromium.org charliea@chromium.org
Owner: rnep...@chromium.org
Status: Assigned (was: Untriaged)
๐Ÿ“ Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/12a426b1040000

[Telemetry] Update system_health_smoke_test to use expectations file.
By rnephew@chromium.org ยท Mon Dec 18 20:19:30 2017
chromium @ ae3f936d5d6e9c26c9d0ad76d4a61ce028cd8897

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Dec 23 2017

๐Ÿ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/14f1f329040000
It seems highly unlikely that that change would cause a regression. It just changes how we decide if a test is disable. The expected failure mode of this would be it running tests it shouldn't, not running tests it should, or failing disastrously. Nothing in this CL changes how tests are actually run, how measurements are taken, or any changes to the browser itself.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Dec 23 2017

Cc: mcasas@chromium.org sande...@chromium.org
Owner: mcasas@chromium.org
๐Ÿ“ Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/14f1f329040000

VideoFrame::BitsPerChannel() doesn't need the parameter
By mcasas@chromium.org ยท Mon Dec 18 20:28:23 2017
chromium @ 134e466415cf125f27905d1ca8646bdaf265496a

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Owner: briander...@chromium.org
I'm not 100% sure that the CL in c6 is the guilty one although
it's true that it touches video, so it might affect the parameters
in the chromeperf, but if so it'd be way more widespread than just
on Win10 and for the cnn homesite -- this CL just removes a parameter
in a method call.

brianderson@ could you retrigger the pinpoint job or paste here a link
to the CLs in range? Thx
๐Ÿ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/1291675d040000
๐Ÿ“ Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/1291675d040000
Owner: tdres...@chromium.org
tdresser: This metric seems super noisy, pinpoint is reproducing regressions at different CLs on different runs.
Cc: dproy@chromium.org
There's noise in the number of navigations we're seeing. 
I think we should switch to alerting on the max value, instead of the average.

Deep, does that make sense to you?

Comment 13 by dproy@chromium.org, Jan 25 2018

I hope I'm understanding this correctly: It looks like this story actually navigates multiple times [1] - it goes to the home page and then clicks two more links. Here[2] is a link to the trace. Taking the max here makes me uncomfortable because the intention of the test was probably to monitor average loading metrics, and if we only take the max we will almost certainly only capture the first cold navigation to the home page and not have any visibility into the rest of the browsing. 

I looked around in some other traces in pinpoint, and the number of navigation reaching first paint is consistently five.  


[1] https://cs.chromium.org/chromium/src/tools/perf/page_sets/system_health/browsing_stories.py?l=112&rcl=43487fc89193d2cd284c17d355787727482763bd

[2] https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-output/o/browse_news_cnn_2018-01-02_18-01-55_66952.html

Deep and I chatted about this. Sounds like avg is probably more correct here (though full histogram diffing will make more sense).

If we configure pinpoint correctly, the failure mode should be failing to reproduce regressions, not identifying different CLs on different runs.

Do we need to bump up the threshold for regression detection?

Naively, the graphs themselves appear relatively stable.
Status: WontFix (was: Assigned)
Bisect can't repro.

Sign in to add a comment