Issue metadata
Sign in to add a comment
|
11.4% regression in system_health.common_desktop at 524735:524827 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Dec 22 2017
๐ Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12a426b1040000
,
Dec 23 2017
๐ Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/12a426b1040000 [Telemetry] Update system_health_smoke_test to use expectations file. By rnephew@chromium.org ยท Mon Dec 18 20:19:30 2017 chromium @ ae3f936d5d6e9c26c9d0ad76d4a61ce028cd8897 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Dec 23 2017
๐ Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14f1f329040000
,
Dec 23 2017
It seems highly unlikely that that change would cause a regression. It just changes how we decide if a test is disable. The expected failure mode of this would be it running tests it shouldn't, not running tests it should, or failing disastrously. Nothing in this CL changes how tests are actually run, how measurements are taken, or any changes to the browser itself.
,
Dec 23 2017
๐ Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/14f1f329040000 VideoFrame::BitsPerChannel() doesn't need the parameter By mcasas@chromium.org ยท Mon Dec 18 20:28:23 2017 chromium @ 134e466415cf125f27905d1ca8646bdaf265496a Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Jan 2 2018
I'm not 100% sure that the CL in c6 is the guilty one although it's true that it touches video, so it might affect the parameters in the chromeperf, but if so it'd be way more widespread than just on Win10 and for the cnn homesite -- this CL just removes a parameter in a method call. brianderson@ could you retrigger the pinpoint job or paste here a link to the CLs in range? Thx
,
Jan 2 2018
๐ Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/1291675d040000
,
Jan 2 2018
,
Jan 3 2018
๐ Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/1291675d040000
,
Jan 25 2018
tdresser: This metric seems super noisy, pinpoint is reproducing regressions at different CLs on different runs.
,
Jan 25 2018
There's noise in the number of navigations we're seeing. I think we should switch to alerting on the max value, instead of the average. Deep, does that make sense to you?
,
Jan 25 2018
I hope I'm understanding this correctly: It looks like this story actually navigates multiple times [1] - it goes to the home page and then clicks two more links. Here[2] is a link to the trace. Taking the max here makes me uncomfortable because the intention of the test was probably to monitor average loading metrics, and if we only take the max we will almost certainly only capture the first cold navigation to the home page and not have any visibility into the rest of the browsing. I looked around in some other traces in pinpoint, and the number of navigation reaching first paint is consistently five. [1] https://cs.chromium.org/chromium/src/tools/perf/page_sets/system_health/browsing_stories.py?l=112&rcl=43487fc89193d2cd284c17d355787727482763bd [2] https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-output/o/browse_news_cnn_2018-01-02_18-01-55_66952.html
,
Jan 25 2018
Deep and I chatted about this. Sounds like avg is probably more correct here (though full histogram diffing will make more sense). If we configure pinpoint correctly, the failure mode should be failing to reproduce regressions, not identifying different CLs on different runs. Do we need to bump up the threshold for regression detection? Naively, the graphs themselves appear relatively stable.
,
Mar 19 2018
Bisect can't repro. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Dec 22 2017