New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 797411 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression

Blocking:
issue 851062


Participants' hotlists:
Fixing-touch


Sign in to add a comment

External touch devices stop working when the internal displays lid is closed

Project Member Reported by vkasatkin@google.com, Dec 22 2017

Issue description

ChromeOS version: 61,62 
ChromeOS device model: 
- Asus 302CA 
- Acer CB5-312T 
- HP x360 G11 EE 

Case#: 13996759

## Description:

Customer experiencing issues with interactive projectors connected to their Chromebooks. Touch functionality does not work when the lid is closed. Issue started with version 61 release.

Here is the drive link to the video describing the issue:
https://drive.google.com/open?id=1ZJlqHMrcY5MbEG-siiLvKtPudtHc1NoQ

Customer also mentioned that they have been able to replicate this by disabling the touch panel on the Chromebook. The interactive projector's board no longer works when it is disabled. Enabling the touch solves that issue. 


## Steps to reproduce 
-Turn on a Chromebook 
-Connect the interactive  
-Close the lid and continue working on the whiteboard 
-After lid is closed the touch capability is no longer present 
 

# Additional information: 

Both of the following devices work both with the lid open and the lid closed with the interactive boards on Version 61.0.3163.123 (Official Build) (64-bit).: 

Acer C720P - 2625
Acer C740-C4PE 


## Current Behavior / Reproduction: 

Interactive projector's touch board does not work with closed lid

## Expected Behavior: 

Interactive projector's touch board works with both closed and opened lid 

Drive link to logs: 
https://drive.google.com/open?id=1ON_egXNoS6ECI2ztqvG-z2kxjvE7tj99
 
From the logs, interactive projector model:

Product: LightRaise 60wi
Manufacturer: SMART Technologies

But customer mentioned that other models are affected as well.
Owner: sadrul@chromium.org
Status: Assigned (was: Untriaged)
sadrul@ please triage this. 
Owner: ----
Status: Untriaged (was: Assigned)
I don't know who works on this.
Owner: malaykeshav@chromium.org
Status: Assigned (was: Untriaged)
Malay, is this related to touch associations you were working on? If not please further triage.
This should be fixed moving forward M64.

Comment 6 by cardonam@google.com, May 28 2018

Jamie Jensen has requested an update for this bug and a consult has been submitted with new logs using ver 66.  The issue persists.
#6
This might be related to another  issue 827452  which was fixed for M67. 
Does M67 beta fix this?

Comment 8 by cardonam@google.com, May 31 2018

The customer replied with version 67 logs.  He states he also tried using version 68 in dev channel and both versions are still reproducing the issue.  
Labels: M-66 M-67
here is a drive link to the log file mentioned in #8:
https://drive.google.com/open?id=1lHVD_yLlUvrroItoQSZ0Nm_vUYGyO6Ue 
Was this working pre-M61? Is this a regression?
Do we have access to an interactive projector?
malaykeshav@ - Yes, it was working pre-61 so most probably a regression.
Unfortunately we don't have an interactive projector here to reproduce. 
Indeed the case was opened because the feature was working pre 61.  Are there any updates or any further data you need from the customer's end?
Its hard to say what caused the regression without testing with the device.
There is another kernel bug that is currently being worked on in  Issue 850222 . But looking at the logs, I don't see the error messages that match the diagnosis.



Greetings.  Do you believe it'd be necessary to request a device from the customer for testing purposes?  I'd like to be able to provide a meaningful update to him since he's simply waiting for our updates.
#14 
Yes. A test device would definitely help getting to the root of the problem. Unless this can be reproduced on other device. However I have not seen another bug that has the same issue.
Greetings, the customer states he has tried to reproduce the issue with multiple different devices and multiple interactive whiteboards with the same results.  Touch capabilities are lost on the external device when the Chromebook lid is closed.  He prefers not to send a testing device, however he's willing to try in case it's necessary.
Status: Started (was: Assigned)
Blocking: 851062
Cc: osh...@chromium.org afakhry@chromium.org ovanieva@chromium.org dtor@chromium.org
Labels: -Type-Bug -Pri-2 Pri-1 Type-Bug-Regression
Summary: External touch devices stop working when the internal displays lid is closed (was: Interactive projector touch stops working when closing a lid of Chromebook )
This effects every device. This is a side effect of  Issue 743291 .

Specifically, we disable interactions on _ALL_ touch devices if the 
brightness goes to 0 on the internal display due to a non user 
initiated action (eg. closing the lid).

Ideally we would want to disable the touchscreen that is associated 
only to the internal display, and not all touch devices. However 
that requires a significant amount of change to the codebase. 

As a temporary fix, I am proposing a change to turn off disabling ANY 
and ALL touchscreens if an external touch device is present. This
would also solve the issue where devices like chromeboxes that rely
solely on external touch screens for interaction and also as a mode
of wake up from suspend can continue to do so. ( Issue 851062 )

(Increasing the priority as this effects every device with an 
external touch device connected)
Cc: derat@chromium.org
We would also need to update go/cros-wakeup-matrix if the proposed change is to go through. I am not sure what the protocol for that is.

Comment 22 by derat@chromium.org, Jun 14 2018

Cc: bleung@chromium.org omrilio@chromium.org
The temporary fix in #19 sounds reasonable to me.
Project Member

Comment 23 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2000976a356bb27d591e67eac2cdf7351afc99d7

commit 2000976a356bb27d591e67eac2cdf7351afc99d7
Author: Malay Keshav <malaykeshav@chromium.org>
Date: Fri Jun 15 17:32:40 2018

Prevent touchscreen disable on lid close or user inactivity

In the event of user inactivity or lid close, this patch will prevent
the touchscreens from being disabled if an external touch device is
connected to the system.

Bug:  797411 
Change-Id: I12afd55edfe343ff6508bd2fdd0f4d09c93b5a98
Component: backlights settter, touch device, wake up, power manager
Testing: Added ash unittests to check for expected behavior
Reviewed-on: https://chromium-review.googlesource.com/1102151
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567710}
[modify] https://crrev.com/2000976a356bb27d591e67eac2cdf7351afc99d7/ash/system/power/backlights_forced_off_setter.cc
[modify] https://crrev.com/2000976a356bb27d591e67eac2cdf7351afc99d7/ash/system/power/backlights_forced_off_setter_unittest.cc

Labels: -M-62 -M-67 -M-66
Status: Fixed (was: Started)
Labels: Merge-Request-68
Project Member

Comment 26 by sheriffbot@chromium.org, Jun 16 2018

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-68 Merge-Approved-68
Project Member

Comment 28 by bugdroid1@chromium.org, Jun 18 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2438f5edcf1c00ab1374f29c528d3209ae3eb68b

commit 2438f5edcf1c00ab1374f29c528d3209ae3eb68b
Author: Malay Keshav <malaykeshav@chromium.org>
Date: Mon Jun 18 18:52:43 2018

(merge) Prevent touchscreen disable on lid close or user inactivity

In the event of user inactivity or lid close, this patch will prevent
the touchscreens from being disabled if an external touch device is
connected to the system.

Bug:  797411 
Change-Id: I12afd55edfe343ff6508bd2fdd0f4d09c93b5a98
Component: backlights settter, touch device, wake up, power manager
Testing: Added ash unittests to check for expected behavior
Reviewed-on: https://chromium-review.googlesource.com/1102151
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#567710}(cherry picked from commit 2000976a356bb27d591e67eac2cdf7351afc99d7)
Reviewed-on: https://chromium-review.googlesource.com/1104760
Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#406}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/2438f5edcf1c00ab1374f29c528d3209ae3eb68b/ash/system/power/backlights_forced_off_setter.cc
[modify] https://crrev.com/2438f5edcf1c00ab1374f29c528d3209ae3eb68b/ash/system/power/backlights_forced_off_setter_unittest.cc

Sign in to add a comment