New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 797371 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

argument --gn-gen not recognized by cros

Project Member Reported by semenzato@chromium.org, Dec 22 2017

Issue description

The instructions at

https://chromium.googlesource.com/chromiumos/docs/+/master/simple_chrome_workflow.md

advise passing the --gn-gen flag to cros chrome-sdk, but my version of cros does not recognize that flag.

The cros program does not have a --version option.  Doing a "git show" in my /usr/local/google/depot_tools directory shows 

semenzato@luigi:.../local/google/depot_tools$ git show
commit f2cb0f5b3ea5ba5ccd899494163ca7b264c7d445 (HEAD, origin/master, origin/HEAD)
Author:     Joao da Silva <joaodasilva@chromium.org>
AuthorDate: Thu Dec 21 17:05:03 2017 +0100
Commit:     Commit Bot <commit-bot@chromium.org>
CommitDate: Fri Dec 22 15:25:35 2017 +0000

etc. etc.

so that looks up to date.

It's not critical since I can run gn args inside the sdk, but I am wondering which side is wrong---the doc or the program.

 

Comment 1 by derat@chromium.org, Dec 22 2017

Owner: steve...@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by vapier@chromium.org, Dec 23 2017

cros is in chromite not depot_tools.  make sure your entire source checkout is up-to-date and not just the top level src/.  i.e. src/third_party/chromite.

you can't just use `git pull` in chromium to update things.  you need to use gclient so it'll update all the subrepos.
Status: WontFix (was: Assigned)
This was probably due to a stale git branch, resolved elsewhere.

Sign in to add a comment