Force sign in crashes with an external extension |
|||||||
Issue descriptionChrome Version: M63+ OS: Windows What steps will reproduce the problem? (1) Enabled force sign in policy. Set HKEY_LOCAL_MACHINE\SOFTWARE\Policies\Google\Chrome\ForceBrowserSignin to 1 (2) Create a external extension. HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Google\chrome\Extensions\lpcaedmchfhocbbapmcbpinfpgnhiddi\ With property update_url: https://clients2.google.com/service/update2/crx (3) Open Chrome (4) In UserManager, click "ADD PERSON" (5) Wait. What is the expected result? GAIA dialog is shown. What happens instead? GAIA dialog is shown. However, chrome crashes after a while.
,
Jan 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b71016d67397d6f33f8ef051665932b50369af7d commit b71016d67397d6f33f8ef051665932b50369af7d Author: Owen Min <zmin@chromium.org> Date: Thu Jan 11 01:51:49 2018 Blocked external extension will be alerted after being unblocked. When a external extension loaded, don't show alert to user if it's blocked. Wait until it's unblocked and moved to disabled list. Bug: 797369 Change-Id: I6239348a491c95ad148c1155d525a3845a8c59a0 Reviewed-on: https://chromium-review.googlesource.com/860912 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#528529} [modify] https://crrev.com/b71016d67397d6f33f8ef051665932b50369af7d/chrome/browser/extensions/extension_service.cc [modify] https://crrev.com/b71016d67397d6f33f8ef051665932b50369af7d/chrome/browser/extensions/extension_service_unittest.cc [modify] https://crrev.com/b71016d67397d6f33f8ef051665932b50369af7d/chrome/browser/extensions/external_install_manager.cc
,
Jan 12 2018
,
Jan 15 2018
Hello, I'd like to merge this into 64 as it fix a crash issue of force-sign-in policy. I have verified it in Canary last week and it's covered by a unit test.
,
Jan 15 2018
This bug requires manual review: We are only 7 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 15 2018
Note that we have at least one user who confirmed the fix on Canary, so this is good: https://bugs.chromium.org/p/chromium/issues/detail?id=175880#c183 Thanks.
,
Jan 16 2018
Approving merge for M64. Branch:3282
,
Jan 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ad36b5393d76fae9b018b58a1abfa0b736d1e5f commit 7ad36b5393d76fae9b018b58a1abfa0b736d1e5f Author: Owen Min <zmin@chromium.org> Date: Tue Jan 16 21:56:18 2018 Merge "Blocked external extension will be alerted after being unblocked." When a external extension loaded, don't show alert to user if it's blocked. Wait until it's unblocked and moved to disabled list. TBR=zmin@chromium.org (cherry picked from commit b71016d67397d6f33f8ef051665932b50369af7d) Bug: 797369 Change-Id: I6239348a491c95ad148c1155d525a3845a8c59a0 Reviewed-on: https://chromium-review.googlesource.com/860912 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#528529} Reviewed-on: https://chromium-review.googlesource.com/868633 Reviewed-by: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#513} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/7ad36b5393d76fae9b018b58a1abfa0b736d1e5f/chrome/browser/extensions/extension_service.cc [modify] https://crrev.com/7ad36b5393d76fae9b018b58a1abfa0b736d1e5f/chrome/browser/extensions/extension_service_unittest.cc [modify] https://crrev.com/7ad36b5393d76fae9b018b58a1abfa0b736d1e5f/chrome/browser/extensions/external_install_manager.cc
,
Feb 27 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by zmin@chromium.org
, Dec 22 2017