Settings WebUI: cookie_info.js loaded twice. |
||||
Issue descriptionAs part of the var to let/const migration I discovered (causes a runtime error) that cookie_info.js is loaded twice, unnecessarily, because we are using two <script> tags, instead of an HTML import, see [1]. Bugs like this are a good example of why migrating to let/const is beneficial. [1] https://cs.chromium.org/search/?q=src%3D%22cookie_info.js%22+file:%5Esrc/chrome/browser/resources/settings/+package:%5Echromium$&type=cs
,
Dec 22 2017
,
Dec 22 2017
,
Jan 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4decf32c999d499ca799686956267f982ed93c9d commit 4decf32c999d499ca799686956267f982ed93c9d Author: dpapad <dpapad@chromium.org> Date: Thu Jan 04 18:47:43 2018 Settings WebUI: Stop loading cookie_info.js twice. Bug: 797357 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia5ee932ad218174a121f27838a089e85b308980f Reviewed-on: https://chromium-review.googlesource.com/843144 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#527049} [modify] https://crrev.com/4decf32c999d499ca799686956267f982ed93c9d/chrome/browser/resources/settings/settings_resources.grd [add] https://crrev.com/4decf32c999d499ca799686956267f982ed93c9d/chrome/browser/resources/settings/site_settings/cookie_info.html [modify] https://crrev.com/4decf32c999d499ca799686956267f982ed93c9d/chrome/browser/resources/settings/site_settings/site_data.html [modify] https://crrev.com/4decf32c999d499ca799686956267f982ed93c9d/chrome/browser/resources/settings/site_settings/site_data_details_subpage.html
,
Jan 4 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dpa...@chromium.org
, Dec 22 2017