Omnibox UI Experiments: Hide Steady State Scheme and Subdomains |
||||||||
Issue descriptionBug for the engineering portions... PRD here: go/omnibox-ui-experiments-trim-displayed-url-on-blur
,
Dec 22 2017
,
Dec 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d79d440eea395e0b17bceeb1967f32e6d41e2768 commit d79d440eea395e0b17bceeb1967f32e6d41e2768 Author: Tommy C. Li <tommycli@chromium.org> Date: Fri Dec 22 23:57:40 2017 Omnibox UI Experiments: Add Hide Steady State URL Scheme/Subdomains flag Bug: 797354 Change-Id: Ia8ea488cf76881590cf0bdab5c2f2c222ab5b408 Reviewed-on: https://chromium-review.googlesource.com/843239 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#526096} [modify] https://crrev.com/d79d440eea395e0b17bceeb1967f32e6d41e2768/chrome/browser/about_flags.cc [modify] https://crrev.com/d79d440eea395e0b17bceeb1967f32e6d41e2768/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/d79d440eea395e0b17bceeb1967f32e6d41e2768/chrome/browser/flag_descriptions.h [modify] https://crrev.com/d79d440eea395e0b17bceeb1967f32e6d41e2768/components/omnibox/browser/omnibox_field_trial.cc [modify] https://crrev.com/d79d440eea395e0b17bceeb1967f32e6d41e2768/components/omnibox/browser/omnibox_field_trial.h [modify] https://crrev.com/d79d440eea395e0b17bceeb1967f32e6d41e2768/tools/metrics/histograms/enums.xml
,
Jan 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/142de38acea69021afc8defc32ddbc4763b11baf commit 142de38acea69021afc8defc32ddbc4763b11baf Author: Tommy C. Li <tommycli@chromium.org> Date: Mon Jan 22 22:48:20 2018 Omnibox UI Experiments: Rename GetFormattedURL to GetFormattedFullURL In preparation for eliding parts of the displayed URL in the steady state Omnibox, we are going to introduce a GetURLForDisplay method. To keep things clear, we're renaming the old method from GetFormattedURL to GetFormattedFullURL to clarify that this old method (generally) yields a string with the equivalent meaning to the input URL. This is in contrast to the new GetURLForDisplay method which may perform destructive (meaning-changing) elisions. Bug: 797354 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8dbcffe47dd4252b6f1dd589e58583f851965d55 TBR=rohitrao@chromium.org Change-Id: I8dbcffe47dd4252b6f1dd589e58583f851965d55 Reviewed-on: https://chromium-review.googlesource.com/876646 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#531029} [modify] https://crrev.com/142de38acea69021afc8defc32ddbc4763b11baf/chrome/browser/ui/android/toolbar/toolbar_model_android.cc [modify] https://crrev.com/142de38acea69021afc8defc32ddbc4763b11baf/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm [modify] https://crrev.com/142de38acea69021afc8defc32ddbc4763b11baf/chrome/browser/ui/toolbar/toolbar_model_unittest.cc [modify] https://crrev.com/142de38acea69021afc8defc32ddbc4763b11baf/chrome/browser/ui/views/omnibox/omnibox_view_views.cc [modify] https://crrev.com/142de38acea69021afc8defc32ddbc4763b11baf/components/toolbar/test_toolbar_model.cc [modify] https://crrev.com/142de38acea69021afc8defc32ddbc4763b11baf/components/toolbar/test_toolbar_model.h [modify] https://crrev.com/142de38acea69021afc8defc32ddbc4763b11baf/components/toolbar/toolbar_model.h [modify] https://crrev.com/142de38acea69021afc8defc32ddbc4763b11baf/components/toolbar/toolbar_model_impl.cc [modify] https://crrev.com/142de38acea69021afc8defc32ddbc4763b11baf/components/toolbar/toolbar_model_impl.h [modify] https://crrev.com/142de38acea69021afc8defc32ddbc4763b11baf/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm
,
Jan 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c71963abef09ea6dd2c3b53996f9580643665e5c commit c71963abef09ea6dd2c3b53996f9580643665e5c Author: Tommy C. Li <tommycli@chromium.org> Date: Mon Jan 22 23:29:00 2018 Omnibox UI Experiments: Add a GetURLForDisplay method with elisions. Add a new GetURLForDisplay method to sit alongside GetFormattedFullURL. This will be used in the Omnibox if the feature flag is on. The actual implementation knows nothing about the feature flag, since the feature flag is an Omnibox concern rather than a components/toolbar concern. Bug: 797354 Change-Id: I61fe6a70a5d7bb990a52866a9a28da8bc50d8a36 Reviewed-on: https://chromium-review.googlesource.com/877040 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#531055} [modify] https://crrev.com/c71963abef09ea6dd2c3b53996f9580643665e5c/chrome/browser/ui/toolbar/toolbar_model_unittest.cc [modify] https://crrev.com/c71963abef09ea6dd2c3b53996f9580643665e5c/components/toolbar/test_toolbar_model.cc [modify] https://crrev.com/c71963abef09ea6dd2c3b53996f9580643665e5c/components/toolbar/test_toolbar_model.h [modify] https://crrev.com/c71963abef09ea6dd2c3b53996f9580643665e5c/components/toolbar/toolbar_model.h [modify] https://crrev.com/c71963abef09ea6dd2c3b53996f9580643665e5c/components/toolbar/toolbar_model_impl.cc [modify] https://crrev.com/c71963abef09ea6dd2c3b53996f9580643665e5c/components/toolbar/toolbar_model_impl.h
,
Jan 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ea75e8771240539d6b9fef4d71a2ce93ad4637e commit 8ea75e8771240539d6b9fef4d71a2ce93ad4637e Author: Tommy C. Li <tommycli@chromium.org> Date: Fri Jan 26 19:04:28 2018 Omnibox UI Experiments: Show elided permanent URLs (when flag on) This CL enables showing the elided permanent URLs when the flag is on. It also restores the full URL on focus and puts back the elided one on blur (assuming it hasn't been edited). No selection adjustment logic exists in this CL. Bug: 797354 Change-Id: I1fc6a8aa37aaf4582db2b6895a1292006da3114b Reviewed-on: https://chromium-review.googlesource.com/882617 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#532033} [modify] https://crrev.com/8ea75e8771240539d6b9fef4d71a2ce93ad4637e/chrome/browser/ui/views/omnibox/omnibox_view_views.cc [modify] https://crrev.com/8ea75e8771240539d6b9fef4d71a2ce93ad4637e/components/omnibox/browser/omnibox_edit_controller.cc [modify] https://crrev.com/8ea75e8771240539d6b9fef4d71a2ce93ad4637e/components/omnibox/browser/omnibox_edit_controller.h [modify] https://crrev.com/8ea75e8771240539d6b9fef4d71a2ce93ad4637e/components/omnibox/browser/omnibox_edit_model.cc
,
Feb 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60eb7331f570a0c8e278ef30ed637ddea276dc9b commit 60eb7331f570a0c8e278ef30ed637ddea276dc9b Author: Tommy C. Li <tommycli@chromium.org> Date: Thu Feb 08 00:21:18 2018 Omnibox UI Experiments: Display-only vs editing text in omnibox Introduces a concept in the OmniboxEditModel of a display-only permanent URL text vs. an editable URL permanent text. These should be identical unless the omnibox::kUIExperimentHideSteadyStateUrlSchemeAndSubdomains flag is on. This CL should create no user visible behavior changes. TBR=rohitrao@chromium.org Bug: 797354 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I81c067f3599538c8a41442d602c4b3b2ac7ea37c Reviewed-on: https://chromium-review.googlesource.com/902342 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#535210} [modify] https://crrev.com/60eb7331f570a0c8e278ef30ed637ddea276dc9b/chrome/browser/autocomplete/autocomplete_browsertest.cc [modify] https://crrev.com/60eb7331f570a0c8e278ef30ed637ddea276dc9b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm [modify] https://crrev.com/60eb7331f570a0c8e278ef30ed637ddea276dc9b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc [modify] https://crrev.com/60eb7331f570a0c8e278ef30ed637ddea276dc9b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc [modify] https://crrev.com/60eb7331f570a0c8e278ef30ed637ddea276dc9b/components/omnibox/browser/BUILD.gn [modify] https://crrev.com/60eb7331f570a0c8e278ef30ed637ddea276dc9b/components/omnibox/browser/omnibox_edit_controller.cc [modify] https://crrev.com/60eb7331f570a0c8e278ef30ed637ddea276dc9b/components/omnibox/browser/omnibox_edit_controller.h [modify] https://crrev.com/60eb7331f570a0c8e278ef30ed637ddea276dc9b/components/omnibox/browser/omnibox_edit_model.cc [modify] https://crrev.com/60eb7331f570a0c8e278ef30ed637ddea276dc9b/components/omnibox/browser/omnibox_edit_model.h [modify] https://crrev.com/60eb7331f570a0c8e278ef30ed637ddea276dc9b/components/omnibox/browser/omnibox_edit_model_unittest.cc [modify] https://crrev.com/60eb7331f570a0c8e278ef30ed637ddea276dc9b/components/omnibox/browser/test_omnibox_edit_controller.cc [modify] https://crrev.com/60eb7331f570a0c8e278ef30ed637ddea276dc9b/components/omnibox/browser/test_omnibox_edit_controller.h [modify] https://crrev.com/60eb7331f570a0c8e278ef30ed637ddea276dc9b/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm
,
Feb 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c19f2f460fb76117b1c24b2bec9cef929cf8bb3 commit 0c19f2f460fb76117b1c24b2bec9cef929cf8bb3 Author: Tommy C. Li <tommycli@chromium.org> Date: Wed Feb 21 01:24:07 2018 Omnibox: Re-add stripped HTTPS in OmniboxEditModel::AdjustTextForCopy We will need this for steady state elisions. Bug: 492711 , 797354 Change-Id: I806389fcccc406265f05f8c4600767289f807581 Reviewed-on: https://chromium-review.googlesource.com/914512 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#537976} [modify] https://crrev.com/0c19f2f460fb76117b1c24b2bec9cef929cf8bb3/components/omnibox/browser/omnibox_edit_model.cc [modify] https://crrev.com/0c19f2f460fb76117b1c24b2bec9cef929cf8bb3/components/omnibox/browser/omnibox_edit_model.h [modify] https://crrev.com/0c19f2f460fb76117b1c24b2bec9cef929cf8bb3/components/omnibox/browser/omnibox_edit_model_unittest.cc
,
Feb 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/035d76efdc7c9533c396b2e58c76d2f9e3dae118 commit 035d76efdc7c9533c396b2e58c76d2f9e3dae118 Author: Tommy C. Li <tommycli@chromium.org> Date: Sat Feb 24 03:29:42 2018 Omnibox UI Experiments: Refine steady state elision for double-click Previously, for double-click partial selections, the partial select took place on mousedown, and the unelision took place on mouseup. This CL makes them both take place on mousedown, to (hopefully) reduce the visual noise. Bug: 797354 Change-Id: I7a7d26740ffeef028a368a9d3b467c54674b8a83 Reviewed-on: https://chromium-review.googlesource.com/935828 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#538979} [modify] https://crrev.com/035d76efdc7c9533c396b2e58c76d2f9e3dae118/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
,
Feb 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18189eff594d350048511820c1ddb9f0d5ead61d commit 18189eff594d350048511820c1ddb9f0d5ead61d Author: Tommy C. Li <tommycli@chromium.org> Date: Wed Feb 28 02:02:25 2018 Omnibox UI Experiments: Fix steady state elision for long URLs Previously unapplying the steady state elisions would scroll the Omnibox to the end of the full URL. This was noticable for long URLs. This CL fixes that. Bug: 797354 Change-Id: I0a5e72d6d989fedeb97f6bef695465db9228fdcb Reviewed-on: https://chromium-review.googlesource.com/939880 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#539651} [modify] https://crrev.com/18189eff594d350048511820c1ddb9f0d5ead61d/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
,
Feb 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a5ca21b9ec8f7f4b56797878386595636f57578 commit 7a5ca21b9ec8f7f4b56797878386595636f57578 Author: Tommy C. Li <tommycli@chromium.org> Date: Wed Feb 28 19:05:44 2018 Omnibox UI Experiments: Steady State elisions - fix double-click-select. Fix double-click word select for steady state elisions. This bug is caused by the fact that we change the text in response to a double-click on the second mousedown. That confuses the double click word select logic, which saves the range into a member variable. There's no way for the selection controller to get the correct selected word except for us to inject an offset into it... Bug: 797354 Change-Id: I464d405920de7dfcbc317ed9ecbe8b664b920f8d Reviewed-on: https://chromium-review.googlesource.com/940603 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#539913} [modify] https://crrev.com/7a5ca21b9ec8f7f4b56797878386595636f57578/chrome/browser/ui/views/omnibox/omnibox_view_views.cc [modify] https://crrev.com/7a5ca21b9ec8f7f4b56797878386595636f57578/ui/views/controls/textfield/textfield.cc [modify] https://crrev.com/7a5ca21b9ec8f7f4b56797878386595636f57578/ui/views/controls/textfield/textfield.h [modify] https://crrev.com/7a5ca21b9ec8f7f4b56797878386595636f57578/ui/views/selection_controller.cc [modify] https://crrev.com/7a5ca21b9ec8f7f4b56797878386595636f57578/ui/views/selection_controller.h
,
Mar 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6513c0a158d8bc6c99b2ef62ba29268e7dfb9398 commit 6513c0a158d8bc6c99b2ef62ba29268e7dfb9398 Author: Tommy C. Li <tommycli@chromium.org> Date: Mon Mar 05 23:44:13 2018 Omnibox UI Experiments: Steady State elisions - fix Home and Shift+Home This makes Home go to the beginning of the full unelided URL. It also makes Shift+Home select the elided part (scheme and subdomain) portion of the URL only. Bug: 797354 Change-Id: I47d9a7ad25e8dcb10f2e53f638cded6649ffa564 Reviewed-on: https://chromium-review.googlesource.com/944508 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#540988} [modify] https://crrev.com/6513c0a158d8bc6c99b2ef62ba29268e7dfb9398/chrome/browser/ui/views/omnibox/omnibox_view_views.cc [modify] https://crrev.com/6513c0a158d8bc6c99b2ef62ba29268e7dfb9398/chrome/browser/ui/views/omnibox/omnibox_view_views.h
,
Mar 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bcca8d4a2b5164aecdfa039c29a065a832ab50af commit bcca8d4a2b5164aecdfa039c29a065a832ab50af Author: Tommy C. Li <tommycli@chromium.org> Date: Thu Mar 08 17:38:51 2018 Views: Make double/triple click work better for moving Labels/Textfields We currently track double and triple clicks' last click locations, and prevent them from aggregating and "counting" as a double/triple click if the user has moved the mouse a delta exceeding the drag threshold. This is currently problematic for Views that move as a result of a click, as we are tracking the location() with respect to the local View. This CL makes the location stored track the root_location(), which is likely closer to what the user expects, since we don't care if the local View moves with respect to the mouse, but rather if the mouse moves in an absolute sense. This also fixes triple-click for Steady State Elisions in Omnibox UI. Bug: 797354 Change-Id: Ie29a5f61fa6ae7292dcdf854f1ace2935a640e31 Reviewed-on: https://chromium-review.googlesource.com/954014 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#541826} [modify] https://crrev.com/bcca8d4a2b5164aecdfa039c29a065a832ab50af/ui/views/selection_controller.cc
,
Mar 15 2018
,
Mar 28 2018
Pls apply applicable OSs label. Thank you. Adding Target-68 based on internal tracker.
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd5a64226c950e9b5ae8a7fbd906e4549401b346 commit dd5a64226c950e9b5ae8a7fbd906e4549401b346 Author: Tommy C. Li <tommycli@chromium.org> Date: Wed Apr 04 03:24:32 2018 Omnibox UI Experiments: Steady state elisions - reelide on blur For steady state elisions, we currently unelide when the user places the caret in the URL or makes a partial selection. This restores hidden schemes and hides the security chip. However, we don't re-elide in any circumstances currently, even if the user has made no edits. This CL re-elides on blur if the user has not made any edits, and also restores the security chip. One more note: This CL subtly changes the behavior even with steady state elisions off. It will revert and re-show the security chip on blur if the user adds and then deletes a character to the URL (restoring the original URL). This seems like a harmless and slightly beneficial change. Bug: 797354 Change-Id: I87966e388034ed0573756e9f7985540dc4315c83 Reviewed-on: https://chromium-review.googlesource.com/993696 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#547970} [modify] https://crrev.com/dd5a64226c950e9b5ae8a7fbd906e4549401b346/chrome/browser/ui/views/omnibox/omnibox_view_views.cc [modify] https://crrev.com/dd5a64226c950e9b5ae8a7fbd906e4549401b346/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a12554afb17da2850132b1066990ba9ae109395e commit a12554afb17da2850132b1066990ba9ae109395e Author: Tommy C. Li <tommycli@chromium.org> Date: Thu Apr 05 19:01:50 2018 Omnibox UI Experiments: Steady state elisions - Unit test for arrow keys When steady state elisions is on, the user focuses the Omnibox, and presses an arrow key, we should unelide and place the cursor correctly. This adds a unit test for the above behavior. Bug: 797354 Change-Id: I417603b21c89a634dc494dcbe3a764f19d7f0d27 Reviewed-on: https://chromium-review.googlesource.com/996295 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#548513} [modify] https://crrev.com/a12554afb17da2850132b1066990ba9ae109395e/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc [modify] https://crrev.com/a12554afb17da2850132b1066990ba9ae109395e/chrome/browser/ui/views/omnibox/omnibox_view_views.h [modify] https://crrev.com/a12554afb17da2850132b1066990ba9ae109395e/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc [modify] https://crrev.com/a12554afb17da2850132b1066990ba9ae109395e/components/omnibox/browser/omnibox_edit_model_unittest.cc [modify] https://crrev.com/a12554afb17da2850132b1066990ba9ae109395e/components/toolbar/test_toolbar_model.cc [modify] https://crrev.com/a12554afb17da2850132b1066990ba9ae109395e/components/toolbar/test_toolbar_model.h
,
Apr 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea98119eae4d193a9b733784624e2dba59bcd44b commit ea98119eae4d193a9b733784624e2dba59bcd44b Author: Tommy C. Li <tommycli@chromium.org> Date: Fri Apr 06 02:31:30 2018 Omnibox UI Experiments: Steady state elisions - Tests for Home and Tap When Steady State elisions is on, and the user focuses the Omnibox, and then presses the Home key, we should unelide and place the caret at the very beginning of the full URL. Also, when the user gesture taps the Omnibox twice to place a cursor, we should also unelide and display the full URL. This CL adds a unit test for each of the above two behaviors. It also updates the TextField class to add a missing nullptr check for GetInputMethod(). This method returns nullptr in tests, and is checked in the other places it's used in the file. Bug: 797354 Change-Id: I9537028b8cb0abfdb5316efd5bae5518055f5ecf Reviewed-on: https://chromium-review.googlesource.com/998835 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#548644} [modify] https://crrev.com/ea98119eae4d193a9b733784624e2dba59bcd44b/chrome/browser/ui/views/omnibox/omnibox_view_views.h [modify] https://crrev.com/ea98119eae4d193a9b733784624e2dba59bcd44b/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc [modify] https://crrev.com/ea98119eae4d193a9b733784624e2dba59bcd44b/ui/views/controls/textfield/textfield.cc
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5fa9e7de218ee16726d8a36f874570993f54a1b2 commit 5fa9e7de218ee16726d8a36f874570993f54a1b2 Author: Tommy C. Li <tommycli@chromium.org> Date: Fri Apr 13 00:58:28 2018 Omnibox UI Experiments: Steady State Elisions - add test for mouse click When Steady State Elisions is on, when the user clicks the mouse once, it should focus and select all in the text field. When the user places the caret inside the text by clicking on the text a second time, it should unelide on mouseup only. This adds a test for that. It also places the View inside a Widget to make the focus behave correctly. It also adds a fake clock to the Steady State Elisions test, so we can control the click being not interpreted as a double-click. Bug: 797354 Change-Id: If72235dd88b6918f9071fffea800723a24c555f7 Reviewed-on: https://chromium-review.googlesource.com/1007492 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#550449} [modify] https://crrev.com/5fa9e7de218ee16726d8a36f874570993f54a1b2/chrome/browser/ui/views/omnibox/omnibox_view_views.h [modify] https://crrev.com/5fa9e7de218ee16726d8a36f874570993f54a1b2/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef3709c40696489324960dc55c799327268b6a09 commit ef3709c40696489324960dc55c799327268b6a09 Author: Tommy C. Li <tommycli@chromium.org> Date: Fri Apr 13 15:13:50 2018 Omnibox UI Experiments: Steady State Elisions double/triple click tests This CL tests that double-click triggers unelision of steady state elided URLs with the proper portion selected afterwards. This unelision occurs on the second mousedown. It also tests that triple-click triggers unelision and ends with everything selected. Bug: 797354 Change-Id: I3174242ad5f188ef0808a859a376bc0393a76faf Reviewed-on: https://chromium-review.googlesource.com/1008866 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#550624} [modify] https://crrev.com/ef3709c40696489324960dc55c799327268b6a09/chrome/browser/ui/views/omnibox/omnibox_view_views.h [modify] https://crrev.com/ef3709c40696489324960dc55c799327268b6a09/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b75a6227027468a44de506e333f7820c46514ab commit 2b75a6227027468a44de506e333f7820c46514ab Author: Tommy C. Li <tommycli@chromium.org> Date: Fri Apr 13 18:35:30 2018 Omnibox UI Experiments: Steady State Elisions - Add drag selection test On drag selection, the steady state URL should not be unelided until the mouse is released, at which point it should be unelided. The selection should be adjusted so that the same portion is selected even after the prefix is reattached. This CL tests that. Bug: 797354 Change-Id: Ie6a6a6dcbe08f2eba3def90595b496cfff4206b8 Reviewed-on: https://chromium-review.googlesource.com/1008878 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#550694} [modify] https://crrev.com/2b75a6227027468a44de506e333f7820c46514ab/chrome/browser/ui/views/omnibox/omnibox_view_views.h [modify] https://crrev.com/2b75a6227027468a44de506e333f7820c46514ab/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ec35aa24b818fad4eb0279cb41acf3f42c7ef7b commit 1ec35aa24b818fad4eb0279cb41acf3f42c7ef7b Author: Tommy C. Li <tommycli@chromium.org> Date: Fri Apr 13 23:20:27 2018 Omnibox UI Experiments: Steady State Elision - double click drag test When the user double-click drags, we should unelide on the second mouse down and start word selection mode. This CL adds a test for the above behavior. Bug: 797354 Change-Id: I64d0b880a0b560c6f249e2a15f9e38b36cb51364 Reviewed-on: https://chromium-review.googlesource.com/1012512 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#550801} [modify] https://crrev.com/1ec35aa24b818fad4eb0279cb41acf3f42c7ef7b/chrome/browser/ui/views/omnibox/omnibox_view_views.h [modify] https://crrev.com/1ec35aa24b818fad4eb0279cb41acf3f42c7ef7b/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc
,
Apr 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30b157e0735ca9f189614d3989a41547cce6b35e commit 30b157e0735ca9f189614d3989a41547cce6b35e Author: Tommy C. Li <tommycli@chromium.org> Date: Mon Apr 16 17:39:24 2018 Omnibox UI Experiments: Steady State Elision - Reelide on blur tests When the URL is un-elided, and then the Omnibox is blurred: a) If the text has not been edited, re-elide the URL. b) If the text has been edited, leave the complete edited text as-is. This CL adds two tests - one for each scenario. Bug: 797354 Change-Id: Ia70cf4357218e3b8f043be73716f067d7b287fd4 Reviewed-on: https://chromium-review.googlesource.com/1012778 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#551025} [modify] https://crrev.com/30b157e0735ca9f189614d3989a41547cce6b35e/chrome/browser/ui/views/omnibox/omnibox_view_views.h [modify] https://crrev.com/30b157e0735ca9f189614d3989a41547cce6b35e/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc
,
Apr 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86751887e107d90e0c6951d51110677f2c2b7296 commit 86751887e107d90e0c6951d51110677f2c2b7296 Author: Tommy C. Li <tommycli@chromium.org> Date: Mon Apr 16 21:59:14 2018 Omnibox UI Experiments: Steady State Elisions - Fix blur/refocus bug When Steady State Elisions is on, there's currently the following bug: When the user clicks the Omnibox (and selects everything), then Alt-Tabs out of the window, and Alt-Tabs back in, the selection changes from select-all to a cursor at the beginning of the Omnibox. This CL fixes the bug and adds a test to prevent regression. The bug was caused by some old code in OmniboxEditModel that should have been deleted a while ago. It also refactors the test a bit to make the focus and blur fake events more robust. It also updates the OmniboxViewViews::OnFocus method to be suitable for usage within tests (rather than overriding and defining a fake one). Bug: 797354 Change-Id: I4516455cf81e4097f27605f52a669f01f7c17f61 Reviewed-on: https://chromium-review.googlesource.com/1013209 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#551137} [modify] https://crrev.com/86751887e107d90e0c6951d51110677f2c2b7296/chrome/browser/ui/views/omnibox/omnibox_view_views.cc [modify] https://crrev.com/86751887e107d90e0c6951d51110677f2c2b7296/chrome/browser/ui/views/omnibox/omnibox_view_views.h [modify] https://crrev.com/86751887e107d90e0c6951d51110677f2c2b7296/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc [modify] https://crrev.com/86751887e107d90e0c6951d51110677f2c2b7296/components/omnibox/browser/omnibox_edit_model.cc
,
Apr 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c74cdcf786ee105487747af0bd2183e4b30b555 commit 6c74cdcf786ee105487747af0bd2183e4b30b555 Author: Tommy C. Li <tommycli@chromium.org> Date: Mon Apr 16 22:55:47 2018 Omnibox UI Experiments: Steady State Elisions - don't re-elide on alt-tab Previously, when the user placed the cursor in the URL and unelided the URL, and then pressed Alt-Tab to switch windows, and then to switch back, the URL would be re-elided. This is not desirable. The Omnibox state should not change merely from switching windows. It should re-elide only if the user focuses something else in the same window. This CL fixes the bug and adds a test for this behavior. It also updates the test to make failure messages more clear about which line has the failing condition. Bug: 797354 Change-Id: I43905e1248c439651bd6b6a66d57d46dff0989e2 Reviewed-on: https://chromium-review.googlesource.com/1014347 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#551158} [modify] https://crrev.com/6c74cdcf786ee105487747af0bd2183e4b30b555/chrome/browser/ui/views/omnibox/omnibox_view_views.cc [modify] https://crrev.com/6c74cdcf786ee105487747af0bd2183e4b30b555/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc
,
Apr 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b87ff228c97fd7b7117bb37bf6cc4a769050b67 commit 8b87ff228c97fd7b7117bb37bf6cc4a769050b67 Author: Tommy C. Li <tommycli@chromium.org> Date: Mon Apr 16 23:29:01 2018 Omnibox UI Experiments: Steady State Elisions - Replace TODO w/ comment Looking back on this TODO, I think using the FormatURL offsets is overkill, requires a lot of plumbing, and confusing for the maintainer compared to this "simple" logic. So I'm deleting the TODO and replacing it with a comment that explains why we can use the "simple" logic and when we would have to replace it. Bug: 797354 Change-Id: Idffe358c054fb2f70a4bd91c928af324b1edf650 Reviewed-on: https://chromium-review.googlesource.com/1014394 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#551168} [modify] https://crrev.com/8b87ff228c97fd7b7117bb37bf6cc4a769050b67/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5fa9e7de218ee16726d8a36f874570993f54a1b2 commit 5fa9e7de218ee16726d8a36f874570993f54a1b2 Author: Tommy C. Li <tommycli@chromium.org> Date: Fri Apr 13 00:58:28 2018 Omnibox UI Experiments: Steady State Elisions - add test for mouse click When Steady State Elisions is on, when the user clicks the mouse once, it should focus and select all in the text field. When the user places the caret inside the text by clicking on the text a second time, it should unelide on mouseup only. This adds a test for that. It also places the View inside a Widget to make the focus behave correctly. It also adds a fake clock to the Steady State Elisions test, so we can control the click being not interpreted as a double-click. Bug: 797354 Change-Id: If72235dd88b6918f9071fffea800723a24c555f7 Reviewed-on: https://chromium-review.googlesource.com/1007492 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#550449} [modify] https://crrev.com/5fa9e7de218ee16726d8a36f874570993f54a1b2/chrome/browser/ui/views/omnibox/omnibox_view_views.h [modify] https://crrev.com/5fa9e7de218ee16726d8a36f874570993f54a1b2/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef3709c40696489324960dc55c799327268b6a09 commit ef3709c40696489324960dc55c799327268b6a09 Author: Tommy C. Li <tommycli@chromium.org> Date: Fri Apr 13 15:13:50 2018 Omnibox UI Experiments: Steady State Elisions double/triple click tests This CL tests that double-click triggers unelision of steady state elided URLs with the proper portion selected afterwards. This unelision occurs on the second mousedown. It also tests that triple-click triggers unelision and ends with everything selected. Bug: 797354 Change-Id: I3174242ad5f188ef0808a859a376bc0393a76faf Reviewed-on: https://chromium-review.googlesource.com/1008866 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#550624} [modify] https://crrev.com/ef3709c40696489324960dc55c799327268b6a09/chrome/browser/ui/views/omnibox/omnibox_view_views.h [modify] https://crrev.com/ef3709c40696489324960dc55c799327268b6a09/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b75a6227027468a44de506e333f7820c46514ab commit 2b75a6227027468a44de506e333f7820c46514ab Author: Tommy C. Li <tommycli@chromium.org> Date: Fri Apr 13 18:35:30 2018 Omnibox UI Experiments: Steady State Elisions - Add drag selection test On drag selection, the steady state URL should not be unelided until the mouse is released, at which point it should be unelided. The selection should be adjusted so that the same portion is selected even after the prefix is reattached. This CL tests that. Bug: 797354 Change-Id: Ie6a6a6dcbe08f2eba3def90595b496cfff4206b8 Reviewed-on: https://chromium-review.googlesource.com/1008878 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#550694} [modify] https://crrev.com/2b75a6227027468a44de506e333f7820c46514ab/chrome/browser/ui/views/omnibox/omnibox_view_views.h [modify] https://crrev.com/2b75a6227027468a44de506e333f7820c46514ab/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ec35aa24b818fad4eb0279cb41acf3f42c7ef7b commit 1ec35aa24b818fad4eb0279cb41acf3f42c7ef7b Author: Tommy C. Li <tommycli@chromium.org> Date: Fri Apr 13 23:20:27 2018 Omnibox UI Experiments: Steady State Elision - double click drag test When the user double-click drags, we should unelide on the second mouse down and start word selection mode. This CL adds a test for the above behavior. Bug: 797354 Change-Id: I64d0b880a0b560c6f249e2a15f9e38b36cb51364 Reviewed-on: https://chromium-review.googlesource.com/1012512 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#550801} [modify] https://crrev.com/1ec35aa24b818fad4eb0279cb41acf3f42c7ef7b/chrome/browser/ui/views/omnibox/omnibox_view_views.h [modify] https://crrev.com/1ec35aa24b818fad4eb0279cb41acf3f42c7ef7b/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30b157e0735ca9f189614d3989a41547cce6b35e commit 30b157e0735ca9f189614d3989a41547cce6b35e Author: Tommy C. Li <tommycli@chromium.org> Date: Mon Apr 16 17:39:24 2018 Omnibox UI Experiments: Steady State Elision - Reelide on blur tests When the URL is un-elided, and then the Omnibox is blurred: a) If the text has not been edited, re-elide the URL. b) If the text has been edited, leave the complete edited text as-is. This CL adds two tests - one for each scenario. Bug: 797354 Change-Id: Ia70cf4357218e3b8f043be73716f067d7b287fd4 Reviewed-on: https://chromium-review.googlesource.com/1012778 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#551025} [modify] https://crrev.com/30b157e0735ca9f189614d3989a41547cce6b35e/chrome/browser/ui/views/omnibox/omnibox_view_views.h [modify] https://crrev.com/30b157e0735ca9f189614d3989a41547cce6b35e/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86751887e107d90e0c6951d51110677f2c2b7296 commit 86751887e107d90e0c6951d51110677f2c2b7296 Author: Tommy C. Li <tommycli@chromium.org> Date: Mon Apr 16 21:59:14 2018 Omnibox UI Experiments: Steady State Elisions - Fix blur/refocus bug When Steady State Elisions is on, there's currently the following bug: When the user clicks the Omnibox (and selects everything), then Alt-Tabs out of the window, and Alt-Tabs back in, the selection changes from select-all to a cursor at the beginning of the Omnibox. This CL fixes the bug and adds a test to prevent regression. The bug was caused by some old code in OmniboxEditModel that should have been deleted a while ago. It also refactors the test a bit to make the focus and blur fake events more robust. It also updates the OmniboxViewViews::OnFocus method to be suitable for usage within tests (rather than overriding and defining a fake one). Bug: 797354 Change-Id: I4516455cf81e4097f27605f52a669f01f7c17f61 Reviewed-on: https://chromium-review.googlesource.com/1013209 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#551137} [modify] https://crrev.com/86751887e107d90e0c6951d51110677f2c2b7296/chrome/browser/ui/views/omnibox/omnibox_view_views.cc [modify] https://crrev.com/86751887e107d90e0c6951d51110677f2c2b7296/chrome/browser/ui/views/omnibox/omnibox_view_views.h [modify] https://crrev.com/86751887e107d90e0c6951d51110677f2c2b7296/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc [modify] https://crrev.com/86751887e107d90e0c6951d51110677f2c2b7296/components/omnibox/browser/omnibox_edit_model.cc
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c74cdcf786ee105487747af0bd2183e4b30b555 commit 6c74cdcf786ee105487747af0bd2183e4b30b555 Author: Tommy C. Li <tommycli@chromium.org> Date: Mon Apr 16 22:55:47 2018 Omnibox UI Experiments: Steady State Elisions - don't re-elide on alt-tab Previously, when the user placed the cursor in the URL and unelided the URL, and then pressed Alt-Tab to switch windows, and then to switch back, the URL would be re-elided. This is not desirable. The Omnibox state should not change merely from switching windows. It should re-elide only if the user focuses something else in the same window. This CL fixes the bug and adds a test for this behavior. It also updates the test to make failure messages more clear about which line has the failing condition. Bug: 797354 Change-Id: I43905e1248c439651bd6b6a66d57d46dff0989e2 Reviewed-on: https://chromium-review.googlesource.com/1014347 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#551158} [modify] https://crrev.com/6c74cdcf786ee105487747af0bd2183e4b30b555/chrome/browser/ui/views/omnibox/omnibox_view_views.cc [modify] https://crrev.com/6c74cdcf786ee105487747af0bd2183e4b30b555/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b87ff228c97fd7b7117bb37bf6cc4a769050b67 commit 8b87ff228c97fd7b7117bb37bf6cc4a769050b67 Author: Tommy C. Li <tommycli@chromium.org> Date: Mon Apr 16 23:29:01 2018 Omnibox UI Experiments: Steady State Elisions - Replace TODO w/ comment Looking back on this TODO, I think using the FormatURL offsets is overkill, requires a lot of plumbing, and confusing for the maintainer compared to this "simple" logic. So I'm deleting the TODO and replacing it with a comment that explains why we can use the "simple" logic and when we would have to replace it. Bug: 797354 Change-Id: Idffe358c054fb2f70a4bd91c928af324b1edf650 Reviewed-on: https://chromium-review.googlesource.com/1014394 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#551168} [modify] https://crrev.com/8b87ff228c97fd7b7117bb37bf6cc4a769050b67/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9115e6c040cfe10c044dc45b75304170d09db67 commit f9115e6c040cfe10c044dc45b75304170d09db67 Author: Tommy C. Li <tommycli@chromium.org> Date: Tue Apr 17 22:41:54 2018 Omnibox UI: Don't use the display URL to generate matches Previously, when the autocomplete engine did not provide any matches, the OmniboxEditModel would generate a current match from the text contents of the View. This would lead to bad behavior when Steady State Elisions was on. For example, if the user was at the full URL https://router/, and the elided display text was simply "router", this would trigger a search when the user pressed Ctrl+L, and then Enter. This CL fixes that by only using the View text if user input is in progress, and using the full formatted URL otherwise (if in display mode). This bug doesn't have an impact unless the Steady State Elisions flag is on, so this doesn't require a merge. This CL also adds a test. Bug: 797354 Change-Id: Id27913f567313333e8a171a8040bf906a7a1cc52 Reviewed-on: https://chromium-review.googlesource.com/1013694 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#551509} [modify] https://crrev.com/f9115e6c040cfe10c044dc45b75304170d09db67/components/omnibox/browser/omnibox_edit_model.cc [modify] https://crrev.com/f9115e6c040cfe10c044dc45b75304170d09db67/components/omnibox/browser/omnibox_edit_model_unittest.cc
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54d6ad62258f03e21bf918d647686bd7b8aa4d15 commit 54d6ad62258f03e21bf918d647686bd7b8aa4d15 Author: Tommy C. Li <tommycli@chromium.org> Date: Thu Apr 19 20:42:56 2018 Toolbar UI: Re-append / on the display URL for intranet hosts Previously, we only ran FormattedStringWithEquivalentMeaning on the full formatted URL, but not the display (elided) URL. This function re-appends the '/' slash character on intranet hosts so they are not mistaken for a search term. We want to re-append this slash character on elided URLs as well, and this CL effects this change -- as well as adds a test for this. Bug: 797354 Change-Id: I29a6e8a4ce2986ec3eb0c024496b00c4e1dd4b79 Reviewed-on: https://chromium-review.googlesource.com/1014482 Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#552148} [modify] https://crrev.com/54d6ad62258f03e21bf918d647686bd7b8aa4d15/components/BUILD.gn [modify] https://crrev.com/54d6ad62258f03e21bf918d647686bd7b8aa4d15/components/toolbar/BUILD.gn [add] https://crrev.com/54d6ad62258f03e21bf918d647686bd7b8aa4d15/components/toolbar/toolbar_model_delegate.cc [modify] https://crrev.com/54d6ad62258f03e21bf918d647686bd7b8aa4d15/components/toolbar/toolbar_model_delegate.h [modify] https://crrev.com/54d6ad62258f03e21bf918d647686bd7b8aa4d15/components/toolbar/toolbar_model_impl.cc [modify] https://crrev.com/54d6ad62258f03e21bf918d647686bd7b8aa4d15/components/toolbar/toolbar_model_impl.h [add] https://crrev.com/54d6ad62258f03e21bf918d647686bd7b8aa4d15/components/toolbar/toolbar_model_impl_unittest.cc
,
Apr 19 2018
Wow after ~33 CLs, we should be ready for primetime. I encourage us all to run this on our Linux, Windows, and ChromeOS machines to vet the behavior for primetime. And report any oddness please.
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/abf2ce0e99d7b92eeebed86018e186aec516d249 commit abf2ce0e99d7b92eeebed86018e186aec516d249 Author: Tommy C. Li <tommycli@chromium.org> Date: Wed May 02 00:42:46 2018 Omnibox UI Experiments: Steady State Elisions - fieldtrial_testing_config Android Turns on Steady State Elisions for Android in fieldtrial_testing_config.json. We're doing this to turn on Beta experiment for Android. Bug: 797354 Change-Id: Ia650ca67bfb13e6358c1677e08ad3db2134a6fb8 Reviewed-on: https://chromium-review.googlesource.com/1037628 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#555255} [modify] https://crrev.com/abf2ce0e99d7b92eeebed86018e186aec516d249/testing/variations/fieldtrial_testing_config.json
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90a71482c170466725cb4e217d8932cb8ac508e9 commit 90a71482c170466725cb4e217d8932cb8ac508e9 Author: Tommy C. Li <tommycli@chromium.org> Date: Wed May 02 23:58:27 2018 Omnibox UI Experiments: Steady State Elisions - Fix drag threshold bug. Previously, the drag threshold calculation had a bug. The last-click event was stored as a root_location, which was tested against the drag event's location relative to the View origin. This CL makes both the stored last-click and the current drag event use the root_location. Using root_location is most robust, since the View itself can move in response to edit-in-progress state. It also updates the API of textfield to make more explicit that the stored last click location is a root_location rather than relative to the position of the View. This CL also adds a test. Bug: 838830 , 797354 Change-Id: Iedff486a3c6e842bc5c87c6fd597e1faf7a2930d Reviewed-on: https://chromium-review.googlesource.com/1040347 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#555613} [modify] https://crrev.com/90a71482c170466725cb4e217d8932cb8ac508e9/chrome/browser/ui/views/omnibox/omnibox_view_views.cc [modify] https://crrev.com/90a71482c170466725cb4e217d8932cb8ac508e9/chrome/browser/ui/views/omnibox/omnibox_view_views.h [modify] https://crrev.com/90a71482c170466725cb4e217d8932cb8ac508e9/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc [modify] https://crrev.com/90a71482c170466725cb4e217d8932cb8ac508e9/ui/views/controls/textfield/textfield.cc [modify] https://crrev.com/90a71482c170466725cb4e217d8932cb8ac508e9/ui/views/controls/textfield/textfield.h [modify] https://crrev.com/90a71482c170466725cb4e217d8932cb8ac508e9/ui/views/selection_controller.cc [modify] https://crrev.com/90a71482c170466725cb4e217d8932cb8ac508e9/ui/views/selection_controller.h
,
May 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b84f1e3579e4f82974733d45fbe79c3ead2c19ce commit b84f1e3579e4f82974733d45fbe79c3ead2c19ce Author: Tommy C. Li <tommycli@chromium.org> Date: Fri May 04 18:00:25 2018 Omnibox UI Experiments: Steady State Elisions - Fix Cut to clipboard This CL improves the after-Cut text processing to reliably handle the Cut case when Steady State Elisions is on. Previously, the logic relied on IsSelectAll, which doesn't work correctly in the Cut case. Now it just compares the contents of the paste buffer vs. the current page's display URL. This also has the side benefit of simplifying the API. It also updates a test to explicitly check a Steady State Elisions case. Bug: 838159 , 797354 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iae3ee431051e2f7bbbf63a0b87e82b7f363213aa Reviewed-on: https://chromium-review.googlesource.com/1040912 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#556113} [modify] https://crrev.com/b84f1e3579e4f82974733d45fbe79c3ead2c19ce/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm [modify] https://crrev.com/b84f1e3579e4f82974733d45fbe79c3ead2c19ce/chrome/browser/ui/views/omnibox/omnibox_view_views.cc [modify] https://crrev.com/b84f1e3579e4f82974733d45fbe79c3ead2c19ce/components/omnibox/browser/omnibox_edit_model.cc [modify] https://crrev.com/b84f1e3579e4f82974733d45fbe79c3ead2c19ce/components/omnibox/browser/omnibox_edit_model.h [modify] https://crrev.com/b84f1e3579e4f82974733d45fbe79c3ead2c19ce/components/omnibox/browser/omnibox_edit_model_unittest.cc [modify] https://crrev.com/b84f1e3579e4f82974733d45fbe79c3ead2c19ce/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b614de5808201edc2755712bc41848b4bc101adb commit b614de5808201edc2755712bc41848b4bc101adb Author: Tommy C. Li <tommycli@chromium.org> Date: Wed May 16 02:10:09 2018 Omnibox UI Experiments: Steady State Elisions - Fix clear on ZeroSuggest There's a bug where if the user double-clicks fast on a segment of the elided URL, before the ZeroSuggest popup has a chance to popup, the Omnibox will be cleared when the popup comes up. This is because we were not properly updating the OmniboxEditModel's user_text_ string when we unelided the URL. This CL fixes that. Bug: 838545 , 797354 Change-Id: I55f69cd912243494f55b5e00a45d94b1ea01a221 Reviewed-on: https://chromium-review.googlesource.com/1056387 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#558927} [modify] https://crrev.com/b614de5808201edc2755712bc41848b4bc101adb/chrome/browser/ui/views/omnibox/omnibox_view_views.cc [modify] https://crrev.com/b614de5808201edc2755712bc41848b4bc101adb/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc [modify] https://crrev.com/b614de5808201edc2755712bc41848b4bc101adb/components/omnibox/browser/omnibox_edit_model.h
,
May 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e05e65805bc6f2c6f5707f68758ffaba16ab8af commit 6e05e65805bc6f2c6f5707f68758ffaba16ab8af Author: Tommy C. Li <tommycli@chromium.org> Date: Tue May 22 17:05:38 2018 Omnibox UI Experiments: Steady State Elisions - Refine drag-select host Currently, when the user selects a partial path from an elided URL, we leave out the elided portion. For instance, when the user drag selects: google.com/maps ^^^^^^^^^^ After unelision, the selection becomes: https://www.google.com/maps ^^^^^^^^^^ The user's intent here is to copy the whole first portion of the URL, so dropping the scheme and subdomain here is undesirable. This CL makes a guess when the user does a drag select on the whole first portion of the elided URL that the user wishes to copy the first portion of the unelided URL as well. It only applies this logic when the selected text looks like a URL, according to the OmniboxEditModel::IsPasteAndSearch logic, which we are renaming to OmniboxEditModel::ClassifiesAsSearch. TBR=ellyjones@chromium.org Bug: 843675 , 797354 Change-Id: I0ca9aed0fd9886b0442eb5a1e880b13601d82101 Reviewed-on: https://chromium-review.googlesource.com/1068120 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#560663} [modify] https://crrev.com/6e05e65805bc6f2c6f5707f68758ffaba16ab8af/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm [modify] https://crrev.com/6e05e65805bc6f2c6f5707f68758ffaba16ab8af/chrome/browser/ui/views/omnibox/omnibox_view_views.cc [modify] https://crrev.com/6e05e65805bc6f2c6f5707f68758ffaba16ab8af/chrome/browser/ui/views/omnibox/omnibox_view_views.h [modify] https://crrev.com/6e05e65805bc6f2c6f5707f68758ffaba16ab8af/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc [modify] https://crrev.com/6e05e65805bc6f2c6f5707f68758ffaba16ab8af/components/omnibox/browser/omnibox_edit_model.cc [modify] https://crrev.com/6e05e65805bc6f2c6f5707f68758ffaba16ab8af/components/omnibox/browser/omnibox_edit_model.h
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f39ea53c83e5278d93e4bdbe106271737f4be69a commit f39ea53c83e5278d93e4bdbe106271737f4be69a Author: Tommy C. Li <tommycli@chromium.org> Date: Mon Jun 04 21:52:40 2018 Omnibox UI Experiments: Steady State Elisions - Fix drag threshold bug. Previously, the drag threshold calculation had a bug. The last-click event was stored as a root_location, which was tested against the drag event's location relative to the View origin. This CL makes both the stored last-click and the current drag event use the root_location. Using root_location is most robust, since the View itself can move in response to edit-in-progress state. It also updates the API of textfield to make more explicit that the stored last click location is a root_location rather than relative to the position of the View. This CL also adds a test. TBR=tommycli@chromium.org (cherry picked from commit 90a71482c170466725cb4e217d8932cb8ac508e9) Bug: 838830 , 797354 Change-Id: Iedff486a3c6e842bc5c87c6fd597e1faf7a2930d Reviewed-on: https://chromium-review.googlesource.com/1040347 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#555613} Reviewed-on: https://chromium-review.googlesource.com/1086158 Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#740} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/f39ea53c83e5278d93e4bdbe106271737f4be69a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc [modify] https://crrev.com/f39ea53c83e5278d93e4bdbe106271737f4be69a/chrome/browser/ui/views/omnibox/omnibox_view_views.h [modify] https://crrev.com/f39ea53c83e5278d93e4bdbe106271737f4be69a/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc [modify] https://crrev.com/f39ea53c83e5278d93e4bdbe106271737f4be69a/ui/views/controls/textfield/textfield.cc [modify] https://crrev.com/f39ea53c83e5278d93e4bdbe106271737f4be69a/ui/views/controls/textfield/textfield.h [modify] https://crrev.com/f39ea53c83e5278d93e4bdbe106271737f4be69a/ui/views/selection_controller.cc [modify] https://crrev.com/f39ea53c83e5278d93e4bdbe106271737f4be69a/ui/views/selection_controller.h
,
Jun 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2638e9ef5a59d90d9630c5d8f9a2b6a8211c3042 commit 2638e9ef5a59d90d9630c5d8f9a2b6a8211c3042 Author: Tommy C. Li <tommycli@chromium.org> Date: Sat Jun 09 04:26:08 2018 Omnibox UI Experiments: Steady State Elisions - Fix intranet hosts bug Previously the URL Formatter code would misbehave for intranet hosts while trying to trim trivial subdomains. This CL fixes the issue and adds a unit test. Bug: 850751, 797354 Change-Id: Ia60782e6ce1b3b8a7261b26f7e1fe6b48d2577fd Reviewed-on: https://chromium-review.googlesource.com/1093743 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#565856} [modify] https://crrev.com/2638e9ef5a59d90d9630c5d8f9a2b6a8211c3042/components/url_formatter/url_formatter.cc [modify] https://crrev.com/2638e9ef5a59d90d9630c5d8f9a2b6a8211c3042/components/url_formatter/url_formatter_unittest.cc
,
Jun 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06c7ab83628a4faf12cfc1ab91438afeb4a99d66 commit 06c7ab83628a4faf12cfc1ab91438afeb4a99d66 Author: Tommy C. Li <tommycli@chromium.org> Date: Tue Jun 12 22:00:29 2018 [Merge to M68] Omnibox UI Experiments: Steady State Elisions - Fix intranet hosts bug Previously the URL Formatter code would misbehave for intranet hosts while trying to trim trivial subdomains. This CL fixes the issue and adds a unit test. Bug: 850751, 797354 Change-Id: Ia60782e6ce1b3b8a7261b26f7e1fe6b48d2577fd Reviewed-on: https://chromium-review.googlesource.com/1093743 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#565856}(cherry picked from commit 2638e9ef5a59d90d9630c5d8f9a2b6a8211c3042) Reviewed-on: https://chromium-review.googlesource.com/1097899 Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#325} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/06c7ab83628a4faf12cfc1ab91438afeb4a99d66/components/url_formatter/url_formatter.cc [modify] https://crrev.com/06c7ab83628a4faf12cfc1ab91438afeb4a99d66/components/url_formatter/url_formatter_unittest.cc |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by jdonnelly@chromium.org
, Dec 22 2017