New issue
Advanced search Search tips

Issue 797349 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR



Sign in to add a comment

VR: VSync isn't paused when entering WebVR from VR browsing.

Project Member Reported by mthiesse@chromium.org, Dec 22 2017

Issue description

Unfortunately, this has been present for a while now, and is probably too late to fix for M64 given it's a performance bug that isn't a regression.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2754588700c726d98d9b1eae773d7d1f81b6c7ea

commit 2754588700c726d98d9b1eae773d7d1f81b6c7ea
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Fri Dec 22 20:52:12 2017

VR: Pause VSync immediately if control container is already hidden

There's a bug where if the control container is already hidden, we fail
to pause VSync when entering WebVR. This happens when we enter WebVR
from VR browsing.

This CL fixes that hackily by just immediately pausing VSync if we're
coming from VR browsing. This will be fixed properly with the fallback
UI path. See  crbug.com/793430 

Bug:  797349 
Change-Id: I8d35a0c38caa7aaf285c140bef368883aaa0765b
Reviewed-on: https://chromium-review.googlesource.com/843237
Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526058}
[modify] https://crrev.com/2754588700c726d98d9b1eae773d7d1f81b6c7ea/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

Status: Fixed (was: Started)
Cc: klausw@chromium.org
 Issue 795868  has been merged into this issue.
Labels: Test-Complete
Components: Internals>XR
Components: Blink>WebXR

Sign in to add a comment