chromeos pfq bots failed for compiling issue caused by a cl related to Select-to-Speak change |
|||
Issue descriptionAll chromeos-pfq bots failed for building package and the informational bots failed to. Tracing back, here is the first informational build failure. https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/lumpy-tot-chrome-pfq-informational/builds/26043 The build failure log shows. FAILED: obj/chrome/browser/resources/chromeos/select_to_speak/select_to_speak_copied_files_copy.stamp One of the cl landed with the build looks related and suspicious: https://chromium-review.googlesource.com/c/chromium/src/+/834206
,
Dec 22 2017
Revert here: https://chromium-review.googlesource.com/c/chromium/src/+/843206 Not sure why it was failing... something about copying the JS resources around.
,
Dec 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2af7b4b8f28c2a95d6e545ac5a04d75f226034bf commit 2af7b4b8f28c2a95d6e545ac5a04d75f226034bf Author: Katie Dektar <katie@chromium.org> Date: Fri Dec 22 19:12:08 2017 Revert "Use ChromeVox utils in Select-to-Speak to support future changes." This reverts commit 15df088c255c7c5b7fdd6d650b0082a0319ba227. Reason for revert: Breaks PFQ trybots Bug:797339 Original change's description: > Use ChromeVox utils in Select-to-Speak to support future changes. > > Includes a closure_shim.js that allows Select-to-Speak to use these > files without closure. > > This is temporary, eventually ChromeVox and Select-to-Speak should > both pull these utility files from one shared location. > > Bug: 713303 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I0bb93e5989e2ea83d89a500b6d92134031e78f07 > Reviewed-on: https://chromium-review.googlesource.com/834206 > Commit-Queue: Katie Dektar <katie@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#525820} TBR=dmazzoni@chromium.org,dtseng@chromium.org,katie@chromium.org Change-Id: I108428209aec17d0c88e0feee21837da7eb4d769 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 797339 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/843206 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#526038} [modify] https://crrev.com/2af7b4b8f28c2a95d6e545ac5a04d75f226034bf/chrome/browser/resources/chromeos/chromevox/chromevox/background/background.js [modify] https://crrev.com/2af7b4b8f28c2a95d6e545ac5a04d75f226034bf/chrome/browser/resources/chromeos/chromevox/common/chromevox.js [modify] https://crrev.com/2af7b4b8f28c2a95d6e545ac5a04d75f226034bf/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js [modify] https://crrev.com/2af7b4b8f28c2a95d6e545ac5a04d75f226034bf/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js [modify] https://crrev.com/2af7b4b8f28c2a95d6e545ac5a04d75f226034bf/chrome/browser/resources/chromeos/chromevox/cvox2/background/constants.js [modify] https://crrev.com/2af7b4b8f28c2a95d6e545ac5a04d75f226034bf/chrome/browser/resources/chromeos/select_to_speak/BUILD.gn [delete] https://crrev.com/3cf32744d21a6f64e491c167cb995e72fe0d67bc/chrome/browser/resources/chromeos/select_to_speak/closure_shim.js [modify] https://crrev.com/2af7b4b8f28c2a95d6e545ac5a04d75f226034bf/chrome/browser/resources/chromeos/select_to_speak/compiled_resources2.gyp [modify] https://crrev.com/2af7b4b8f28c2a95d6e545ac5a04d75f226034bf/chrome/browser/resources/chromeos/select_to_speak/manifest.json.jinja2
,
Dec 22 2017
,
Dec 22 2017
The new build with the reverted cl has succeeded on the informational bot ☺ https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/lumpy-tot-chrome-pfq-informational/builds/26084 |
|||
►
Sign in to add a comment |
|||
Comment 1 by jen...@chromium.org
, Dec 22 2017