New issue
Advanced search Search tips

Issue 797337 link

Starred by 2 users
Status: Assigned
Owner:
sjg@chromium.org
Cc:
vapier@chromium.org
hungte@chromium.org
adurbin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

/sys/firmware/vpd should cope with updates

Project Member Reported by sjg@google.com, Dec 22 2017 
At present 'vpd -s' does not update the kernel driver version so any change to the VPD is not noticed until a reboot.

This means that things like cros_config may return the wrong information for whitelabels, or models which don't rely entirely on a SKU ID.

We should fix this.

Comment 1 by hungte@google.com, Dec 23 2017 

I doubt if we'd ever want to fix this.

1. cros_config should only read RO VPD. And RO VPDs should be never changed for end users (can't be updated by -s). So the only problem you'll see is in factory.

2. A reboot would simply solve the problem.

3. models should not rely on VPD. only WL can.

4. RO VPDs exported by /sys, due to regulatory & security requirements, were expected to be "never changed" since system boots. If you change that behavior, we may bump into  more problems.

Comment 2 by hungte@google.com, Dec 23 2017 

Particular for firmware updater, it used to look directly from live system VPD (since update does need to read firmware contents) so there were no problems.

If you think the mosys -> vpd_get_value need to be updated, I'd rather simply let updater read and trust the entries again, instead of using mosys.

Comment 3 by benhenry@chromium.org, Aug 1

Status: Assigned (was: Untriaged)
►

Sign in to add a comment