New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 797320 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Sep 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Abrt in blink::LayoutTable::UpdateLayout

Project Member Reported by ClusterFuzz, Dec 22 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6503044509597696

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_msan_content_shell_drt
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x03e900000001
Crash State:
  blink::LayoutTable::UpdateLayout
  blink::LayoutBlockFlow::PositionAndLayoutOnceIfNeeded
  blink::LayoutBlockFlow::LayoutBlockChild
  
Sanitizer: memory (MSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=518240:518474

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6503044509597696

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Dec 22 2017

Components: Blink>Layout
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Cc: joysyu@google.com kkaluri@chromium.org
Labels: M-64 Test-Predator-Wrong
Owner: dgro...@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possible suspects.
Using Code Search for the file, "LayoutTable.cpp" assigning to the concern owner who might be related.

Suspect CL: https://chromium.googlesource.com/chromium/src/+/b629f7a13e2d350f42c38f6b8ca7d95479b0afa6

dgrogan@ -- Could you please look into the issue, kindly assign it to concern owner.


Thank You.
Cc: -joysyu@google.com -kkaluri@chromium.org dgro...@chromium.org
Components: -Blink>Layout Blink>Layout>Table
Labels: -Pri-1 Needs-Bisect Pri-2
Owner: kkaluri@chromium.org
kkaluri, please confirm the suspect CL from comment 2.

You are probably right but clusterfuzz claims a different regression range. One of you is wrong. Please determine which one.

Assign to me when finished.
Cc: mmoroz@chromium.org kkaluri@chromium.org manoranj...@chromium.org
Owner: ----
Status: Unconfirmed (was: Assigned)
dgrogan@ -- As per the GIT Blame results for the file "LayoutTable.cpp", joysyu@ was the actual suspect, Since he is not a chromium user assigned to you as you are the one of the reviewer for suspect file.

Since this is a Needs-Bisect issue, CC'ing the mmoroz@ for further triage.

Cc: szager@chromium.org
Looking through the regression range, the most relevant change seems to be https://chromium.googlesource.com/chromium/src/+/08b0819307cc7d1a973e7d938ff156527519c791

Stefan, could you please take a look?

Comment 6 by e...@chromium.org, Jan 4 2018

Owner: szager@chromium.org
Status: Assigned (was: Unconfirmed)
Owner: dgro...@chromium.org
My change didn't do this; it's a no-op unless running with the --root-layer-scrolls flag.

I'm pretty sure the CL identified in comment #2 is the culprit, re-assigning to dgrogan.
Cc: -szager@chromium.org
Owner: kkaluri@chromium.org
kklarui, please see my request in comment 3 that you confirm the suspect CL.

That's usually what happens when the Needs-Bisect label is applied to a bug. Why did you instead pass to mmoroz?

Note that your line about "git blame" in comment 4 does not, at all, address the request. I am not sure why you included that.
Cc: -dgro...@chromium.org
Labels: -Needs-Bisect
Owner: dgro...@chromium.org
dgrogan@, Sorry for not assigning you back after c#3. We are still refining full fledged triaging process especially when predator is identifying wrong suspect and most of the time mmoroz@ (Who is part of developing CF framework) is helping us to deal these kind of situations. And also the actual CL owner (joysyu@) is not active at the moment, it's little tricky to pick specific reviewer of the change also.

Thank you for understanding!
Project Member

Comment 10 by ClusterFuzz, Mar 29 2018

Labels: OS-Mac
Project Member

Comment 11 by ClusterFuzz, May 16 2018

ClusterFuzz has detected this issue as fixed in range 558997:559001.

Detailed report: https://clusterfuzz.com/testcase?key=6503044509597696

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_msan_content_shell_drt
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  i < size() in Vector.h
  blink::LayoutTable::UpdateLayout
  blink::LayoutBlockFlow::PositionAndLayoutOnceIfNeeded
  
Sanitizer: memory (MSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=518240:518474
Fixed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=558997:559001

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6503044509597696

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 12 by ClusterFuzz, May 16 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6503044509597696 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Status: Assigned (was: Verified)
Bulk edit: reopening CF issues likely closed incorrectly due to https://chromium.googlesource.com/chromium/src/+/cd3ebc4c69d7c01770f37f34aad623aa4ab2b128
Project Member

Comment 14 by ClusterFuzz, May 17 2018

Labels: -Reproducible Unreproducible
ClusterFuzz testcase 6503044509597696 appears to be flaky, updating reproducibility label.
Project Member

Comment 15 by ClusterFuzz, Sep 5

ClusterFuzz has detected this issue as fixed in range 558997:559001.

Detailed report: https://clusterfuzz.com/testcase?key=6503044509597696

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_msan_content_shell_drt
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  i < size() in Vector.h
  blink::LayoutTable::UpdateLayout
  blink::LayoutBlockFlow::PositionAndLayoutOnceIfNeeded
  
Sanitizer: memory (MSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=518240:518474
Fixed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=558997:559001

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6503044509597696

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Status: WontFix (was: Assigned)

Sign in to add a comment