New issue
Advanced search Search tips

Issue 797289 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 3
Type: Task


Show other hotlists

Hotlists containing this issue:
Autofill-Fixit


Sign in to add a comment

[autofill] Replace 'naked' new allocations with std::make_unique

Project Member Reported by rogerm@chromium.org, Dec 22 2017

Issue description

Replace all occurrences of new Foo with std::make_unique<Foo>
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4b09dbcaa60bd60f930fce9ea3e8ad964741489

commit f4b09dbcaa60bd60f930fce9ea3e8ad964741489
Author: Roger McFarlane <rogerm@chromium.org>
Date: Fri Dec 22 22:56:50 2017

[autofill] Replace naked new with std::make_unique

Part 1 of many.

BUG=797289
R=sebsg@chromium.org

Change-Id: Ic7f85eddbff9555a5cc51d73d1148906da28129a
Reviewed-on: https://chromium-review.googlesource.com/843084
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526079}
[modify] https://crrev.com/f4b09dbcaa60bd60f930fce9ea3e8ad964741489/components/autofill/core/browser/address_i18n.cc
[modify] https://crrev.com/f4b09dbcaa60bd60f930fce9ea3e8ad964741489/components/autofill/core/browser/autocomplete_history_manager_unittest.cc
[modify] https://crrev.com/f4b09dbcaa60bd60f930fce9ea3e8ad964741489/components/autofill/core/browser/autofill_address_util.cc
[modify] https://crrev.com/f4b09dbcaa60bd60f930fce9ea3e8ad964741489/components/autofill/core/browser/autofill_assistant.cc
[modify] https://crrev.com/f4b09dbcaa60bd60f930fce9ea3e8ad964741489/components/autofill/core/browser/autofill_download_manager_unittest.cc
[modify] https://crrev.com/f4b09dbcaa60bd60f930fce9ea3e8ad964741489/components/autofill/core/browser/autofill_external_delegate_unittest.cc
[modify] https://crrev.com/f4b09dbcaa60bd60f930fce9ea3e8ad964741489/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/f4b09dbcaa60bd60f930fce9ea3e8ad964741489/components/autofill/core/browser/autofill_wallet_data_type_controller_unittest.cc
[modify] https://crrev.com/f4b09dbcaa60bd60f930fce9ea3e8ad964741489/components/autofill/core/browser/country_combobox_model_unittest.cc
[modify] https://crrev.com/f4b09dbcaa60bd60f930fce9ea3e8ad964741489/components/autofill/core/browser/country_names.cc
[modify] https://crrev.com/f4b09dbcaa60bd60f930fce9ea3e8ad964741489/components/autofill/core/browser/credit_card_field.cc
[modify] https://crrev.com/f4b09dbcaa60bd60f930fce9ea3e8ad964741489/components/autofill/core/browser/form_data_importer.cc
[modify] https://crrev.com/f4b09dbcaa60bd60f930fce9ea3e8ad964741489/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/f4b09dbcaa60bd60f930fce9ea3e8ad964741489/components/autofill/core/common/autofill_clock.cc
[modify] https://crrev.com/f4b09dbcaa60bd60f930fce9ea3e8ad964741489/components/autofill/core/common/autofill_regexes.cc

Comment 2 by ma...@chromium.org, May 1 2018

Status: Untriaged (was: Started)
Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".

Sign in to add a comment