Search by image doesn't respect orientation in exif
Reported by
lo...@yandex-team.ru,
Dec 22 2017
|
|||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3301.0 Safari/537.36 Example URL: http://avatars.mds.yandex.net/get-toloka_images/474755/FoNSev_ZqXW1k/orig Steps to reproduce the problem: 1. Open http://avatars.mds.yandex.net/get-toloka_images/474755/FoNSev_ZqXW1k/orig 2. Try to search by image in Google. 3. Image in SERP has wrong orientation. What is the expected behavior? Correct orientation. What went wrong? Image in SERP has wrong orientation. Does it occur on multiple sites: Yes Is it a problem with a plugin? No Did this work before? No Does this work in other browsers? N/A Chrome version: 65.0.3301.0 Channel: dev OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version:
,
Dec 22 2017
,
Dec 25 2017
The standard is to not rotate the image unless the image-orientation property is used, but we don't support that yet.
,
Dec 27 2017
@schenney: are you saying https://chromium-review.googlesource.com/c/chromium/src/+/842864 is wrong?
,
Jan 2 2018
No, that patch is fine. It seems I misunderstood the scope of the problem. So the patch can certainly land.
,
Jan 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/497648e7ba1704370563f0c8dc31665f398cb376 commit 497648e7ba1704370563f0c8dc31665f398cb376 Author: Vadim Petrov <lof84@yandex-team.ru> Date: Thu Jan 04 13:25:42 2018 Respect EXIF orientation in search by image Bug: 797280 Change-Id: Ie05b919e7e5f1aab2ebfc54c5f1dca50b4a18a23 Reviewed-on: https://chromium-review.googlesource.com/842864 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Stephen Chenney <schenney@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Vadim Petrov <lof84@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#526972} [modify] https://crrev.com/497648e7ba1704370563f0c8dc31665f398cb376/chrome/renderer/chrome_render_frame_observer.cc [modify] https://crrev.com/497648e7ba1704370563f0c8dc31665f398cb376/third_party/WebKit/Source/core/exported/WebElement.cpp [modify] https://crrev.com/497648e7ba1704370563f0c8dc31665f398cb376/third_party/WebKit/Source/core/exported/WebFrameTest.cpp [modify] https://crrev.com/497648e7ba1704370563f0c8dc31665f398cb376/third_party/WebKit/Source/platform/exported/WebImage.cpp [modify] https://crrev.com/497648e7ba1704370563f0c8dc31665f398cb376/third_party/WebKit/public/platform/WebImage.h
,
Jan 19 2018
I think it is fixed.
,
Jan 19 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 Deleted