On themed local NTP, Doodle flashes before being replaced by notifier |
|||
Issue descriptionPreconditions: - Local NTP enabled. - Theme installed (with non-white background). - There's a Doodle (real one or via chrome://flags/#use-ddljson-api). Steps: Open NTP, see Doodle flash briefly before being replaced by the notifier. The remote NTP does not have this problem.
,
Jan 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/170b81f686098f6238fc8f2c2e5b9c535ead9f1e commit 170b81f686098f6238fc8f2c2e5b9c535ead9f1e Author: Marc Treib <treib@chromium.org> Date: Wed Jan 17 10:41:47 2018 Local NTP: Apply theme info earlier to avoid Doodle flashes Before this CL, the local NTP applied theme info (css classes etc) only after the MV iframe loaded. This could cause a Doodle to briefly show up before it was replaced by the notifier. This CL applies the theme classes before loading the Doodle to avoid this problem. Bug: 797260 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I89e0b49c7d653290c6d44da3d9882b95a9ab813f Reviewed-on: https://chromium-review.googlesource.com/868658 Reviewed-by: Chris Pickel <sfiera@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#529695} [modify] https://crrev.com/170b81f686098f6238fc8f2c2e5b9c535ead9f1e/chrome/browser/resources/local_ntp/local_ntp.js
,
Jan 17 2018
,
Jan 18 2018
Verified the fix on Mac 10.12.6, Win-10 and Ubuntu 14.04 using latest chrome version #65.0.3324.0 as per the comment #0. Attaching screen cast for reference. Observed that on themed local NTP, Doodle did not flash briefly before being replaced by notifier. Theme info was applied earlier. Hence, the fix is working as expected. Adding the verified labels. Thanks...!! |
|||
►
Sign in to add a comment |
|||
Comment 1 by treib@chromium.org
, Jan 16 2018Owner: treib@chromium.org
Status: Started (was: Assigned)