New issue
Advanced search Search tips

Issue 797239 link

Starred by 1 user
Status: Verified
Owner:
gambard@chromium.org
Closed: Jan 2018
Cc:
stkhapugin@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Omnibox Popup background is the wrong color on incognito

Project Member Reported by gambard@chromium.org, Dec 22 2017 
What steps will reproduce the problem?
(1) Open an incognito page
(2) Type in the omnibox

What is the expected result?
The suggestions should have a dark background.

What happens instead?
They have a white one.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b8fee422e45fc7c5692f5e54f4cfe2857c11f80

commit 1b8fee422e45fc7c5692f5e54f4cfe2857c11f80
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Dec 22 21:46:07 2017

Set OmniboxPopup incognito property before view creation

This CL sets the incognito property of the OmniboxPopupViewController
before the view is created when passed to the mediator as the property
is used in viewDidLoad.

Bug:  797239 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I0db9d1754ea32d6d1a6c7cde5d2638f187da5fd3
Reviewed-on: https://chromium-review.googlesource.com/842723
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526068}
[modify] https://crrev.com/1b8fee422e45fc7c5692f5e54f4cfe2857c11f80/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_coordinator.mm

Comment 2 by gambard@chromium.org, Jan 2 2018

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f342e7caf53a92632cebc0dbae2edb594dd5271a

commit f342e7caf53a92632cebc0dbae2edb594dd5271a
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Jan 03 08:35:56 2018

Check OmniboxPopup is not loaded when setting incognito style

This CL adds a DCHECK to the omnibox presenter view controller to
check that the incognito style is set before the view is loaded.

Bug:  797239 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I1bf56e1f4f16c8b4cc0dbbc35267dbb37f80ebb2
Reviewed-on: https://chromium-review.googlesource.com/846989
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526650}
[modify] https://crrev.com/f342e7caf53a92632cebc0dbae2edb594dd5271a/ios/chrome/browser/ui/omnibox/omnibox_popup_view_controller.mm

Comment 4 by shbarezer@chromium.org, Jan 9 2018

Status: Verified (was: Fixed)
Verified in 65.0.3316.0 canary, iPhone X iOS 11.2, iPhone 7 iOS11,
Looks good.

https://drive.google.com/file/d/1oF9Ts7xbuWRLDlj5vAQCApMfEALGMCbZ/view
►

Sign in to add a comment