New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 797186 link

Starred by 3 users
Status: Fixed
Owner:
█ ymalik@chromium.org
(currently inactive on Chromium)
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: Introduce the notion of UI modes

Project Member Reported by ymalik@chromium.org, Dec 22 2017 
Currently we have a bunch of state information store as bits in our model which our views are bound to (see chrome/vr/browser/model/model.h).

This makes state changes difficult. For example, going from default browsing mode to voice search, then hitting back should go back into default browsing mode, but going from default browsing mode -> omnibox editing mode -> voice search, then hitting back should go into omnibox editing mode.

The notion of a ui modes should make this easier and clean up our bindings as well.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a10273e8f7d519b07c5e350eb4f493fae39c8ee

commit 1a10273e8f7d519b07c5e350eb4f493fae39c8ee
Author: Yash Malik <ymalik@google.com>
Date: Fri Dec 22 23:27:01 2017

VR: Introduce the notion of UI modes.

The UI can only be in one mode at a given time. All mode changes are triggered
by BrowserUiInterface.

This CL updates the bindings to be tied to UI modes rather than particular bits
on the model. It also adds the necessary plumbing to route events from the UI
the the browser and back (for voice search and omnibox editing mode).

Bug:  797186 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0639aeaf8b936e833c47e5e9355e1682f9bcb078
Reviewed-on: https://chromium-review.googlesource.com/842942
Commit-Queue: Yash Malik <ymalik@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526089}
[modify] https://crrev.com/1a10273e8f7d519b07c5e350eb4f493fae39c8ee/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/1a10273e8f7d519b07c5e350eb4f493fae39c8ee/chrome/browser/vr/elements/ui_element_name.cc
[modify] https://crrev.com/1a10273e8f7d519b07c5e350eb4f493fae39c8ee/chrome/browser/vr/elements/ui_element_name.h
[modify] https://crrev.com/1a10273e8f7d519b07c5e350eb4f493fae39c8ee/chrome/browser/vr/mode.h
[modify] https://crrev.com/1a10273e8f7d519b07c5e350eb4f493fae39c8ee/chrome/browser/vr/model/model.cc
[modify] https://crrev.com/1a10273e8f7d519b07c5e350eb4f493fae39c8ee/chrome/browser/vr/model/model.h
[modify] https://crrev.com/1a10273e8f7d519b07c5e350eb4f493fae39c8ee/chrome/browser/vr/model/speech_recognition_model.h
[add] https://crrev.com/1a10273e8f7d519b07c5e350eb4f493fae39c8ee/chrome/browser/vr/model/ui_mode.h
[modify] https://crrev.com/1a10273e8f7d519b07c5e350eb4f493fae39c8ee/chrome/browser/vr/model/web_vr_model.h
[modify] https://crrev.com/1a10273e8f7d519b07c5e350eb4f493fae39c8ee/chrome/browser/vr/test/mock_ui_browser_interface.h
[modify] https://crrev.com/1a10273e8f7d519b07c5e350eb4f493fae39c8ee/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/1a10273e8f7d519b07c5e350eb4f493fae39c8ee/chrome/browser/vr/ui.cc
[modify] https://crrev.com/1a10273e8f7d519b07c5e350eb4f493fae39c8ee/chrome/browser/vr/ui.h
[modify] https://crrev.com/1a10273e8f7d519b07c5e350eb4f493fae39c8ee/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/1a10273e8f7d519b07c5e350eb4f493fae39c8ee/chrome/browser/vr/ui_scene_creator.h
[modify] https://crrev.com/1a10273e8f7d519b07c5e350eb4f493fae39c8ee/chrome/browser/vr/ui_unittest.cc

Comment 2 by ymalik@chromium.org, Dec 27 2017

Status: Fixed (was: Started)

Comment 3 by dougman@chromium.org, Feb 7 2018

Labels: Test-Complete
►

Sign in to add a comment