New issue
Advanced search Search tips

Issue 797184 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in SkMatrix::postConcat

Project Member Reported by ClusterFuzz, Dec 22 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4658978423570432

Fuzzer: inferno_canvas_wrecker
Job Type: linux_msan_chrome
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  SkMatrix::postConcat
  TwoPointConicalEffect::Data::Data
  Gr2PtConicalGradientEffect::Make
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_chrome&range=525781:525806

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4658978423570432

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Dec 22 2017

Labels: M-65
Project Member

Comment 2 by sheriffbot@chromium.org, Dec 22 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Dec 22 2017

Labels: Pri-1
Cc: egdaniel@google.com
Components: Internals>Skia
Owner: liyuqian@google.com
Status: Assigned (was: Untriaged)
https://skia.googlesource.com/skia/+/915817b940b05882d85c220d2b2dc18ef184a6b4 touched the affected file.
Project Member

Comment 5 by ClusterFuzz, Dec 24 2017

Labels: ClusterFuzz-Top-Crash ReleaseBlock-Beta
Testcase 4658978423570432 is a top crash on ClusterFuzz for linux platform. Please prioritize fixing this crash.

Marking this crash as a Beta release blocker.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 28 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/fa8bc34f2884655c7699ae60e4c6536ac86ddecb

commit fa8bc34f2884655c7699ae60e4c6536ac86ddecb
Author: Yuqian Li <liyuqian@google.com>
Date: Thu Dec 28 15:23:00 2017

Fix bug of a + (b - a) == 0 for small positive b and huge a (e.g., 1e18)

I am unable to make a MSAN build to work locally. But I think that this
should fix the problem by looking at the gradient of the fuzzer:

Z.createRadialGradient(1.94159387872, 138.616510533, 2.22085316544e+18,
		       10.3399911492, 176.149195942, 153.078363987);

Bug:  chromium:797184 
Change-Id: I16c571a378742c4ef50afe9c5baba791da7fc208
Reviewed-on: https://skia-review.googlesource.com/89541
Commit-Queue: Yuqian Li <liyuqian@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>

[modify] https://crrev.com/fa8bc34f2884655c7699ae60e4c6536ac86ddecb/src/shaders/gradients/SkTwoPointConicalGradient_gpu.cpp

Project Member

Comment 7 by ClusterFuzz, Dec 29 2017

ClusterFuzz has detected this issue as fixed in range 526305:526310.

Detailed report: https://clusterfuzz.com/testcase?key=4658978423570432

Fuzzer: inferno_canvas_wrecker
Job Type: linux_msan_chrome
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  SkMatrix::postConcat
  TwoPointConicalEffect::Data::Data
  Gr2PtConicalGradientEffect::Make
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_chrome&range=525781:525806
Fixed: https://clusterfuzz.com/revisions?job=linux_msan_chrome&range=526305:526310

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4658978423570432

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Dec 29 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4658978423570432 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 9 by sheriffbot@chromium.org, Dec 29 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Beta
Labels: -ReleaseBlock-Stable
Project Member

Comment 12 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Head Security_Impact-Stable
Project Member

Comment 13 by sheriffbot@chromium.org, Apr 6 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment