Pass the RemotingStopReason to RendererController |
||
Issue descriptionThe RemotingStopReason is currently not passed down to RendererController. The stop trigger is always ROUTE_TERMINATED no matter whether remoting session is stopped from MR dialog, or user changing setting, or any data sending errors occurred in the browser.
,
Dec 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/962421382a640316f648def9d25674bd09b89929 commit 962421382a640316f648def9d25674bd09b89929 Author: Xiangjun Zhang <xjz@chromium.org> Date: Sat Dec 23 03:51:38 2017 Pass the RemotingStopReason to RendererController. Currently the RemotingStopReason is not passed to RendererController. The stop trigger is always ROUTE_TERMINATED if the remoting session is not stopped from the renderer. This CL converted the RemotingStopReason to the corresponding StopTrigger so that the stop reason can be recorded by the UMA stats and also can provide the correct text to be shown in the toast when switching to mirroring in a coming CL. Bug: 797176 Change-Id: Ib4813de4bccbe473e7eca462c422184795b15bb9 Reviewed-on: https://chromium-review.googlesource.com/841665 Reviewed-by: Yuri Wiitala <miu@chromium.org> Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#526134} [modify] https://crrev.com/962421382a640316f648def9d25674bd09b89929/media/remoting/remoting_cdm_controller.cc [modify] https://crrev.com/962421382a640316f648def9d25674bd09b89929/media/remoting/renderer_controller.cc [modify] https://crrev.com/962421382a640316f648def9d25674bd09b89929/media/remoting/renderer_controller_unittest.cc [modify] https://crrev.com/962421382a640316f648def9d25674bd09b89929/media/remoting/shared_session.cc [modify] https://crrev.com/962421382a640316f648def9d25674bd09b89929/media/remoting/shared_session.h [modify] https://crrev.com/962421382a640316f648def9d25674bd09b89929/media/remoting/triggers.h
,
Jan 3 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by x...@chromium.org
, Dec 22 2017