New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 797176 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 797327



Sign in to add a comment

Pass the RemotingStopReason to RendererController

Project Member Reported by x...@chromium.org, Dec 22 2017

Issue description

The RemotingStopReason is currently not passed down to RendererController. The stop trigger is always ROUTE_TERMINATED no matter whether remoting session is stopped from MR dialog, or user changing setting, or any data sending errors occurred in the browser.
 

Comment 1 by x...@chromium.org, Dec 22 2017

Blocking: 797327
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/962421382a640316f648def9d25674bd09b89929

commit 962421382a640316f648def9d25674bd09b89929
Author: Xiangjun Zhang <xjz@chromium.org>
Date: Sat Dec 23 03:51:38 2017

Pass the RemotingStopReason to RendererController.

Currently the RemotingStopReason is not passed to RendererController.
The stop trigger is always ROUTE_TERMINATED if the remoting session is
not stopped from the renderer. This CL converted the RemotingStopReason
to the corresponding StopTrigger so that the stop reason can be
recorded by the UMA stats and also can provide the correct text to be
shown in the toast when switching to mirroring in a coming CL.

Bug:  797176 
Change-Id: Ib4813de4bccbe473e7eca462c422184795b15bb9
Reviewed-on: https://chromium-review.googlesource.com/841665
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526134}
[modify] https://crrev.com/962421382a640316f648def9d25674bd09b89929/media/remoting/remoting_cdm_controller.cc
[modify] https://crrev.com/962421382a640316f648def9d25674bd09b89929/media/remoting/renderer_controller.cc
[modify] https://crrev.com/962421382a640316f648def9d25674bd09b89929/media/remoting/renderer_controller_unittest.cc
[modify] https://crrev.com/962421382a640316f648def9d25674bd09b89929/media/remoting/shared_session.cc
[modify] https://crrev.com/962421382a640316f648def9d25674bd09b89929/media/remoting/shared_session.h
[modify] https://crrev.com/962421382a640316f648def9d25674bd09b89929/media/remoting/triggers.h

Comment 3 by x...@chromium.org, Jan 3 2018

Status: Fixed (was: Started)

Sign in to add a comment