New issue
Advanced search Search tips

Issue 797175 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

"org.chromium.content.browser.ScreenOrientationListenerTest#testBasicValues" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Dec 22 2017

Issue description

"org.chromium.content.browser.ScreenOrientationListenerTest#testBasicValues" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 10 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVQsSBUZsYWtlIkpvcmcuY2hyb21pdW0uY29udGVudC5icm93c2VyLlNjcmVlbk9yaWVudGF0aW9uTGlzdGVuZXJUZXN0I3Rlc3RCYXNpY1ZhbHVlcww.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

This flaky test/step was previously tracked in  issue 672345 .
 
Labels: OS-Android
Owner: mlamouri@chromium.org
Status: Assigned (was: Untriaged)
Disabling these tests in https://chromium-review.googlesource.com/c/chromium/src/+/845279
Labels: -Sheriff-Chromium
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b2b0666dc524ad222a5feb78b4311d2033283a8

commit 0b2b0666dc524ad222a5feb78b4311d2033283a8
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Thu Dec 28 01:05:04 2017

Disable flaky ScreenOrientation tests.

Bug:  797175 
Change-Id: Ic1650dd22a8764a1baef331f7801c0c97aa4c3b5
TBR: mlamouri@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/845279
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526261}
[modify] https://crrev.com/0b2b0666dc524ad222a5feb78b4311d2033283a8/content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationListenerTest.java

Status: Started (was: Assigned)
Reverting the revert as it was getting very flaky because of another test issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/535ce599bbb560914af0b054a20051e37b54d78b

commit 535ce599bbb560914af0b054a20051e37b54d78b
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Mon Jan 08 13:52:52 2018

Revert "Disable flaky ScreenOrientation tests."

This reverts commit 0b2b0666dc524ad222a5feb78b4311d2033283a8.

Reason for revert: flake was due to another test failure, see https://bugs.chromium.org/p/chromium/issues/detail?id=645609#c21 and https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyYgsSBUZsYWtlIldvcmcuY2hyb21pdW0uY29udGVudC5icm93c2VyLlZpZGVvUm90YXRlVG9GdWxsc2NyZWVuVGVzdCN0ZXN0UG9ydHJhaXRUb0xhbmRzY2FwZUFuZEJhY2sM which has a similar pattern than https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVQsSBUZsYWtlIkpvcmcuY2hyb21pdW0uY29udGVudC5icm93c2VyLlNjcmVlbk9yaWVudGF0aW9uTGlzdGVuZXJUZXN0I3Rlc3RCYXNpY1ZhbHVlcww

Original change's description:
> Disable flaky ScreenOrientation tests.
> 
> Bug:  797175 
> Change-Id: Ic1650dd22a8764a1baef331f7801c0c97aa4c3b5
> TBR: mlamouri@chromium.org
> Reviewed-on: https://chromium-review.googlesource.com/845279
> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#526261}

TBR=mlamouri@chromium.org,sergeyu@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  797175 
Change-Id: I3afb261d35a1ba61883979c96d1dba411c64c90f
Reviewed-on: https://chromium-review.googlesource.com/852735
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527626}
[modify] https://crrev.com/535ce599bbb560914af0b054a20051e37b54d78b/content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationListenerTest.java

Status: Fixed (was: Started)

Sign in to add a comment