New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 797173 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference WRITE in blink::PresentationController::SetPresentation

Project Member Reported by ClusterFuzz, Dec 22 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5180957610213376

Fuzzer: inferno_layout_test_unmodified
Job Type: mac_asan_content_shell
Platform Id: mac

Crash Type: Null-dereference WRITE
Crash Address: 0x000000000050
Crash State:
  blink::PresentationController::SetPresentation
  blink::Presentation::Create
  blink::NavigatorPresentation::presentation
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_content_shell&range=398017:398351

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5180957610213376

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Dec 22 2017

Components: Blink>PresentationAPI
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Cc: kkaluri@chromium.org
Labels: M-64 Test-Predator-Wrong
Owner: imch...@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possible suspects.
Using Code Search for the file, "PresentationController.cpp" assigning to the concern owner who might be related.

Suspect CL: https://chromium.googlesource.com/chromium/src/+/f8ffbec53206b897830b41c3472350db28d65a8e

imcheng@ -- Could you please look into the issue, kindly re-assign if this is not related to your changes.


Thank You.
Project Member

Comment 3 by ClusterFuzz, Dec 23 2017

Labels: OS-Linux

Comment 4 by mfo...@chromium.org, Mar 15 2018

Labels: -M-64 M-66
Let's see if we can land a fix for M66.

Comment 5 by mfo...@chromium.org, Mar 15 2018

The attachment has the test case with readable Javascript.

It looks like we are not handling the case where navigator->GetFrame() returns nullptr (detached frame).

fuzz-59.html
2.1 KB View Download

Comment 6 by mfo...@chromium.org, Mar 20 2018

Cc: imch...@chromium.org
Owner: mfo...@chromium.org
Status: Started (was: Assigned)

Comment 7 by mfo...@chromium.org, Mar 20 2018

Status: Available (was: Started)
Unfortunately, blocked on https://github.com/google/clusterfuzz-tools/issues/531




Project Member

Comment 8 by ClusterFuzz, Mar 21 2018

ClusterFuzz has detected this issue as fixed in range 544435:544631.

Detailed report: https://clusterfuzz.com/testcase?key=5180957610213376

Fuzzer: inferno_layout_test_unmodified
Job Type: mac_asan_content_shell
Platform Id: mac

Crash Type: Null-dereference WRITE
Crash Address: 0x000000000050
Crash State:
  blink::PresentationController::SetPresentation
  blink::Presentation::Create
  blink::NavigatorPresentation::presentation
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_content_shell&range=398017:398351
Fixed: https://clusterfuzz.com/revisions?job=mac_asan_content_shell&range=544435:544631

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5180957610213376

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Mar 21 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Available)
ClusterFuzz testcase 5180957610213376 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment