[telemetry] 'CrOSBrowserBackend' object has no attribute 'HasBrowserFinishedLaunching' |
||||
Issue description
The veyron_minnie-tot-chrome-pfq-informational bot failed with the following telementary related issue:
Traceback (most recent call last):
File "/usr/local/autotest/common_lib/test.py", line 631, in _exec
_call_test_function(self.execute, *p_args, **p_dargs)
File "/usr/local/autotest/common_lib/test.py", line 837, in _call_test_function
raise error.UnhandledTestFail(e)
UnhandledTestFail: Unhandled AttributeError: 'CrOSBrowserBackend' object has no attribute 'HasBrowserFinishedLaunching'
See detailed log in starting from build
https://luci-milo.appspot.com/buildbot/chromeos/veyron_minnie-chrome-pfq/2228
This error has propagated into many chromeos pfq bots.
It looks like only two telementary related roll from the first failed build:
https://luci-milo.appspot.com/buildbot/chromeos/veyron_minnie-chrome-pfq/2228
I guess one of them could be the root cause.
,
Dec 22 2017
,
Dec 22 2017
The detailed error log is as follows.
Traceback (most recent call last):
File "/usr/local/autotest/common_lib/test.py", line 831, in _call_test_function
return func(*args, **dargs)
File "/usr/local/autotest/common_lib/test.py", line 495, in execute
dargs)
File "/usr/local/autotest/common_lib/test.py", line 362, in _call_run_once_with_retry
postprocess_profiled_run, args, dargs)
File "/usr/local/autotest/common_lib/test.py", line 400, in _call_run_once
self.run_once(*args, **dargs)
File "/usr/local/autotest/cros/video/helper_logger.py", line 82, in call
return func(*args, **kwargs)
File "/usr/local/autotest/tests/video_VideoSanity/video_VideoSanity.py", line 57, in run_once
init_network_controller=True) as cr:
File "/usr/local/autotest/common_lib/cros/chrome.py", line 171, in __init__
self._browser = browser_to_create.Create(finder_options)
File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/cros_browser_finder.py", line 51, in Create
browser_backend, self._platform_backend)
File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/cros_browser_with_oobe.py", line 14, in __init__
backend, platform_backend)
File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/browser/browser.py", line 41, in __init__
self._browser_backend.Start()
File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
return func(*args, **kwargs)
File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py", line 202, in Start
self._WaitForLogin()
File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
return func(*args, **kwargs)
File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py", line 312, in _WaitForLogin
py_utils.WaitFor(self._IsLoggedIn, 900)
File "/usr/local/telemetry/src/third_party/catapult/common/py_utils/py_utils/__init__.py", line 129, in WaitFor
res = condition()
File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
return func(*args, **kwargs)
File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py", line 308, in _IsLoggedIn
return not self._GetLoginStatus()
File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
return func(*args, **kwargs)
File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py", line 299, in _GetLoginStatus
if not self.HasBrowserFinishedLaunching():
AttributeError: 'CrOSBrowserBackend' object has no attribute 'HasBrowserFinishedLaunching'
,
Dec 22 2017
Hm, looks like telemetry unit tests are failing as well: https://build.chromium.org/p/chromiumos.chromium/builders/amd64-generic-telemetry
,
Dec 22 2017
Possibly the catapult roll in the first failing amd64-generic-telemetry build? https://chromium-review.googlesource.com/c/chromium/src/+/836694
,
Dec 22 2017
Ah, yes, this change description indicates that HasBrowserFinishedLaunching is relpaced with HasDevToolsConnection: https://chromium.googlesource.com/catapult.git/+/a586b0072a208470e55680d2d6f097e5b7c674ff%5E%21/#F2
,
Dec 22 2017
I commented on the CL where it's missing the API call change. I'll see if I can git clone the repo and fix it. https://chromium-review.googlesource.com/c/catapult/+/833925
,
Dec 22 2017
Looks like it's been fixed in the catapult repo already: commit 436908b7d264b36cf00478756f59f109e93e31a5 Author: Juan Antonio Navarro Perez <perezju@google.com> Date: Thu Dec 21 09:01:28 2017 +0000 [Telemetry] Fix cros_browser_backend The HasBrowserFinishedLaunching method was removed at: https://chromium-review.googlesource.com/c/catapult/+/833925 But a reference to it remained in the cros_browser_backend; replacing that with the new HasDevToolsConnection instead. TBR=nednguyen@google.com,achuith@chromium.org Bug: chromium:787834 Change-Id: I4b21427bd8bbb08f4e6d96ce05060b163961a77d Reviewed-on: https://chromium-review.googlesource.com/839140 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
,
Dec 22 2017
Fix rolled into chromium/src 14 hours ago: https://chromium-review.googlesource.com/c/chromium/src/+/839541
,
Dec 22 2017
Yes, sorry for the trouble caused by my CL! Do you think the issue is fixed now? Or are we seeing new failures?
,
Dec 22 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by jen...@chromium.org
, Dec 22 2017