New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 797142 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 796210



Sign in to add a comment

staging test: failure in setting up ssp

Project Member Reported by pprabhu@chromium.org, Dec 21 2017

Issue description

Failed test: http://chromeos-staging-master2.hot.corp.google.com/afe/#tab_id=view_job&object_id=7126

Due to issue 797135 logs are not available via tko
Get 'em from gs://chromeos-autotest-results/7126-chromeos-test

relevant snippet is in:pprabhu@pprabhu:~/scratch/7126-chromeos-test$ tail -n 30 chromeos2-row1-rack2-host1/ssp_logs/debug/autoserv.ERROR 
12/21 14:31:55.779 ERROR|         traceback:0013| Traceback (most recent call last):
12/21 14:31:55.779 ERROR|         traceback:0013|   File "/usr/local/autotest/server/autoserv", line 507, in run_autoserv
12/21 14:31:55.780 ERROR|         traceback:0013|     machines)
12/21 14:31:55.780 ERROR|         traceback:0013|   File "/usr/local/autotest/server/autoserv", line 172, in _run_with_ssp
12/21 14:31:55.780 ERROR|         traceback:0013|     'ssp_logs folder for more details.' % e)
12/21 14:31:55.780 ERROR|         traceback:0013|   File "/usr/local/autotest/client/common_lib/error.py", line 143, in __str__
12/21 14:31:55.780 ERROR|         traceback:0013|     msg += '\n' + repr(self.result_obj)
12/21 14:31:55.780 ERROR|         traceback:0013| UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 275: ordinal not in range(128)
12/21 14:31:55.916 ERROR|          autoserv:0759| Uncaught SystemExit with code 1
Traceback (most recent call last):
  File "/usr/local/autotest/server/autoserv", line 755, in main
    use_ssp)
  File "/usr/local/autotest/server/autoserv", line 562, in run_autoserv
    sys.exit(exit_code)
SystemExit: 1

 
Blocking: 796210
Cc: ihf@chromium.org kenobi@chromium.org
This is one of two blocking bugs for a successful test_push (and hence push-to-prod)
Cc: jrbarnette@chromium.org

Comment 4 by ihf@chromium.org, Dec 21 2017

Taking a look.

Comment 5 by ihf@chromium.org, Dec 21 2017

I can't find logs, all the links go into nowhere.

Comment 6 by ihf@chromium.org, Dec 21 2017

Oh, I see your comment.

I hacked server/autoserv in staging drone to not try to be too smart and eat up my stack trace, and reran that test:

http://chromeos-staging-master2.hot.corp.google.com/afe/#tab_id=view_job&object_id=7138
results are at:
gsutil -m cp -r gs://chromeos-autotest-results/7138-pprabhu ~/scratch/


12/21 15:52:44.705 ERROR|         traceback:0013| Traceback (most recent call last):
12/21 15:52:44.705 ERROR|         traceback:0013|   File "/usr/local/autotest/server/autoserv", line 507, in run_autoserv
12/21 15:52:44.705 ERROR|         traceback:0013|     machines)
12/21 15:52:44.705 ERROR|         traceback:0013|   File "/usr/local/autotest/server/autoserv", line 168, in _run_with_ssp
12/21 15:52:44.706 ERROR|         traceback:0013|     dut_name=dut_name)
12/21 15:52:44.706 ERROR|         traceback:0013|   File "/usr/local/autotest/site-packages/chromite/lib/metrics.py", line 483, in wrapper
12/21 15:52:44.706 ERROR|         traceback:0013|     return fn(*args, **kwargs)
12/21 15:52:44.706 ERROR|         traceback:0013|   File "/usr/local/autotest/site_utils/lxc/cleanup_if_fail.py", line 40, in func_cleanup_if_fail
12/21 15:52:44.707 ERROR|         traceback:0013|     return func(*args, **kwargs)
12/21 15:52:44.707 ERROR|         traceback:0013|   File "/usr/local/autotest/site_utils/lxc/container_bucket.py", line 196, in setup_test
12/21 15:52:44.707 ERROR|         traceback:0013|     deploy_config_manager.deploy_pre_start()
12/21 15:52:44.707 ERROR|         traceback:0013|   File "/usr/local/autotest/site_utils/lxc/config.py", line 384, in deploy_pre_start
12/21 15:52:44.708 ERROR|         traceback:0013|     self._deploy_config_pre_start(deploy_config)
12/21 15:52:44.708 ERROR|         traceback:0013|   File "/usr/local/autotest/site_utils/lxc/config.py", line 256, in _deploy_config_pre_start
12/21 15:52:44.708 ERROR|         traceback:0013|     self.container.copy(deploy_config.source, target)
12/21 15:52:44.708 ERROR|         traceback:0013|   File "/usr/local/autotest/site_utils/lxc/zygote.py", line 162, in copy
12/21 15:52:44.709 ERROR|         traceback:0013|     sudo=False)
12/21 15:52:44.709 ERROR|         traceback:0013|   File "/usr/local/autotest/site_utils/lxc/container.py", line 571, in _do_copy
12/21 15:52:44.709 ERROR|         traceback:0013|     utils.run(cmds)
12/21 15:52:44.709 ERROR|         traceback:0013|   File "/usr/local/autotest/client/common_lib/utils.py", line 738, in run
12/21 15:52:44.710 ERROR|         traceback:0013|     "Command returned non-zero exit status")
12/21 15:52:44.712 ERROR|         traceback:0013| CmdError: <unprintable CmdError object>

CL to blame: https://chromium-review.googlesource.com/837180
utils doesn't like the bash redirection for some reason.

I'm going to revert this CL and try the push again. Sorta important to get this push right first.
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f6bc7c9cbd9275dfa6690ac416bcf23b270bbeff

commit f6bc7c9cbd9275dfa6690ac416bcf23b270bbeff
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Fri Dec 22 00:03:47 2017

Revert "[autotest] Reduce sudo calls."

This reverts commit 91f39fe86cba0e20ca6d9085aedb10e9f33aad83.

Reason for revert: Broke SSP testing in staging lab.

Original change's description:
> [autotest] Reduce sudo calls.
> 
> Remove unnecessary sudo calls from the zygote's setup code-path.
> Basically, anything that involves copying stuff into the container's
> filesystem requires sudo in a regular container, but not in a zygote.
> 
> Some utility and other code required special-casing, so a sudo parameter
> was added to enable the zygote to do these operations without using sudo.
> 
> This reduces the number of sudo calls seen in the functional test from
> 94 to 76.  Similar savings ought to be seen in real tests.
> 
> BUG=b:70818060
> TEST=shared_host_dir_unittest.py
> TEST=container_pool/pool_unittest.py
> TEST=container_pool/client_unittest.py
> TEST=container_pool/async_listener_unittest.py
> TEST=container_pool/service_unittest.py
> TEST=base_image_unittest.py
> TEST=lxc_config_unittest.py
> TEST=container_bucket_unittest.py
> TEST=container_unittest.py
> TEST=container_factory_unittest.py
> TEST=zygote_unittest.py
> TEST=lxc_functional_test.py
> 
> Change-Id: Ib8bb1f3a227ed88dbabe3a3c0eb71080e6e696f7
> Reviewed-on: https://chromium-review.googlesource.com/837180
> Trybot-Ready: Ben Kwa <kenobi@chromium.org>
> Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
> Commit-Queue: Ilja H. Friedel <ihf@chromium.org>
> Tested-by: Ilja H. Friedel <ihf@chromium.org>

BUG=b:70818060
BUG= chromium:797142 

Change-Id: If43d7d8e511fc0b4d4ffb34a8b272b7c9ab10953
Reviewed-on: https://chromium-review.googlesource.com/841430
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/f6bc7c9cbd9275dfa6690ac416bcf23b270bbeff/site_utils/lxc/zygote.py
[modify] https://crrev.com/f6bc7c9cbd9275dfa6690ac416bcf23b270bbeff/site_utils/lxc/config.py
[modify] https://crrev.com/f6bc7c9cbd9275dfa6690ac416bcf23b270bbeff/site_utils/lxc/container.py
[modify] https://crrev.com/f6bc7c9cbd9275dfa6690ac416bcf23b270bbeff/site_utils/lxc/utils.py
[modify] https://crrev.com/f6bc7c9cbd9275dfa6690ac416bcf23b270bbeff/site_utils/lxc/lxc.py

Comment 11 by ihf@chromium.org, Dec 22 2017

Thank you for reverting!
Status: Fixed (was: Started)
test push passed (sort-of)

Sign in to add a comment