New issue
Advanced search Search tips

Issue 797140 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

optionally mount image in LoadComponent API

Project Member Reported by xiaochu@chromium.org, Dec 21 2017

Issue description

allow optionally mount image.

component like arc++ does not want to load the component after an update/install for A/B update purpose.
 
Description: Show this description
Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f8ddea7d00964ec6c0b3e61e3d02882ea380f1f

commit 9f8ddea7d00964ec6c0b3e61e3d02882ea380f1f
Author: Xiaochu Liu <xiaochu@chromium.org>
Date: Thu Jan 18 20:08:36 2018

optionally mount image loading a component

Add a bool parameter |mount| in Load API. It allows developer to control
whether to mount the image or not after component is installed.

I also add an alias for LoadCallback to increase readability.

BUG= chromium:797140 
TEST=call Load API with true/false.

Change-Id: I2322eb95b59ea82cd8f51556cea14c424504fad1
Reviewed-on: https://chromium-review.googlesource.com/855097
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Xiaochu Liu <xiaochu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530248}
[modify] https://crrev.com/9f8ddea7d00964ec6c0b3e61e3d02882ea380f1f/chrome/browser/chromeos/dbus/chrome_component_updater_service_provider_delegate.cc
[modify] https://crrev.com/9f8ddea7d00964ec6c0b3e61e3d02882ea380f1f/chrome/browser/chromeos/dbus/chrome_component_updater_service_provider_delegate.h
[modify] https://crrev.com/9f8ddea7d00964ec6c0b3e61e3d02882ea380f1f/chrome/browser/chromeos/printing/printer_configurer.cc
[modify] https://crrev.com/9f8ddea7d00964ec6c0b3e61e3d02882ea380f1f/chrome/browser/component_updater/cros_component_installer.cc
[modify] https://crrev.com/9f8ddea7d00964ec6c0b3e61e3d02882ea380f1f/chrome/browser/component_updater/cros_component_installer.h
[modify] https://crrev.com/9f8ddea7d00964ec6c0b3e61e3d02882ea380f1f/chrome/browser/extensions/api/media_perception_private/media_perception_api_delegate_chromeos.cc
[modify] https://crrev.com/9f8ddea7d00964ec6c0b3e61e3d02882ea380f1f/chromeos/dbus/services/component_updater_service_provider.cc
[modify] https://crrev.com/9f8ddea7d00964ec6c0b3e61e3d02882ea380f1f/chromeos/dbus/services/component_updater_service_provider.h

Status: Fixed (was: Untriaged)

Sign in to add a comment